rahil-c commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1665217122
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -221,6 +221,69 @@ public void testUpdateTable() {
assertThat(response.table().description()).isEqualTo(updatedComment);
}
+ @Test
+ public void testDropColumn() {
+ String namespace = createNamespace();
+ String tableName = createTable(namespace);
+ Table table = glueCatalog.loadTable(TableIdentifier.of(namespace,
tableName));
+ table
+ .updateSchema()
+ .addColumn("c2", Types.StringType.get(), "updated from Iceberg API")
+ .addColumn("c3", Types.StringType.get())
+ .commit();
+
+ updateTableColumns(
+ namespace,
+ tableName,
+ column -> {
+ if (column.name().equals("c3")) {
+ return column.toBuilder().comment("updated from Glue API").build();
+ } else {
+ return column;
+ }
+ });
+
+ table.updateSchema().deleteColumn("c2").deleteColumn("c3").commit();
Review Comment:
@lawofcycles For my own understanding but when you do the deleteColums and
commit shouldn't this sync to catalog and these columns not be present anymore
from glue? Or is this commit only changing the iceberg metadata in S3, and thus
thats why the assertion is working correctly below as the catalog still has not
the updated view of the table and contains the comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
