aajisaka commented on code in PR #10276:
URL: https://github.com/apache/iceberg/pull/10276#discussion_r1631813358
##########
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##########
@@ -231,11 +255,33 @@ static void setTableInputInformation(
.collect(Collectors.toSet()));
}
- Optional.ofNullable(properties.get(GLUE_DESCRIPTION_KEY))
- .ifPresent(tableInputBuilder::description);
+ String description = properties.get(GLUE_DESCRIPTION_KEY);
+ if (description != null) {
+ tableInputBuilder.description(description);
+ } else if (existingTable != null) {
+
Optional.ofNullable(existingTable.description()).ifPresent(tableInputBuilder::description);
+ }
+
+ List<Column> columns = toColumns(metadata);
Review Comment:
I'm thinking we can simplify the implementation by creating
`existingColumnMap` first and use it inside `addColumnWithDedupe` method. In
this way we don't have to replace the new columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
