anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2690899362
Thanks @nastra - I moved S3 tests back to where they were. This PR contains
only Azure tests moved to integration source set now.
--
This is an automated message from the Apache
nastra commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2690310516
@anuragmantri as you already mentioned earlier, I think we should revert the
AWS stuff in this PR. The problem is that `./gradlew
:iceberg-aws:integrationTest` is never being executed as
anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2669375531
Hi @Fokko - Gentle ping on this one. Maybe we can put this in 1.8.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2664824667
> so adding check.dependsOn integrationTest on iceberg-aws module would
break CI
Another option to still run the `S3FileIO` tests is to create a new source
set called `docke
nastra commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2664797488
@Fokko can you also take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2664067160
I turns out, we don't run AWS CI workflow at all. See
https://github.com/apache/iceberg/pull/4855 and
https://github.com/apache/iceberg/pull/5826 so adding `check.dependsOn
integr
anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2663830276
I see some CI failures complaining of missing environment variables now. I
can reproduce them locally.
```
java.lang.NullPointerException: region must not be null.
anuragmantri commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1958602356
##
azure/src/integration/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
Review Comment:
I moved this file back.
--
This is an automated
anuragmantri commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1958600915
##
build.gradle:
##
@@ -546,6 +546,27 @@ project(':iceberg-azure') {
testImplementation libs.esotericsoftware.kryo
testImplementation libs.testcontaine
nastra commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1957734542
##
azure/src/integration/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
Review Comment:
this file is a normal unit test so it can stay
--
This
nastra commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1957732904
##
build.gradle:
##
@@ -546,6 +546,27 @@ project(':iceberg-azure') {
testImplementation libs.esotericsoftware.kryo
testImplementation libs.testcontainers
anuragmantri commented on PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#issuecomment-2660435251
The moved classes include `TestS3FileIO` (see
https://github.com/apache/iceberg/issues/12237) and `ADLSFileIOTest`. These
seem like unit tests that need to run with `gradle test`.
anuragmantri commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1956788320
##
.baseline/checkstyle/checkstyle-suppressions.xml:
##
@@ -23,16 +23,16 @@
for your changes to take effect in its Checkstyle integration. -->
-
-
anuragmantri opened a new pull request, #12274:
URL: https://github.com/apache/iceberg/pull/12274
Fixes: https://github.com/apache/iceberg/issues/12236
During the testing of new releases, some community members observed test
failures for certain Docker-based tests. I have encountered
anuragmantri commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1956753811
##
baseline.gradle:
##
@@ -78,7 +78,7 @@ subprojects {
tasks.withType(JavaCompile).configureEach {
options.errorprone.errorproneArgs.addAll (
15 matches
Mail list logo
