nastra commented on code in PR #12274:
URL: https://github.com/apache/iceberg/pull/12274#discussion_r1957732904
##########
build.gradle:
##########
@@ -546,6 +546,27 @@ project(':iceberg-azure') {
testImplementation libs.esotericsoftware.kryo
testImplementation libs.testcontainers
}
+
+ sourceSets {
+ integration {
+ java.srcDir "$projectDir/src/integration/java"
+ resources.srcDir "$projectDir/src/integration/resources"
+ compileClasspath += main.output + test.output
+ runtimeClasspath += main.output + test.output
+ }
+ }
+
+ configurations {
+ integrationImplementation.extendsFrom testImplementation
+ integrationRuntime.extendsFrom testRuntimeOnly
+ }
+
+ task integrationTest(type: Test) {
+ useJUnitPlatform()
+ testClassesDirs = sourceSets.integration.output.classesDirs
+ classpath = sourceSets.integration.runtimeClasspath
+ jvmArgs += project.property('extraJvmArgs')
+ }
Review Comment:
this also needs `check.dependsOn integrationTest` right after this line. I
believe the same needs to be updated for `iceberg-s3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
