anuragmantri commented on code in PR #12274: URL: https://github.com/apache/iceberg/pull/12274#discussion_r1956788320
########## .baseline/checkstyle/checkstyle-suppressions.xml: ########## @@ -23,16 +23,16 @@ for your changes to take effect in its Checkstyle integration. --> <suppressions> <!-- Suppress test classes --> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" checks="Javadoc*" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" checks="VariableDeclarationUsageDistance" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" checks="VisibilityModifier" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" checks="AvoidStaticImport" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" id="BanSystemOut" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" id="BanSystemErr" /> - <suppress files="[/\\]src[/\\].*[Tt]est[/\\](java|groovy)[/\\]" id="BanGuavaTesting" /> + <suppress files="[/\\]src[/\\].*([Tt]est|integration)[/\\](java|groovy)[/\\]" checks="Javadoc*" /> Review Comment: Had to suppress checkstyle on integration tests as well. Let me know if this is a concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org