rdblue merged PR #12304:
URL: https://github.com/apache/iceberg/pull/12304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
rdblue commented on PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#issuecomment-2673141341
Thanks for the reviews, @danielcweeks and @aihuaxu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535688
##
api/src/main/java/org/apache/iceberg/variants/VariantData.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535327
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535894
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535327
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964492886
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964492397
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964386149
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964390948
##
api/src/main/java/org/apache/iceberg/variants/VariantData.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964388546
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964387424
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964386149
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964369050
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
Variant
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964346663
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
Variant
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963985031
##
api/src/main/java/org/apache/iceberg/expressions/BoundExtract.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964228087
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964226588
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963985031
##
api/src/main/java/org/apache/iceberg/expressions/BoundExtract.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963978534
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963955290
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963955290
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963953648
##
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java:
##
@@ -124,13 +125,17 @@ public Expression bind(StructType struct, boolean
caseSensitive) {
aihuaxu commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960965228
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
aihuaxu commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1961993026
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
aihuaxu commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960945852
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
VariantValue
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960239029
##
api/src/main/java/org/apache/iceberg/expressions/BoundExtract.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960220240
##
api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960211875
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -25,4 +25,24 @@ public interface Variant {
/** Returns the variant value. */
Variant
rdblue opened a new pull request, #12304:
URL: https://github.com/apache/iceberg/pull/12304
This adds `Expressions.extract` to extract a value from a variant in Iceberg
filters.
The new method, `Expressions.extract(column, path, type)`, accepts a column
name, a JSON path, and a type.
30 matches
Mail list logo