danielcweeks commented on code in PR #12304:
URL: https://github.com/apache/iceberg/pull/12304#discussion_r1960211875


##########
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##########
@@ -25,4 +25,24 @@ public interface Variant {
 
   /** Returns the variant value. */
   VariantValue value();
+
+  /**
+   * Query the value with a given path.
+   *
+   * <p>The path format is a subset of JSON path that supports:
+   *
+   * <ul>
+   *   <li><code>$</code> the root value
+   *   <li><code>.name</code> accesses a field by name

Review Comment:
   I'm a little wary of the dot notation because of the collision with dots in 
field names.  Also, I believe the bracket notation is considered the canonical 
notation.  I just think we're going to immediately run into an issue with 
collisions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to