aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419845857
##
api/src/test/java/org/apache/iceberg/util/TestCharSequenceSet.java:
##
@@ -79,4 +81,35 @@ public void testRemoveAll() {
Assertions.assertThat(set).isEmpty
aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419844248
##
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Objec
aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419845126
##
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Objec
aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419844796
##
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Objec
aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419844248
##
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Objec
aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419690269
##
api/src/test/java/org/apache/iceberg/util/TestCharSequenceSet.java:
##
@@ -79,4 +81,35 @@ public void testRemoveAll() {
Assertions.assertThat(set).isEmpty
aokolnychyi opened a new pull request, #9245:
URL: https://github.com/apache/iceberg/pull/9245
The `equals` and `hashCode` behaviors contradict the `Set` API, which
prohibits wrapping `CharSequenceSet` instances into unmodifiable wrappers in
`CharSequenceMap$keySet`.
```
/**
*
