aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419844248
##########
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##########
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Object o) {
- if (this == o) {
+ public boolean equals(Object other) {
Review Comment:
See `Set.equals()` and `AbstractSet.equals()` for comparison.
##########
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##########
@@ -168,22 +167,29 @@ public void clear() {
}
@Override
- public boolean equals(Object o) {
- if (this == o) {
+ public boolean equals(Object other) {
Review Comment:
See `Set.equals()` and `AbstractSet.equals()` for background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
