aokolnychyi commented on code in PR #9245:
URL: https://github.com/apache/iceberg/pull/9245#discussion_r1419690269
##########
api/src/test/java/org/apache/iceberg/util/TestCharSequenceSet.java:
##########
@@ -79,4 +81,35 @@ public void testRemoveAll() {
Assertions.assertThat(set).isEmpty();
}
+
+ @Test
+ public void testEqualsAndHashCode() {
+ CharSequenceSet set1 = CharSequenceSet.empty();
+ CharSequenceSet set2 = CharSequenceSet.empty();
+
+ Assertions.assertThat(set1).isEqualTo(set2);
+ Assertions.assertThat(set1.hashCode()).isEqualTo(set2.hashCode());
+
+ set1.add("v1");
+ set1.add("v2");
+ set1.add("v3");
+
+ set2.add(new StringBuilder("v1"));
+ set2.add(new StringBuffer("v2"));
+ set2.add("v3");
+
+ Set<CharSequence> set3 = Collections.unmodifiableSet(set2);
Review Comment:
I am primarily interested in wrapping `CharSequenceSet` into
`UnmodifiableSet` in `CharSequenceMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
