nastra merged PR #12227:
URL: https://github.com/apache/iceberg/pull/12227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#issuecomment-2658878696
LGTM, thanks @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
rdblue commented on PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#issuecomment-2654232149
> Also I think it would be good to update all of the usages in
`SchemaUpdate` to the non-deprecated methods
That's done in #12211. This will be rebased and merged after that one go
rdblue commented on code in PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#discussion_r1953007263
##
orc/src/main/java/org/apache/iceberg/orc/OrcToIcebergVisitor.java:
##
@@ -43,7 +43,12 @@ public Optional record(
.map(Optional::get)
nastra commented on code in PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#discussion_r1952812642
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -539,10 +539,18 @@ public static NestedField required(int id, String name,
Type type, String doc) {
nastra commented on code in PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#discussion_r1952794717
##
orc/src/main/java/org/apache/iceberg/orc/OrcToIcebergVisitor.java:
##
@@ -43,7 +43,12 @@ public Optional record(
.map(Optional::get)
rdblue opened a new pull request, #12227:
URL: https://github.com/apache/iceberg/pull/12227
This is a follow up to #12211. While adding support for default values in
`UpdateSchema`, many of the changes were to use the `NestedField` builder's
copy constructor, `from(NestedField)`, so that fi
