nastra commented on code in PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#discussion_r1952812642
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -539,10 +539,18 @@ public static NestedField required(int id, String name,
Type type, String doc) {
return new NestedField(false, id, name, type, doc, null, null);
}
+ /**
+ * @deprecated will be removed in 2.0.0; use builder() instead.
Review Comment:
nit: we typically try to use javadoc links here when possible
```suggestion
* @deprecated will be removed in 2.0.0; use {@link #builder()} instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
