rdblue commented on code in PR #12227:
URL: https://github.com/apache/iceberg/pull/12227#discussion_r1953007263
##########
orc/src/main/java/org/apache/iceberg/orc/OrcToIcebergVisitor.java:
##########
@@ -43,7 +43,12 @@ public Optional<Types.NestedField> record(
.map(Optional::get)
.collect(Collectors.toList()));
return Optional.of(
- Types.NestedField.of(icebergIdOpt.get(), isOptional,
currentFieldName(), structType));
+ Types.NestedField.builder()
Review Comment:
Oops. That was done in #12211. This one depends on that going in first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
