Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-2424318493 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] closed pull request #9414: API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs URL: https://github.com/apache/iceberg/pull/9414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-10-12 Thread via GitHub
github-actions[bot] commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-2408754863 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-12 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1450860911 ## core/src/main/java/org/apache/iceberg/view/ViewVersionReplace.java: ## @@ -56,30 +63,71 @@ public ViewVersion apply() { } ViewMetadata internalApply

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-05 Thread via GitHub
amogh-jahagirdar commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1879243149 > That line of reasoning makes me think that any change (even comments) should just produce a new version of the view. Yes, that's the approach in this PR currently. A new

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-05 Thread via GitHub
rdblue commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1879017514 Oops, I didn't intend to close this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-05 Thread via GitHub
rdblue commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1878993066 @amogh-jahagirdar, I agree with not adding a `with` method to modify a schema. If we can avoid making that kind of API addition I would prefer it. I'm also not sure that we want to m

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-05 Thread via GitHub
rdblue closed pull request #9414: API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs URL: https://github.com/apache/iceberg/pull/9414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1878270693 Hmafter thinking about this a bit more, I think we can remove the Schema API and add an API to ReplaceViewVersion `withUpdatedColumnDoc`. This API can do change tracking and

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442541492 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442541492 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442535706 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442535706 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes