rdblue commented on PR #9414:
URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1878993066

   @amogh-jahagirdar, I agree with not adding a `with` method to modify a 
schema. If we can avoid making that kind of API addition I would prefer it.
   
   I'm also not sure that we want to modify existing views by updating the 
schema. That's a lot of validation and complexity. The schema should be 
produced by fairly standard SQL syntax:
   
   ```sql
   CREATE OR REPLACE VIEW default.event_agg (
       event_count COMMENT 'Count of events',
       event_date)
   COMMENT 'Daily event counts'
   AS
   SELECT
       COUNT(1), CAST(event_ts AS DATE)
   FROM prod.default.events
   GROUP BY 2
   ```
   
   If we allow making schema
   -only changes, then would we also allow modifying the view by 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to