Re: [PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-09-09 Thread via GitHub
manuzhang commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1751206372 ## core/src/test/java/org/apache/iceberg/avro/TestReadDefaultValues.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-08-13 Thread via GitHub
wmoustafa commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1716157111 ## core/src/test/java/org/apache/iceberg/avro/TestReadDefaultValues.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-08-13 Thread via GitHub
wmoustafa commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1716149183 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f r

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-07-09 Thread via GitHub
wmoustafa commented on PR #9502: URL: https://github.com/apache/iceberg/pull/9502#issuecomment-2219083258 > One more thing, we're also leaking V3 spec features into the codebase. Should we guard that with a flag? It does not seem we can easily access format version in those reader cl

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-07-09 Thread via GitHub
wmoustafa commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1671303834 ## core/src/test/java/org/apache/iceberg/avro/TestReadDefaultValues.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-07-09 Thread via GitHub
wmoustafa commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1671302722 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f r

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on PR #9502: URL: https://github.com/apache/iceberg/pull/9502#issuecomment-2174271818 One more thing, we're also leaking V3 spec features into the codebase. Should we guard that with a flag? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643326216 ## core/src/test/java/org/apache/iceberg/avro/TestReadDefaultValues.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643322829 ## core/src/test/java/org/apache/iceberg/avro/TestReadDefaultValues.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643308001 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f retur

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643308001 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f retur

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643299107 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f retur

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-17 Thread via GitHub
Fokko commented on code in PR #9502: URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643294155 ## core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java: ## @@ -155,6 +162,41 @@ public ValueReader record(Type partner, Schema record, List> f retur

Re: [PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-06-14 Thread via GitHub
wmoustafa commented on PR #9502: URL: https://github.com/apache/iceberg/pull/9502#issuecomment-2168482841 @Fokko Could you please take a look since you helped with #9366? FYI @rdblue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] [Reference PR] [API + Avro] Add default value APIs and Avro implementation [iceberg]

2024-01-17 Thread via GitHub
wmoustafa opened a new pull request, #9502: URL: https://github.com/apache/iceberg/pull/9502 This PR adds default value APIs according to the default value spec, and implements it in the `GenericAvroReader` case. It uses a `ConstantReader` to fill in the default values of fields from their