Fokko commented on code in PR #9502:
URL: https://github.com/apache/iceberg/pull/9502#discussion_r1643294155
##########
core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java:
##########
@@ -155,6 +162,41 @@ public ValueReader<?> record(Type partner, Schema record,
List<ValueReader<?>> f
return recordReader(readPlan, avroSchemas.get(partner),
record.getFullName());
}
+ Object toGenericRecord(Type type, Object data) {
+ // Recursively convert data to GenericRecord if type is a StructType.
+ // TODO: Rewrite this as a visitor.
Review Comment:
Converting this into a `TypeUtil.SchemaVisitor` would make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
