wmoustafa opened a new pull request, #9502: URL: https://github.com/apache/iceberg/pull/9502
This PR adds default value APIs according to the default value spec, and implements it in the `GenericAvroReader` case. It uses a `ConstantReader` to fill in the default values of fields from their respective `initialDefault()` method. This PR rebases the implementation in #6004 on top of #9366. However, this PR is just a reference PR for now since there is still an open question about the best place to convert from Iceberg's data model to the Avro data model. For now, I have an Avro-specific method in `ValueReaders` but that is not the correct place. I think a better place is in `GenericAvroReader` where an Avro-specific class extends `ValueReaders.ConstantReader<T>`; however, `ValueReaders.ConstantReader<T>` is currently private. Creating this PR to start a discussion about the best place for constant (in-memory) data conversion. I have marked such places (where a future change is required) as TODO items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
