Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-26 Thread via GitHub
chinmay-bhat commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132772245 Thank you for clarifying! Here's how I imagine manifests() would look like :) ``` @lru_cache() def manifests(self, manifest_location: str) -> List[ManifestFi

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-26 Thread via GitHub
Fokko commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132381356 @chinmay-bhat I don't think it is as easy as that. We should ensure that the `manifest_list` path is part of the cache. We could share the cache between calls, since if you do sub

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-26 Thread via GitHub
chinmay-bhat commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132370830 Thanks @Fokko for the quick response. > based on the path to the metadata to cache it I'm not clear on this. Are you saying we can simply add `lru_cache` to `de

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-26 Thread via GitHub
Fokko commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132364651 @chinmay-bhat I think we can generalize this quite easily, since from the spec: > Once written, data and metadata files are immutable until they are deleted. I think

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-26 Thread via GitHub
chinmay-bhat commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132350280 Hi, can we increase the scope of this issue to cache/store all_manifests, data_manifests & delete_manifests? Or do I create a new issue for this? This feature would be usef

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-05-18 Thread via GitHub
MehulBatra commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2118850969 Hi @swapdewalkar I wanted to check in and see if you have any updates on this task. If you need any assistance or if there are any obstacles, please let me know—I will be hap

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-04-10 Thread via GitHub
Fokko commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2047703495 @swapdewalkar Thanks for picking this up! I've just assigned it to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] Implement caching of manifest-files [iceberg-python]

2024-04-10 Thread via GitHub
swapdewalkar commented on issue #595: URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2047668021 I am trying to working on this, is it possible to assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[I] Implement caching of manifest-files [iceberg-python]

2024-04-10 Thread via GitHub
Fokko opened a new issue, #595: URL: https://github.com/apache/iceberg-python/issues/595 ### Feature Request / Improvement We currently loop over the manifests of a snapshot often just once. But now when we're compounding the operations (DELETE+APPEND), there is a fair chance that re