chinmay-bhat commented on issue #595:
URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132772245
Thank you for clarifying! Here's how I imagine manifests() would look like :)
```
@lru_cache()
def manifests(self, manifest_location: str) -> List[ManifestFile]:
if manifest_location is not None:
file = load_file_io().new_input(manifest_location)
return list(read_manifest_list(file))
return []
```
When we call `snapshot.manifests(snapshot.manifest_list)`, if manifest_list
is the same, we simply query the cached files. But if the snapshot is updated,
manifest_list is also updated, and calling manifests() triggers a re-read of
manifest files.
Is this similar to what you have in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
