chinmay-bhat commented on issue #595:
URL: https://github.com/apache/iceberg-python/issues/595#issuecomment-2132370830
Thanks @Fokko for the quick response.
> based on the path to the metadata to cache it
I'm not clear on this. Are you saying we can simply add `lru_cache` to `def
manifests(self, io: FileIO)` in class Snapshot? And then whenever we need data
manifests or delete manifests, we iterate over the cached manifests? Wouldn't
it be better to cache those too, since as you said, the files are immutable?
For ex:
```
@lru_cache
def manifests(self, io: FileIO):
......
@lru_cache
def data_manifests():
return [manifest_file for manifest_file in self.manifests if
manifest.content == ManifestContent.DATA]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
