Fokko commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2651851976
Sorry for being late here, my mailbox is a overflowing a bit.
The earlier example of:
```python
DATA_FILE_TYPE: Dict[int, StructType]
```
is wrong, and s
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2651411960
@kevinjqliu ok i will be starting this now, and will make a PR soon for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2638775180
@iyad-f I think we can start it and see where it takes us. its a good
exercise to see where we use version numbers. esp now that we need to add V3
--
This is an automated
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2634209677
So are we going with this approach, should i start working on this or wait
for @Fokko's recommendation?
--
This is an automated message from the Apache Git Service.
To respond
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-263242
just a quick search for format_version in the library tells me it would need
to be changed almost everywhere from tests to actual library code. If you have
decided on whether to
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2632199606
naming the class TableVersion can be a bit consistent with what it was
already, but at the same time error prone too if not noticed properly, since
type checking is also turned o
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2632188716
hm, good point.
https://github.com/apache/iceberg-python/blob/f195dadeb85b1c59f2cd85f80802344cc0842386/pyiceberg/table/metadata.py#L500
would be something like
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2632177429
also wherever format_version is used as a value would have to do
format_version.value
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2632167583
@kevinjqliu I would have to replace it in classes of TableMetadata too
right?, for example for TableMetadataV1 format_versio would now be something
like format_version: TableVers
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2632152803
@iyad-f sure, i dont think anyone else is working on it.
> just replace format version everywhere with it?
yea i think its more readable (and maintainable) to re
iyad-f commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2631535942
can i work on this issue ? I have already that we need an Enum and just
replace format version everywhere with it?
--
This is an automated message from the Apache Git Service.
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2501696638
@willcollins10 assigned to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
willcollins10 commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2499157156
Hi Kevin, I was hoping I could take up this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2362876509
Yep I think that should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tanmayrauth commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2362853568
So, I shall convert it to an Enum, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2358928986
> Even at places where someone is calling pyiceberg library from outside.
Looks like `TableVersion` is just a type declaration.
https://github.com/search?q=repo%3Aap
tanmayrauth commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2357506218
@kevinjqliu I found this TableVersion [declaration already
present](https://github.com/apache/iceberg-python/blob/de47590c6ac4f507cb2337c20504a62c484339f9/pyiceberg/typedef.p
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2353425819
@tanmayrauth Yes! The enum will be easier to work with. There are a lot of
raw string comparisons like this one
https://github.com/search?q=repo%3Aapache%2Ficeberg-python+pat
tanmayrauth commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2352048137
Thanks @kevinjqliu. What I understood I shall create a enum declaration for
(v1, v2, v3.. ) and get it replaced everywhere in code where we use 1, 2, 3...
for table version.
kevinjqliu commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2351854564
@tanmayrauth this seem stale, please feel free to work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tanmayrauth commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2351818325
@harsha-mangena are you still working on this ? If not, can I work on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jayceslesar commented on issue #851:
URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-222423
Could define a `BaseVersion` class or something that downstream classes
could inherit from in order to dish out versions of functions as expected/store
constants? Might be t
22 matches
Mail list logo
