tanmayrauth commented on issue #851: URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2357506218
@kevinjqliu I found this TableVersion [declaration already present](https://github.com/apache/iceberg-python/blob/de47590c6ac4f507cb2337c20504a62c484339f9/pyiceberg/typedef.py#L209). Shall we convert this to Enum ? The only challenge will be to make sure that at each place where number (1,2) is passed we will have to change it to TableVersion.V1/v2 else there will be type error. Even at places where someone is calling pyiceberg library from outside. If not the above approach then I can create an another Enum like **TableFormatVersion** and handle the original ask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
