Fokko commented on issue #851: URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2651851976
Sorry for being late here, my mailbox is a overflowing a bit. The earlier example of: ```python DATA_FILE_TYPE: Dict[int, StructType] ``` is wrong, and should be: ```python DATA_FILE_TYPE: Dict[TableVersion, StructType] ``` What's the benefit we get from turning this into an Enum? It seems more verbose to me. Also, things like: ``` from pyiceberg.typedef import FormatVersion tbl.upgrade_table_version(FormatVersion.V3) ``` Which is not very intuitive to the end users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
