Re: [PR] Build: Bump flask-cors from 5.0.1 to 6.0.0 [iceberg-python]

2025-05-17 Thread via GitHub
Fokko merged PR #2012: URL: https://github.com/apache/iceberg-python/pull/2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[PR] Build: Bump mkdocs-material from 9.6.13 to 9.6.14 [iceberg]

2025-05-17 Thread via GitHub
dependabot[bot] opened a new pull request, #13090: URL: https://github.com/apache/iceberg/pull/13090 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.13 to 9.6.14. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

[PR] Build: Bump software.amazon.s3.analyticsaccelerator:analyticsaccelerator-s3 from 1.0.0 to 1.1.0 [iceberg]

2025-05-17 Thread via GitHub
dependabot[bot] opened a new pull request, #13089: URL: https://github.com/apache/iceberg/pull/13089 Bumps [software.amazon.s3.analyticsaccelerator:analyticsaccelerator-s3](https://github.com/awslabs/analytics-accelerator-s3) from 1.0.0 to 1.1.0. Release notes Sourced from https:/

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.40 [iceberg]

2025-05-17 Thread via GitHub
dependabot[bot] commented on PR #13027: URL: https://github.com/apache/iceberg/pull/13027#issuecomment-2888753730 Superseded by #13088. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.40 [iceberg]

2025-05-17 Thread via GitHub
dependabot[bot] closed pull request #13027: Build: Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.40 URL: https://github.com/apache/iceberg/pull/13027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Build: Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.45 [iceberg]

2025-05-17 Thread via GitHub
dependabot[bot] opened a new pull request, #13088: URL: https://github.com/apache/iceberg/pull/13088 Bumps software.amazon.awssdk:bom from 2.31.35 to 2.31.45. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-17 Thread via GitHub
dentiny commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094290413 ## crates/iceberg/src/transaction/mod.rs: ## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } +/// Add snapshot summary properties. +

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-17 Thread via GitHub
jonathanc-n commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094282078 ## crates/iceberg/src/transaction/mod.rs: ## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } +/// Add snapshot summary propertie

Re: [PR] Migrate Flink TableSchema for IcebergSource [iceberg]

2025-05-17 Thread via GitHub
liamzwbao commented on PR #13072: URL: https://github.com/apache/iceberg/pull/13072#issuecomment-2888657994 Hi @ajantha-bhat @nastra. PTAL, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: Make converting external avro record schema to iceberg schema startin… [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] commented on PR #12756: URL: https://github.com/apache/iceberg/pull/12756#issuecomment-2888655090 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Build and test hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] closed pull request #12681: Build and test hive-metastore with Hive 3 and Hive 4 URL: https://github.com/apache/iceberg/pull/12681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Build and test hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] commented on PR #12681: URL: https://github.com/apache/iceberg/pull/12681#issuecomment-2888655066 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core: HadoopCatalog root level warehouse path bug: missing slash [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] commented on PR #12233: URL: https://github.com/apache/iceberg/pull/12233#issuecomment-2888655051 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Make converting external avro record schema to iceberg schema startin… [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] closed pull request #12756: Core: Make converting external avro record schema to iceberg schema startin… URL: https://github.com/apache/iceberg/pull/12756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Iceberg time type fix [iceberg]

2025-05-17 Thread via GitHub
github-actions[bot] commented on PR #12725: URL: https://github.com/apache/iceberg/pull/12725#issuecomment-2888655079 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]

2025-05-17 Thread via GitHub
kevinjqliu commented on PR #1345: URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2888639823 I also have the changes for `CHANGELOG.md` and `DEPENDENCIES.rust.tsv` queued up. Should I include those in this PR or a followup PR? -- This is an automated message from the A

Re: [PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]

2025-05-17 Thread via GitHub
kevinjqliu commented on PR #1345: URL: https://github.com/apache/iceberg-rust/pull/1345#issuecomment-2888635608 One question, should we remove this function as part of the 0.5.0 release or perhaps change it to `since = "0.5.0"` https://github.com/apache/iceberg-rust/blame/cfe2a980b27

[PR] Bump iceberg-rust version to 0.5.0 [iceberg-rust]

2025-05-17 Thread via GitHub
kevinjqliu opened a new pull request, #1345: URL: https://github.com/apache/iceberg-rust/pull/1345 ## Which issue does this PR close? - Closes #1325. ## What changes are included in this PR? ## Are these changes tested? -- This is an automated m

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-17 Thread via GitHub
dentiny commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094235270 ## crates/iceberg/src/transaction/mod.rs: ## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } +/// Add snapshot summary properties. +

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-17 Thread via GitHub
dentiny commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094235270 ## crates/iceberg/src/transaction/mod.rs: ## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } +/// Add snapshot summary properties. +

Re: [PR] feat: `validate_deleted_data_files` [iceberg-python]

2025-05-17 Thread via GitHub
jayceslesar commented on PR #1938: URL: https://github.com/apache/iceberg-python/pull/1938#issuecomment-2888612040 @sungwy @Fokko thank you for the review! Learned a bunch and hopefully I can get the other 3 sub tasks in https://github.com/apache/iceberg-python/issues/819 along quickly! -

Re: [I] Support validate and related logic in Snapshot [iceberg-rust]

2025-05-17 Thread via GitHub
jonathanc-n commented on issue #1344: URL: https://github.com/apache/iceberg-rust/issues/1344#issuecomment-2888609361 Yes those can be completed separately, I will try to get residual evaluator done (a bit difficult since the schema + filters in rust are a bit different) -- This is an aut

Re: [PR] feat: Introduce snapshot summary properties [iceberg-rust]

2025-05-17 Thread via GitHub
dentiny commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094221603 ## crates/iceberg/src/transaction/mod.rs: ## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } +/// Add snapshot summary properties. +

[PR] Build: Bump flask-cors from 5.0.1 to 6.0.0 [iceberg-python]

2025-05-17 Thread via GitHub
dependabot[bot] opened a new pull request, #2012: URL: https://github.com/apache/iceberg-python/pull/2012 Bumps [flask-cors](https://github.com/corydolphin/flask-cors) from 5.0.1 to 6.0.0. Release notes Sourced from https://github.com/corydolphin/flask-cors/releases";>flask-cors's

Re: [I] Allow to pass botocore session to REST Catalog (S3 Tables) like Glue Catalog does [iceberg-python]

2025-05-17 Thread via GitHub
potatochipcoconut commented on issue #2008: URL: https://github.com/apache/iceberg-python/issues/2008#issuecomment-2888552272 @rudolfix what's the implication of how it currently works? because I am seeing some weird iam errors when writing data in sometimes w/lambda, not sure if related.

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

2025-05-17 Thread via GitHub
wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2888536801 Hi @huaxingao, thank you for reviewing this! You are correct that the tests would pass with the original implementation, except for `testReadStreamWithCompositeReadLimit`, which would

Re: [PR] Added ExpireSnapshots Feature [iceberg-python]

2025-05-17 Thread via GitHub
ForeverAngry commented on PR #1880: URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2888535189 > @ForeverAngry Sorry for the late reply, it looks like that there is a test failing now 👀 I think this commit [9031f06](https://github.com/apache/iceberg-python/pull/1

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-17 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2094180958 ## pyiceberg/table/__init__.py: ## @@ -1023,6 +1024,15 @@ def inspect(self) -> InspectTable: """ return InspectTable(self) +@property

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-17 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2094180938 ## pyiceberg/table/inspect.py: ## @@ -665,10 +666,16 @@ def data_files(self, snapshot_id: Optional[int] = None) -> "pa.Table": def delete_files(self, s

Re: [PR] Expose Avro reader to PyIceberg [iceberg-rust]

2025-05-17 Thread via GitHub
kevinjqliu commented on code in PR #1328: URL: https://github.com/apache/iceberg-rust/pull/1328#discussion_r2094174778 ## bindings/python/src/manifest.rs: ## @@ -0,0 +1,420 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

Re: [PR] Add support for evolving a partition column [iceberg-rust]

2025-05-17 Thread via GitHub
kevinjqliu commented on code in PR #1334: URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2094170668 ## crates/iceberg/src/spec/values.rs: ## @@ -403,12 +403,26 @@ impl Datum { } } PrimitiveType::Int => PrimitiveLiter

Re: [PR] Kevinjqliu/1.9.1rc0 [iceberg-python]

2025-05-17 Thread via GitHub
kevinjqliu commented on PR #2011: URL: https://github.com/apache/iceberg-python/pull/2011#issuecomment-2888497878 oops this was suppose to be opened against my own fork -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Kevinjqliu/1.9.1rc0 [iceberg-python]

2025-05-17 Thread via GitHub
kevinjqliu closed pull request #2011: Kevinjqliu/1.9.1rc0 URL: https://github.com/apache/iceberg-python/pull/2011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Kevinjqliu/1.9.1rc0 [iceberg-python]

2025-05-17 Thread via GitHub
kevinjqliu opened a new pull request, #2011: URL: https://github.com/apache/iceberg-python/pull/2011 # Rationale for this change # Are these changes tested? # Are there any user-facing changes? -- This is an automated message from the Apache Gi

Re: [PR] Rewrite manifests [iceberg-python]

2025-05-17 Thread via GitHub
amitgilad3 commented on PR #1661: URL: https://github.com/apache/iceberg-python/pull/1661#issuecomment-2888434137 Hey @Fokko - just wanted to say thanks for reviewing (really appreciate it) . I fixed all your comments and added a test to test v1 -> v2 , hope all pass now. let me know

Re: [I] Add description of columns for entries metadata table [iceberg]

2025-05-17 Thread via GitHub
Brijeshthummar02 commented on issue #13076: URL: https://github.com/apache/iceberg/issues/13076#issuecomment-2888337417 @manuzhang what description should be there?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Fix list in docs [iceberg]

2025-05-17 Thread via GitHub
Brijeshthummar02 commented on issue #13075: URL: https://github.com/apache/iceberg/issues/13075#issuecomment-2888336825 @manuzhang may i? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] fix: correct `UUIDType` partition representation for `BucketTransform` [iceberg-python]

2025-05-17 Thread via GitHub
DinGo4DEV commented on PR #2003: URL: https://github.com/apache/iceberg-python/pull/2003#issuecomment-2888326597 They also noticed that kind of problem in (https://github.com/apache/iceberg/pull/13087) -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: correct `UUIDType` partition representation for `BucketTransform` [iceberg-python]

2025-05-17 Thread via GitHub
DinGo4DEV commented on PR #2003: URL: https://github.com/apache/iceberg-python/pull/2003#issuecomment-2888304797 @Fokko TBR, After running the test case, I found that the identity transform of uuid is not supported for writing, because the value is bytes. So I tried rewrite the Avro writer

[PR] fix: coerce UUID to String in readable_metrics to avoid ClassCastException in Spark [iceberg]

2025-05-17 Thread via GitHub
kadai0308 opened a new pull request, #13087: URL: https://github.com/apache/iceberg/pull/13087 Spark expects all StringType fields to be castable to CharSequence, but Iceberg's readable_metrics lower_bound/upper_bound may decode to java.util.UUID for UUID-typed columns. This causes a