dentiny commented on code in PR #1336: URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094221603
########## crates/iceberg/src/transaction/mod.rs: ########## @@ -128,6 +128,18 @@ impl<'a> Transaction<'a> { Ok(self) } + /// Add snapshot summary properties. + pub fn add_snapshot_summary_properties( Review Comment: > If I recall correctly the tested code such as prop-key would be under the more general metadata So you're suggesting me to put the metadata elsewhere, rather than snapshot summary? Sure let me double check and get back to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org