dentiny commented on issue #1303:
URL: https://github.com/apache/iceberg-rust/issues/1303#issuecomment-2869495842
> Interesting. I didn’t expect that we would need a type hint here. Let me
take a look.
I also find it weird, returning the explicit error type is the easiest fix I
could
dependabot[bot] opened a new pull request, #13029:
URL: https://github.com/apache/iceberg/pull/13029
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.6.12 to 9.6.13.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc
dependabot[bot] opened a new pull request, #13028:
URL: https://github.com/apache/iceberg/pull/13028
Bumps [io.netty:netty-buffer](https://github.com/netty/netty) from
4.2.0.Final to 4.2.1.Final.
Commits
https://github.com/netty/netty/commit/72d0cce1ac3b7006eb78d42eeb56855098cc
dependabot[bot] opened a new pull request, #13027:
URL: https://github.com/apache/iceberg/pull/13027
Bumps software.amazon.awssdk:bom from 2.31.35 to 2.31.40.
[
from 26.59.0 to 26.60.0.
Release notes
Sourced from https://github.com/googleapis/java-cloud-bo
kumarpritam863 commented on PR #12727:
URL: https://github.com/apache/iceberg/pull/12727#issuecomment-2869355214
Commenting for keeping the PR alive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kevinjqliu merged PR #1957:
URL: https://github.com/apache/iceberg-python/pull/1957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
huaxingao commented on code in PR #12771:
URL: https://github.com/apache/iceberg/pull/12771#discussion_r2083367857
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -401,6 +405,22 @@ public FileAppender build() throws IOException {
Preconditions.c
kevinjqliu commented on PR #424:
URL: https://github.com/apache/iceberg-go/pull/424#issuecomment-2869302773
Thanks for the contribution @lliangyu-lin!
I just tested this locally against pyiceberg's integration test's IRC.
```
go run ./cmd/iceberg --uri http://0.0.0.0:8181 create
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2869295350
> @ForeverAngry Could you see if you can get the linters/tests passing?
Thanks!
> @ForeverAngry Could you see if you can get the linters/tests passing?
Thanks!
JeonDaehong commented on PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#issuecomment-2869293937
It built successfully during local testing, but here it's showing a build
failure…T.T
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
github-actions[bot] commented on issue #1310:
URL:
https://github.com/apache/iceberg-python/issues/1310#issuecomment-2869269818
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity
github-actions[bot] commented on PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#issuecomment-2869268792
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #12727:
URL: https://github.com/apache/iceberg/pull/12727#issuecomment-2869268816
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#issuecomment-2869268776
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #12194: Core: Extended header support
for RESTClient implementations
URL: https://github.com/apache/iceberg/pull/12194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #12756:
URL: https://github.com/apache/iceberg/pull/12756#issuecomment-2869268825
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on issue #11512:
URL: https://github.com/apache/iceberg/issues/11512#issuecomment-2869268760
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on issue #4563:
URL: https://github.com/apache/iceberg/issues/4563#issuecomment-2869268688
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
huaxingao commented on code in PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#discussion_r2083359076
##
.github/workflows/jmh-benchmarks.yml:
##
@@ -28,8 +28,8 @@ on:
description: 'The branch name'
required: true
spark_version:
-des
amogh-jahagirdar commented on code in PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#discussion_r2083320831
##
.github/workflows/jmh-benchmarks.yml:
##
@@ -28,8 +28,8 @@ on:
description: 'The branch name'
required: true
spark_version:
-
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319399
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import S
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319496
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +85,10 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
amogh-jahagirdar commented on PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#issuecomment-2869217500
Thanks for understanding @tomtongue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319196
##
tests/expressions/test_literals.py:
##
@@ -760,7 +760,6 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None
simw opened a new issue, #1986:
URL: https://github.com/apache/iceberg-python/issues/1986
### Apache Iceberg version
0.9.0 (latest release)
### Please describe the bug 🐞
Preamble: using a local sqlite db:
```python
from pyiceberg.catalog import load_catalog
w
coderfender commented on PR #12901:
URL: https://github.com/apache/iceberg/pull/12901#issuecomment-2869184250
@nastra , It seems like `TestNessieIcebergClient` tests are either broken
(or I am missing an something here). Each of the tests is returning an empty
collection in this line wher
zeroshade merged PR #424:
URL: https://github.com/apache/iceberg-go/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #1983:
URL: https://github.com/apache/iceberg-python/pull/1983#issuecomment-2869148157
@kevinjqliu Good call, looking at the code, it seems like it will
automatically map it to INT32/INT64:
https://github.com/apache/arrow/blob/598938711a8376cbfdceaf5c77ab0fd5057e6c02/c
Fokko commented on code in PR #1983:
URL: https://github.com/apache/iceberg-python/pull/1983#discussion_r2083285244
##
pyiceberg/io/pyarrow.py:
##
@@ -636,7 +636,13 @@ def visit_fixed(self, fixed_type: FixedType) ->
pa.DataType:
return pa.binary(len(fixed_type))
Fokko commented on PR #1957:
URL: https://github.com/apache/iceberg-python/pull/1957#issuecomment-2869136312
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
jayceslesar commented on code in PR #1958:
URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2075436721
##
pyiceberg/table/__init__.py:
##
@@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame:
return pl.scan_iceberg(self)
+def delete_orph
jayceslesar commented on PR #1938:
URL: https://github.com/apache/iceberg-python/pull/1938#issuecomment-2869063829
@sungwy @Fokko thank you for reviews! Late responses here are my bad -- was
focusing on the orphaned files PR
--
This is an automated message from the Apache Git Service.
To
jayceslesar commented on code in PR #1938:
URL: https://github.com/apache/iceberg-python/pull/1938#discussion_r2083251839
##
pyiceberg/table/update/validate.py:
##
@@ -69,3 +75,74 @@ def validation_history(
raise ValidationException("No matching snapshot found.")
jayceslesar commented on code in PR #1938:
URL: https://github.com/apache/iceberg-python/pull/1938#discussion_r2083253070
##
pyiceberg/table/update/validate.py:
##
@@ -69,3 +75,74 @@ def validation_history(
raise ValidationException("No matching snapshot found.")
tomtongue commented on PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#issuecomment-2869035576
> @tomtongue Sorry, your changes in
https://github.com/apache/iceberg/pull/13007/files were removed when I reverted
my Spark 4.0 integration PR. I didn't include your changes in this
coderfender commented on code in PR #12824:
URL: https://github.com/apache/iceberg/pull/12824#discussion_r2083238830
##
core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java:
##
@@ -199,30 +214,48 @@ protected long defaultTargetFileSize() {
public FileR
huaxingao commented on PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#issuecomment-2869004899
@tomtongue Sorry, your changes in
https://github.com/apache/iceberg/pull/13007/files were removed when I reverted
my Spark 4.0 integration PR. I didn't include your changes in this PR
kevinjqliu merged PR #1985:
URL: https://github.com/apache/iceberg-python/pull/1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on PR #1985:
URL: https://github.com/apache/iceberg-python/pull/1985#issuecomment-2869003682
Thanks for the contribution @frankliee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wgtmac commented on code in PR #93:
URL: https://github.com/apache/iceberg-cpp/pull/93#discussion_r2083233139
##
src/iceberg/util/checked_cast_internal.h:
##
@@ -0,0 +1,61 @@
+/*
Review Comment:
I was using it for the visitor but not it is not required. Let me remove it
for
huaxingao commented on PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#issuecomment-2869002076
cc @amogh-jahagirdar @wypoon @pan3793 @manuzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Guosmilesmile commented on PR #13024:
URL: https://github.com/apache/iceberg/pull/13024#issuecomment-2868964122
@pvary Hi Peter, if you have time, please help review whether the approach
in this PR is appropriate.
Thank you very much !
--
This is an automated message from the Apache
Guosmilesmile opened a new pull request, #13024:
URL: https://github.com/apache/iceberg/pull/13024
Because the concrete implementations of `streamBuilder` are all inner
classes, such as `ExpireSnapshots.Builder` and `RewriteDataFiles.Builder`,
`streamBuilder.getClass().getSimpleName(
manuzhang closed pull request #13018: Build: Don't ignore changes to open-api/
in Spark CI
URL: https://github.com/apache/iceberg/pull/13018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
puchengy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2868943576
@advancedxy Thank you for your change and @gaborkaszab thank you for your
change on https://github.com/apache/iceberg/pull/12089. I wonder do you have
plan to further integrate this to
JeonDaehong commented on code in PR #13016:
URL: https://github.com/apache/iceberg/pull/13016#discussion_r2083201382
##
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##
@@ -122,13 +107,13 @@ public DataFile writeFile(StructLike partition,
List records)
JeonDaehong commented on code in PR #13016:
URL: https://github.com/apache/iceberg/pull/13016#discussion_r2083202385
##
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##
@@ -122,13 +107,13 @@ public DataFile writeFile(StructLike partition,
List records)
JeonDaehong commented on code in PR #13016:
URL: https://github.com/apache/iceberg/pull/13016#discussion_r2083201382
##
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##
@@ -122,13 +107,13 @@ public DataFile writeFile(StructLike partition,
List records)
pvary commented on PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2868826921
@ebyhr, @findepi: Do I remember correctly that you work on Trino?
We are debating of the api required by the engines for partition stats
calculation.
We will have an API, which calcu
sdd commented on issue #1305:
URL: https://github.com/apache/iceberg-rust/issues/1305#issuecomment-2868826522
Turns out this was not the cause of deadlock. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sdd closed issue #1305: Logically incorrect `await` statement could cause
deadlock at some point
URL: https://github.com/apache/iceberg-rust/issues/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sdd commented on PR #982:
URL: https://github.com/apache/iceberg-rust/pull/982#issuecomment-2868825403
I had a bug in here that was causing the tests to deadlock in the follow-up
PRs. I was missing a waker for my custom futures.That's been rectified now and
this PR plus the two follow-ups a
deniskuzZ commented on PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2868773112
> This is little different. Per partition or whole table. (Not based on the
snapshot)
If the partition spec is not provided, stats is computed for all the
partitions individually.
ajantha-bhat commented on PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2868722899
> Could you clarify the concern around keeping the API to trigger full
partition stats recompute? Clients have to rely on workarounds, even though
Iceberg internally supports this
zhjwpku commented on code in PR #94:
URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083097538
##
src/iceberg/util/visit_type.h:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. S
Xuanwo commented on code in PR #1154:
URL: https://github.com/apache/iceberg-rust/pull/1154#discussion_r2083093675
##
crates/iceberg/src/transaction/mod.rs:
##
@@ -127,12 +127,14 @@ impl<'a> Transaction<'a> {
}
/// Creates a fast append action.
-pub fn fast_appen
lidavidm commented on code in PR #94:
URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083072706
##
src/iceberg/util/visit_type.h:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
zhjwpku commented on code in PR #94:
URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2083062041
##
src/iceberg/util/visit_type.h:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. S
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083026964
##
src/iceberg/manifest_list.cc:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. Se
deniskuzZ commented on PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#issuecomment-2868659056
@ajantha-bhat, sorry, I meant 2 metadata files, still those might not be
small.
Could you please explain what is the concern in adding the API to do the
full re-compute, it would
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2082810322
##
src/iceberg/manifest_reader.h:
##
@@ -26,13 +26,15 @@
#include
#include "iceberg/file_reader.h"
+#include "iceberg/iceberg_export.h"
+#include "iceberg/type_fwd
Xuanwo commented on code in PR #:
URL: https://github.com/apache/iceberg-rust/pull/#discussion_r2083017097
##
crates/iceberg/src/spec/statistic_file.rs:
##
@@ -69,6 +72,137 @@ pub struct PartitionStatisticsFile {
pub file_size_in_bytes: i64,
}
+#[derive(Clone, De
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083021722
##
src/iceberg/manifest_entry.h:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. Se
Xuanwo merged PR #1295:
URL: https://github.com/apache/iceberg-rust/pull/1295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
dentiny commented on issue #1311:
URL: https://github.com/apache/iceberg-rust/issues/1311#issuecomment-2868622004
> Exposing `Blob` as is might be confusing since there are many different
`Blob` types in our context. I suggest renaming it to `PuffinBlob` for clarity.
Thanks for the qu
Xuanwo merged PR #1292:
URL: https://github.com/apache/iceberg-rust/pull/1292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
Xuanwo commented on issue #1303:
URL: https://github.com/apache/iceberg-rust/issues/1303#issuecomment-2868619402
Interesting. I didn’t expect that we would need a type hint here. Let me
take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083010628
##
src/iceberg/manifest_list.h:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
Xuanwo commented on issue #1311:
URL: https://github.com/apache/iceberg-rust/issues/1311#issuecomment-2868617964
Exposing `Blob` as is might be confusing since there are many different
`Blob` types in our context. I suggest renaming it to `PuffinBlob` for clarity.
Cc @liurenjie1024, @
Xuanwo merged PR #1301:
URL: https://github.com/apache/iceberg-rust/pull/1301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083003103
##
src/iceberg/manifest_entry.cc:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. S
zhjwpku commented on code in PR #91:
URL: https://github.com/apache/iceberg-cpp/pull/91#discussion_r2083002985
##
src/iceberg/manifest_entry.h:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. Se
dentiny commented on code in PR #1301:
URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2083000330
##
crates/iceberg/src/transaction/snapshot.rs:
##
@@ -172,6 +179,13 @@ impl<'a> SnapshotProduceAction<'a> {
// Write manifest file for added data files and re
lidavidm commented on code in PR #92:
URL: https://github.com/apache/iceberg-cpp/pull/92#discussion_r2082996873
##
test/config_test.cc:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NO
frankliee opened a new pull request, #1985:
URL: https://github.com/apache/iceberg-python/pull/1985
# Rationale for this change
Decouple setup and exec in integration tests for better flexibility.
For example, currently, `make test-integration` must be execut
lidavidm commented on code in PR #94:
URL: https://github.com/apache/iceberg-cpp/pull/94#discussion_r2082993421
##
src/iceberg/util/visit_type.h:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
Xuanwo merged PR #1310:
URL: https://github.com/apache/iceberg-rust/pull/1310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
Xuanwo commented on code in PR #1301:
URL: https://github.com/apache/iceberg-rust/pull/1301#discussion_r2082993259
##
crates/iceberg/src/transaction/snapshot.rs:
##
@@ -172,6 +179,13 @@ impl<'a> SnapshotProduceAction<'a> {
// Write manifest file for added data files and ret
80 matches
Mail list logo
