Fokko commented on code in PR #1983:
URL: https://github.com/apache/iceberg-python/pull/1983#discussion_r2083285244
##########
pyiceberg/io/pyarrow.py:
##########
@@ -636,7 +636,13 @@ def visit_fixed(self, fixed_type: FixedType) ->
pa.DataType:
return pa.binary(len(fixed_type))
def visit_decimal(self, decimal_type: DecimalType) -> pa.DataType:
- return pa.decimal128(decimal_type.precision, decimal_type.scale)
+ return (
+ pa.decimal32(decimal_type.precision, decimal_type.scale)
+ if decimal_type.precision <= 9
+ else pa.decimal64(decimal_type.precision, decimal_type.scale)
+ if decimal_type.precision <= 18
+ else pa.decimal128(decimal_type.precision, decimal_type.scale)
Review Comment:
Thanks for checking. This inspired me to change the code to throw on
precision >38.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
