JeonDaehong commented on code in PR #13016:
URL: https://github.com/apache/iceberg/pull/13016#discussion_r2083201382
##########
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##########
@@ -122,13 +107,13 @@ public DataFile writeFile(StructLike partition,
List<Record> records) throws IOE
}
private static DataFile appendToLocalFile(
- Table table,
- File file,
- FileFormat format,
- StructLike partition,
- List<Record> records,
- Configuration conf)
- throws IOException {
+ Table table,
Review Comment:
> (Sorry for jumping in) Thanks for working this @JeonDaehong, I believe
it's good to run the spotlessApply first and send the commit for the better
visibility of your changes.
I have revised the PR by incorporating your feedback.
Thank you for your valuable advice!
https://github.com/apache/iceberg/pull/13021
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java:
##########
@@ -421,8 +421,10 @@ void testOperatorsUidNameWitUidSuffix() throws Exception {
@TestTemplate
void testErrorOnNullForRequiredField() throws Exception {
- Assume.assumeFalse(
- "ORC file format supports null values even for required fields.",
format == FileFormat.ORC);
+
+ assumeThat(format)
+ .as("ORC file format supports null values even for required
fields.")
+ .isEqualTo(FileFormat.ORC);
Review Comment:
> If you have a chance, could you apply this when you send the commit to
this PR along with running the spotlessApply?
I have revised the PR by incorporating your feedback.
Thank you for your valuable advice!
#13021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
