Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo closed issue #482: Investigation about tracing, logging, and metrics support. URL: https://github.com/apache/iceberg-rust/issues/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] refactor: Use tracing to replace log [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo merged PR #1183: URL: https://github.com/apache/iceberg-rust/pull/1183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Doc: Remove Hive 2.x/3.x related docs in hive.md [iceberg]

2025-04-08 Thread via GitHub
jackylee-ch commented on PR #12700: URL: https://github.com/apache/iceberg/pull/12700#issuecomment-2788342338 @manuzhang @pvary @deniskuzZ PTAL. Can we merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Data: Handle case where partition location is missing for `TableMigrationUtil` [iceberg]

2025-04-08 Thread via GitHub
jshmchenxi commented on PR #12212: URL: https://github.com/apache/iceberg/pull/12212#issuecomment-2788334466 @Fokko Hi! When you get a chance, could you help review this PR? It’s been open for a little while. Appreciate it! -- This is an automated message from the Apache Git Service. To r

Re: [I] Iceberg sink gives error: Invalid method name: 'get_table` [iceberg]

2025-04-08 Thread via GitHub
Souldiv commented on issue #12719: URL: https://github.com/apache/iceberg/issues/12719#issuecomment-2788275479 The issue was that iceberg-kafka-connect-runtime that is built with iceberg 1.8.1 relies on hive 2.3.9 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] ci: Use taplo to replace cargo-sort [iceberg-rust]

2025-04-08 Thread via GitHub
liurenjie1024 merged PR #1186: URL: https://github.com/apache/iceberg-rust/pull/1186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [D] Glue catalog updating [iceberg-rust]

2025-04-08 Thread via GitHub
GitHub user liurenjie1024 added a comment to the discussion: Glue catalog updating Yes, table update requires transaction api, and the community is working on it. GitHub link: https://github.com/apache/iceberg-rust/discussions/1168#discussioncomment-12772276 This is an automatically sen

[PR] ci: Use taplo to replace cargo-sort [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo opened a new pull request, #1186: URL: https://github.com/apache/iceberg-rust/pull/1186 ## Which issue does this PR close? None ## What changes are included in this PR? Use taplo to replace cargo-sort entirely. taplo covers all features that cargo-sort hav

Re: [I] Iceberg sink gives error: Invalid method name: 'get_table` [iceberg]

2025-04-08 Thread via GitHub
Souldiv closed issue #12719: Iceberg sink gives error: Invalid method name: 'get_table` URL: https://github.com/apache/iceberg/issues/12719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] fix(table): for add partition spec constant [iceberg-go]

2025-04-08 Thread via GitHub
zeroshade commented on PR #382: URL: https://github.com/apache/iceberg-go/pull/382#issuecomment-2788262466 My apologies, I've been at iceberg summit today. I meant to merge after the CI completed and forgot. Gonna merge now. Thanks!! -- This is an automated message from the Apache Git Ser

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034347253 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034281506 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] fix(table): for add partition spec constant [iceberg-go]

2025-04-08 Thread via GitHub
zeroshade merged PR #382: URL: https://github.com/apache/iceberg-go/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034353097 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] refactor: Bump OpenDAL to 0.53 [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo merged PR #1182: URL: https://github.com/apache/iceberg-rust/pull/1182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] feat(io): add OSS storage implementation and update dependencies [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo commented on PR #1153: URL: https://github.com/apache/iceberg-rust/pull/1153#issuecomment-2788231268 Hi, @divinerapier would you like to merge with main to fix the CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fix(table): for add partition spec constant [iceberg-go]

2025-04-08 Thread via GitHub
mimikwang commented on PR #382: URL: https://github.com/apache/iceberg-go/pull/382#issuecomment-2788219501 @zeroshade - not meant to rush - but just want to make sure that there's nothing else on my end to do for this PR! -- This is an automated message from the Apache Git Service. To res

Re: [PR] refactor: Bump MSRV to 1.84 for preparing next release [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo merged PR #1185: URL: https://github.com/apache/iceberg-rust/pull/1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034394476 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034393074 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034383670 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

[PR] refactor: Bump MSRV to 1.84 for preparing next release [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo opened a new pull request, #1185: URL: https://github.com/apache/iceberg-rust/pull/1185 ## Which issue does this PR close? None ## What changes are included in this PR? Bump MSRV to 1.84 to get our community ready for the next release. We need this P

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2034367975 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034371723 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

[I] remove unconditional dependency on tokio features [iceberg-rust]

2025-04-08 Thread via GitHub
xxchan opened a new issue, #1184: URL: https://github.com/apache/iceberg-rust/issues/1184 This is the dependency tree of tokio: `cargo tree -i tokio -p iceberg -e features` ``` tokio v1.44.2 └── hyper-util v0.1.10 ├── hyper-util feature "client"

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034375471 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034372823 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] Update hive-quickstart.md [iceberg]

2025-04-08 Thread via GitHub
ebyhr commented on code in PR #12746: URL: https://github.com/apache/iceberg/pull/12746#discussion_r2034369904 ## site/docs/hive-quickstart.md: ## @@ -39,7 +39,7 @@ Set the version variable. export HIVE_VERSION=4.0.0 ``` -Start the container, using the option `--platform lin

Re: [PR] Update hive-quickstart.md [iceberg]

2025-04-08 Thread via GitHub
ebyhr commented on code in PR #12746: URL: https://github.com/apache/iceberg/pull/12746#discussion_r2034369904 ## site/docs/hive-quickstart.md: ## @@ -39,7 +39,7 @@ Set the version variable. export HIVE_VERSION=4.0.0 ``` -Start the container, using the option `--platform lin

Re: [PR] Update hive-quickstart.md [iceberg]

2025-04-08 Thread via GitHub
manuzhang commented on code in PR #12746: URL: https://github.com/apache/iceberg/pull/12746#discussion_r2034366543 ## site/docs/hive-quickstart.md: ## @@ -39,7 +39,7 @@ Set the version variable. export HIVE_VERSION=4.0.0 ``` -Start the container, using the option `--platform

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034363891 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
gty404 commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034361080 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] chore: update denpendencies, fix ci [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo closed pull request #1106: chore: update denpendencies, fix ci URL: https://github.com/apache/iceberg-rust/pull/1106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Change tokio feature [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo merged PR #1173: URL: https://github.com/apache/iceberg-rust/pull/1173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] chore: update denpendencies, fix ci [iceberg-rust]

2025-04-08 Thread via GitHub
Xuanwo commented on PR #1106: URL: https://github.com/apache/iceberg-rust/pull/1106#issuecomment-2788152436 Hi, thanks @Lordworms for your work on this. The issue we aimed to resolve has been fixed, so let's go ahead and close it. Feel free to open a new issue if you believe there are still

Re: [PR] Change tokio feature [iceberg-rust]

2025-04-08 Thread via GitHub
liurenjie1024 commented on PR #1173: URL: https://github.com/apache/iceberg-rust/pull/1173#issuecomment-2788141141 > To summarize, currently we already enable tokio runtime features unconditionally, even when feature `tokio` is not enabled, since other dependencies enabled it. >

Re: [I] Arrow uint32/64 support [iceberg-rust]

2025-04-08 Thread via GitHub
liurenjie1024 commented on issue #1164: URL: https://github.com/apache/iceberg-rust/issues/1164#issuecomment-2788133971 > Is there a reason we do not support unsigned integers? [The spec](https://iceberg.apache.org/spec/#schemas-and-data-types) defined data type supported. -- This

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034342585 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [I] Flaky test `TestSerializedMetadata > testEmptyVariantMetadata()` [iceberg]

2025-04-08 Thread via GitHub
coderfender commented on issue #12676: URL: https://github.com/apache/iceberg/issues/12676#issuecomment-278799 @Shweta-281 Are you still working on this ? let me know if you need any help -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-04-08 Thread via GitHub
liziyan-lzy commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2034235576 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java: ## @@ -372,7 +413,7 @@ private static void listDirRecursivel

Re: [PR] Alternative implementation for building and testing hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-08 Thread via GitHub
wypoon commented on code in PR #12721: URL: https://github.com/apache/iceberg/pull/12721#discussion_r2034029619 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java: ## @@ -186,9 +189,9 @@ public void stop() throws Exception { if (executorService !

Re: [PR] Build and test hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-08 Thread via GitHub
wypoon commented on PR #12681: URL: https://github.com/apache/iceberg/pull/12681#issuecomment-2787975659 @manuzhang thanks for your feedback. @pvary was very keen to try to keep a single code base if possible. Please take a look at https://github.com/apache/iceberg/pull/12721. After some

Re: [PR] SPARK: Remove dependency on hadoop's filesystem class from remove orphan files [iceberg]

2025-04-08 Thread via GitHub
liziyan-lzy commented on code in PR #12254: URL: https://github.com/apache/iceberg/pull/12254#discussion_r2034234788 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java: ## @@ -335,7 +344,39 @@ private Dataset listedFileDS() {

Re: [I] Provide option to specify user defined schema while reading from iceberg table [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #11217: URL: https://github.com/apache/iceberg/issues/11217#issuecomment-2787919181 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Move Writer classes from kafka-connect to core [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] closed issue #11207: Move Writer classes from kafka-connect to core URL: https://github.com/apache/iceberg/issues/11207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Table has more than one bucket keys, but "show create table xxx" only displays one [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #11090: URL: https://github.com/apache/iceberg/issues/11090#issuecomment-2787919093 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Table Not Found While reading IcebergTable from Spark SQL [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #11297: URL: https://github.com/apache/iceberg/issues/11297#issuecomment-2787919242 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Why does executing a sql "desc tableA" in hive command line report a error on a iceberg table with decimal(2,2) field type [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #11211: URL: https://github.com/apache/iceberg/issues/11211#issuecomment-2787919155 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Why does executing a sql "desc tableA" in hive command line report a error on a iceberg table with decimal(2,2) field type [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] closed issue #11211: Why does executing a sql "desc tableA" in hive command line report a error on a iceberg table with decimal(2,2) field type URL: https://github.com/apache/iceberg/issues/11211 -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] Table has more than one bucket keys, but "show create table xxx" only displays one [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] closed issue #11090: Table has more than one bucket keys, but "show create table xxx" only displays one URL: https://github.com/apache/iceberg/issues/11090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Flink SQL with Iceberg snapshots doesn't react if table has upsert [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #9948: URL: https://github.com/apache/iceberg/issues/9948#issuecomment-2787919014 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Provide option to specify user defined schema while reading from iceberg table [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] closed issue #11217: Provide option to specify user defined schema while reading from iceberg table URL: https://github.com/apache/iceberg/issues/11217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] Move Writer classes from kafka-connect to core [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] commented on issue #11207: URL: https://github.com/apache/iceberg/issues/11207#issuecomment-2787919126 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Flink SQL with Iceberg snapshots doesn't react if table has upsert [iceberg]

2025-04-08 Thread via GitHub
github-actions[bot] closed issue #9948: Flink SQL with Iceberg snapshots doesn't react if table has upsert URL: https://github.com/apache/iceberg/issues/9948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] Proposal to Introduce Trash Option for Hadoop Data Deletion to Mitigate NameNode Load [iceberg]

2025-04-08 Thread via GitHub
coderfender commented on issue #12560: URL: https://github.com/apache/iceberg/issues/12560#issuecomment-2787917775 @Sunwoo-Shin , Could you please clarify if this is different from `DROP TABLE PURGE` or am I missing something here ? -- This is an automated message from the Apache Git Ser

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034179840 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
lidavidm commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2034178885 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] Alternative implementation for building and testing hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-08 Thread via GitHub
wypoon commented on code in PR #12721: URL: https://github.com/apache/iceberg/pull/12721#discussion_r2034163141 ## hive3-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786677593 And now: ```sh PYTHONPATH=".:$PYTHONPATH" make test poetry run pytest tests/ -m "(unmarked or parametrize) and not integration"

Re: [PR] Build: Bump mkdocstrings-python from 1.16.8 to 1.16.10 [iceberg-python]

2025-04-08 Thread via GitHub
Fokko merged PR #1893: URL: https://github.com/apache/iceberg-python/pull/1893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[I] Patch release request CVE-2025-30065 [iceberg]

2025-04-08 Thread via GitHub
ted-jenks opened a new issue, #12749: URL: https://github.com/apache/iceberg/issues/12749 Hello, CVE-2025-30065 is pretty hairy. It is fixed on main and we were hoping we could get a patch release to cover it. Thanks! -- This is an automated message from the Apache Git Serv

Re: [PR] feat: Add `refresh` to get get updated `TableMetadata` [iceberg-rust]

2025-04-08 Thread via GitHub
jonathanc-n commented on PR #1154: URL: https://github.com/apache/iceberg-rust/pull/1154#issuecomment-2787625768 Is there an easy way to be able to create dummy catalog instances and pass them into new table instances for testing? -- This is an automated message from the Apache Git Servic

Re: [PR] feat: sort order [iceberg-cpp]

2025-04-08 Thread via GitHub
Fokko commented on PR #59: URL: https://github.com/apache/iceberg-cpp/pull/59#issuecomment-2786670179 Thanks @zhjwpku for working on this, and thanks @wgtmac, @lidavidm and @gty404 for the reviews 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Change tokio feature [iceberg-rust]

2025-04-08 Thread via GitHub
xxchan commented on PR #1173: URL: https://github.com/apache/iceberg-rust/pull/1173#issuecomment-2786265611 This is the dependency tree of tokio: `cargo tree -i tokio -p iceberg -e features` ``` tokio v1.44.2 └── hyper-util v0.1.10 ├── hyper-util feature "client"

Re: [PR] Alternative implementation for building and testing hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-08 Thread via GitHub
wypoon commented on code in PR #12721: URL: https://github.com/apache/iceberg/pull/12721#discussion_r2034029619 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java: ## @@ -186,9 +189,9 @@ public void stop() throws Exception { if (executorService !

Re: [PR] Build: Bump griffe from 1.7.1 to 1.7.2 [iceberg-python]

2025-04-08 Thread via GitHub
Fokko merged PR #1894: URL: https://github.com/apache/iceberg-python/pull/1894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [I] Arrow uint32/64 support [iceberg-rust]

2025-04-08 Thread via GitHub
jonathanc-n commented on issue #1164: URL: https://github.com/apache/iceberg-rust/issues/1164#issuecomment-2787628399 Is there a reason we do not support unsigned integers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Build: Bump mkdocs-section-index from 0.3.9 to 0.3.10 [iceberg-python]

2025-04-08 Thread via GitHub
Fokko merged PR #1895: URL: https://github.com/apache/iceberg-python/pull/1895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[PR] Core: use ALL_VERSIONS constant in TestBase [iceberg]

2025-04-08 Thread via GitHub
sullis opened a new pull request, #12748: URL: https://github.com/apache/iceberg/pull/12748 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Alternative implementation for building and testing hive-metastore with Hive 3 and Hive 4 [iceberg]

2025-04-08 Thread via GitHub
wypoon commented on code in PR #12721: URL: https://github.com/apache/iceberg/pull/12721#discussion_r2033957073 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java: ## @@ -186,9 +189,9 @@ public void stop() throws Exception { if (executorService !

Re: [PR] CI: Use Java 1.9.0-SNAPSHOT for testing [iceberg-python]

2025-04-08 Thread via GitHub
Fokko commented on PR #1899: URL: https://github.com/apache/iceberg-python/pull/1899#issuecomment-2786577711 Thanks @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [D] Glue catalog updating [iceberg-rust]

2025-04-08 Thread via GitHub
GitHub user hugokitano added a comment to the discussion: Glue catalog updating thank you. is it on the roundmap? GitHub link: https://github.com/apache/iceberg-rust/discussions/1168#discussioncomment-12769036 This is an automatically sent email for issues@iceberg.apache.org. To unsubscr

[PR] Enable Glue RenameTable test [iceberg-go]

2025-04-08 Thread via GitHub
maninc opened a new pull request, #383: URL: https://github.com/apache/iceberg-go/pull/383 - Added support to stub S3 FileSystem read / write - Added [AWS Middleware Stubber](https://pkg.go.dev/github.com/awsdocs/aws-doc-sdk-examples/gov2/testtools) dependency to hooks into the AWS SDK

Re: [I] Snowflake Iceberg Partitioned data read issue [iceberg]

2025-04-08 Thread via GitHub
marystory commented on issue #9404: URL: https://github.com/apache/iceberg/issues/9404#issuecomment-2787220154 Does anyone have new information on this? I've also noticed that when using the Snowflake catalog, a flat data file structure is created in storage even when the table is cluste

Re: [PR] Fallback for upsert when arrow cannot compare source rows with target rows [iceberg-python]

2025-04-08 Thread via GitHub
koenvo commented on PR #1878: URL: https://github.com/apache/iceberg-python/pull/1878#issuecomment-2787164884 ### Poor man's benchmark This compares the performance of the original vs fallback `upsert` logic. The "With skips" case simulates situations where non-matching rows can b

Re: [PR] AWS: Fix DynamoDB and Glue integration test failures [iceberg]

2025-04-08 Thread via GitHub
lliangyu-lin commented on PR #12718: URL: https://github.com/apache/iceberg/pull/12718#issuecomment-2787153272 @danielcweeks @amogh-jahagirdar I made some updates based on the comments. Could you please help take a look? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] feat (catalog/rest): Add create view for rest catalog [iceberg-go]

2025-04-08 Thread via GitHub
zeroshade merged PR #376: URL: https://github.com/apache/iceberg-go/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033562580 ## src/iceberg/table_metadata.cc: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
raulcd commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033551181 ## src/iceberg/table_metadata.cc: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033538128 ## src/iceberg/table_metadata.cc: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
raulcd commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033510946 ## src/iceberg/table_metadata.cc: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033412007 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786613375 > @arnaudbriche That's no problem. Can you try: > > ```shell > make install > make test > ``` > > We use a `Makefile` to run the correct commands.

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033454281 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033388253 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Upgrades Flink Version to 1.19.2 and 1.20.1 [iceberg]

2025-04-08 Thread via GitHub
rodmeneses commented on code in PR #12745: URL: https://github.com/apache/iceberg/pull/12745#discussion_r2033421593 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java: ## @@ -706,51 +706,6 @@ public void testRecoveryFromSnapshotWithoutCom

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033411442 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033412940 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033413387 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033408747 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

[PR] Update hive-quickstart.md [iceberg]

2025-04-08 Thread via GitHub
mollonado opened a new pull request, #12746: URL: https://github.com/apache/iceberg/pull/12746 I believe you meant '--platform linux/arm64' for a Mac with an M-Series chip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033382448 ## src/iceberg/table_metadata.h: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: add table metadata definition [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #62: URL: https://github.com/apache/iceberg-cpp/pull/62#discussion_r2033381939 ## src/iceberg/table_metadata.h: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033378953 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033378026 ## src/iceberg/snapshot_ref.h: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033373246 ## src/iceberg/snapshot.cc: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Build: Bump moto from 5.1.1 to 5.1.3 [iceberg-python]

2025-04-08 Thread via GitHub
Fokko merged PR #1889: URL: https://github.com/apache/iceberg-python/pull/1889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] feat: transform function [iceberg-cpp]

2025-04-08 Thread via GitHub
wgtmac commented on code in PR #61: URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2033329587 ## src/iceberg/transform/transform_spec.h: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] add scan tests with null values [iceberg-python]

2025-04-08 Thread via GitHub
Fokko commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2033309802 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file input t

Re: [PR] feat: snapshot [iceberg-cpp]

2025-04-08 Thread via GitHub
zhjwpku commented on code in PR #60: URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2033357793 ## src/iceberg/snapshot.h: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

  1   2   >