liurenjie1024 commented on PR #1173: URL: https://github.com/apache/iceberg-rust/pull/1173#issuecomment-2788141141
> To summarize, currently we already enable tokio runtime features unconditionally, even when feature `tokio` is not enabled, since other dependencies enabled it. > > Therefore, I think the best way to proceed is: > > * In this PR, we just need to remove the "optional" for `tokio` to unblock [feat(puffin): Make Puffin APIs public #1165](https://github.com/apache/iceberg-rust/pull/1165). > * In a follow-up PR, we can gradually turn off unnecessary features of dependencies. I agree that we should eventually remove unnecessary tokio runtime dependency, but I don't think we should revert the change of `tokio/rt-multi-thread`, as this is the goal we want to achieve. Thinking about the final status, it should be what looks like in this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
