Re: [PR] mr:Fix issues 10639 [iceberg]

2024-07-25 Thread via GitHub
lurnagao-dahua commented on PR #10661: URL: https://github.com/apache/iceberg/pull/10661#issuecomment-2252091268 Hi @pvary thank you for the review.Do you think if it can be merged? Really appreciate it. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-07-25 Thread via GitHub
lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692587758 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Drop support for Java 8 [iceberg]

2024-07-25 Thread via GitHub
nastra commented on code in PR #10518: URL: https://github.com/apache/iceberg/pull/10518#discussion_r1692583839 ## core/src/main/java/org/apache/iceberg/StaticDataTask.java: ## @@ -127,7 +127,11 @@ DataFile metadataFile() { return metadataFile; } - /** @return the tab

Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-07-25 Thread via GitHub
ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692581100 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-07-25 Thread via GitHub
ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692578855 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-07-25 Thread via GitHub
ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692578140 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Core: Limit ParallelIterable memory consumption by yielding in tasks [iceberg]

2024-07-25 Thread via GitHub
ajantha-bhat commented on PR #10787: URL: https://github.com/apache/iceberg/pull/10787#issuecomment-2252060038 I think first we need to conclude whether are we having 1.6.1 release just for this fix? (mailing list discussion can be a good place for this) If not, it is not worth back porti

Re: [I] How to create an iceberg table under a custom catalog instead of creating it under hive,using HiveCatalog [iceberg]

2024-07-25 Thread via GitHub
nastra commented on issue #10786: URL: https://github.com/apache/iceberg/issues/10786#issuecomment-2252058558 https://iceberg.apache.org/spark-quickstart/ has an example that uses Spark + REST catalog -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Support convert orc timestamptz [iceberg]

2024-07-25 Thread via GitHub
pvary commented on PR #9905: URL: https://github.com/apache/iceberg/pull/9905#issuecomment-2252026580 @deniskuzZ: How this is solved in Hive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692520767 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3826,151 @@ components: type: integer description: "List of equality field IDs" +De

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1688966381 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3818,176 @@ components: type: integer description: "List of equality field IDs" +Pr

Re: [PR] docs: installation of the new `iceberg_catalog_rest` added to the docs [iceberg-rust]

2024-07-25 Thread via GitHub
Xuanwo commented on PR #355: URL: https://github.com/apache/iceberg-rust/pull/355#issuecomment-2251947169 > Seems @nishant-sachdeva is not responding. To be honest I still prefer to use different section for adding different dependencies. Understood. > Or could we file other pr

Re: [I] javax.net.ssl.SSLException: Connection reset on S3 w/ S3FileIO and Apache HTTP client [iceberg]

2024-07-25 Thread via GitHub
linzhou-db commented on issue #10340: URL: https://github.com/apache/iceberg/issues/10340#issuecomment-2251941466 Also seeing SSLException when accessing pre-signed urls. ``` Caused by: javax.net.ssl.SSLException: Connection reset at sun.security.ssl.Alert.createSSLException(Ale

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692461358 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Requests

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692457387 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,113 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692457860 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Request

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692454111 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Requests

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692452864 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Request

Re: [PR] Remove support for catalog_name in table identifier string [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu commented on PR #963: URL: https://github.com/apache/iceberg-python/pull/963#issuecomment-2251904029 +1 to remove the catalog name as part of the table identifier. #964 is a good workaround to get into the 0.7.0 release. This PR is great as a long-term plan to deprecate the

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692448337 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692444140 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692436679 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [I] What is Table Identifier? [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu commented on issue #341: URL: https://github.com/apache/iceberg-python/issues/341#issuecomment-2251876060 Answering my own questions above. A TableIdentifier is in the form of (namespace, ..., database_name, table_name). `table_name` is the last element of the tuple. `data

Re: [I] What is Table Identifier? [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu closed issue #341: What is Table Identifier? URL: https://github.com/apache/iceberg-python/issues/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[I] Error configuration key in document [iceberg]

2024-07-25 Thread via GitHub
ideal opened a new issue, #10785: URL: https://github.com/apache/iceberg/issues/10785 ### Apache Iceberg version 1.5.2 ### Query engine Flink ### Please describe the bug 🐞 The document at https://iceberg.apache.org/docs/1.5.2/flink-connector/ says: SE

Re: [PR] docs: installation of the new `iceberg_catalog_rest` added to the docs [iceberg-rust]

2024-07-25 Thread via GitHub
liurenjie1024 commented on PR #355: URL: https://github.com/apache/iceberg-rust/pull/355#issuecomment-2251858669 > Hi, @liurenjie1024, this PR has been open for a while without any progress. I believe it's ready to be merged and we can continue to make improvements on it afterward. What do

Re: [I] Unable to create catalog with Hive catalog [iceberg]

2024-07-25 Thread via GitHub
ideal commented on issue #10772: URL: https://github.com/apache/iceberg/issues/10772#issuecomment-2251855046 The reason is that some jars (e.g. libthrift, libfb303) were missing under `lib` before I started the Flink standalone cluster, so I added jars and start sql-client.sh as `bin/sql-cl

Re: [I] Unable to create catalog with Hive catalog [iceberg]

2024-07-25 Thread via GitHub
ideal closed issue #10772: Unable to create catalog with Hive catalog URL: https://github.com/apache/iceberg/issues/10772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692413920 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an

Re: [I] Should be null_value_counts updated after adding a new column to the schema? [iceberg]

2024-07-25 Thread via GitHub
zhongyujiang commented on issue #10773: URL: https://github.com/apache/iceberg/issues/10773#issuecomment-2251844012 > Even if the stats are missing in previous manifests with the old schema, it seems theoretically possible in my head to assume that new columns which are not in that schema s

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692409107 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692405579 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] Docs: Make compatibility example consistent. [iceberg]

2024-07-25 Thread via GitHub
amogh-jahagirdar merged PR #10781: URL: https://github.com/apache/iceberg/pull/10781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
dimas-b commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692359926 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692322916 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692320660 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692309633 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692308989 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [I] Slowness when loading table from S3 [iceberg-python]

2024-07-25 Thread via GitHub
github-actions[bot] commented on issue #220: URL: https://github.com/apache/iceberg-python/issues/220#issuecomment-2251616092 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [PR] Remove duplicate calls [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #3208: URL: https://github.com/apache/iceberg/pull/3208#issuecomment-2251612532 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] No metrics from S3FileIO [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on issue #3205: URL: https://github.com/apache/iceberg/issues/3205#issuecomment-2251612468 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] CodeStyle: Single blank line around method in interface [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #3200: URL: https://github.com/apache/iceberg/pull/3200#issuecomment-2251612350 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Add one configuration to config the records num threshold when write pos-delete files [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2916: URL: https://github.com/apache/iceberg/pull/2916#issuecomment-2251611875 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Add one configuration to config the records num threshold when write pos-delete files [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2916: Add one configuration to config the records num threshold when write pos-delete files URL: https://github.com/apache/iceberg/pull/2916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Update the comment content of 'commit.retry.total-timeout-ms' [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2893: Update the comment content of 'commit.retry.total-timeout-ms' URL: https://github.com/apache/iceberg/pull/2893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Update the comment content of 'commit.retry.total-timeout-ms' [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2893: URL: https://github.com/apache/iceberg/pull/2893#issuecomment-2251611845 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [I] Support ZSTD compression codec for Avro files [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on issue #3206: URL: https://github.com/apache/iceberg/issues/3206#issuecomment-2251612498 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Write fails with class cast exception. [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on issue #3202: URL: https://github.com/apache/iceberg/issues/3202#issuecomment-2251612437 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] FLINK:use ROW_NUMBER() over() get error [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on issue #3201: URL: https://github.com/apache/iceberg/issues/3201#issuecomment-2251612401 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Enrich flink actions [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2862: Flink: Enrich flink actions URL: https://github.com/apache/iceberg/pull/2862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Flink: Auto compact file [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2867: URL: https://github.com/apache/iceberg/pull/2867#issuecomment-2251611788 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Flink: Enrich flink actions [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2862: URL: https://github.com/apache/iceberg/pull/2862#issuecomment-2251611761 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spark catalog: fixed hardcoded purge option in drop table action [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2854: URL: https://github.com/apache/iceberg/pull/2854#issuecomment-2251611699 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spark catalog: fixed hardcoded purge option in drop table action [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2854: Spark catalog: fixed hardcoded purge option in drop table action URL: https://github.com/apache/iceberg/pull/2854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Flink: Set equalityFieldColumns by identifierFieldIds default if user not set equalityFieldColumns [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2824: URL: https://github.com/apache/iceberg/pull/2824#issuecomment-2251611637 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Make SparkWriteBuilder and SparkWrite classes public [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2848: URL: https://github.com/apache/iceberg/pull/2848#issuecomment-2251611670 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Convert Type for update schema [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2818: URL: https://github.com/apache/iceberg/pull/2818#issuecomment-2251611608 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Convert Type for update schema [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2818: Core: Convert Type for update schema URL: https://github.com/apache/iceberg/pull/2818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Gradle build cache optimization [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2816: Gradle build cache optimization URL: https://github.com/apache/iceberg/pull/2816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Flink: Auto compact file [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2867: Flink: Auto compact file URL: https://github.com/apache/iceberg/pull/2867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] HiveMetastore: throw CommitedUnknowException when commit socket timeout. [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2860: URL: https://github.com/apache/iceberg/pull/2860#issuecomment-2251611731 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] HiveMetastore: throw CommitedUnknowException when commit socket timeout. [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2860: HiveMetastore: throw CommitedUnknowException when commit socket timeout. URL: https://github.com/apache/iceberg/pull/2860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Make SparkWriteBuilder and SparkWrite classes public [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2848: Make SparkWriteBuilder and SparkWrite classes public URL: https://github.com/apache/iceberg/pull/2848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Flink: Set equalityFieldColumns by identifierFieldIds default if user not set equalityFieldColumns [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #2824: Flink: Set equalityFieldColumns by identifierFieldIds default if user not set equalityFieldColumns URL: https://github.com/apache/iceberg/pull/2824 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Gradle build cache optimization [iceberg]

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2816: URL: https://github.com/apache/iceberg/pull/2816#issuecomment-2251611583 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
stevenzwu commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251610150 > By the way, it would be also possible to update `.asf.yml` for "force" at least one review. I proposed to use labels (using modules/paths), assign reviewers per labels, force at lea

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692287235 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692275151 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
dimas-b commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692272718 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692267725 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DRAFT: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251545950 > It looks good to me. Thanks ! > > By the way, it would be also possible to update `.asf.yml` for "force" at least one review. I proposed to use labels (using modules/paths),

Re: [PR] Add `IcebergAnalysisException` in iceberg-spark module [iceberg]

2024-07-25 Thread via GitHub
szehon-ho commented on PR #10766: URL: https://github.com/apache/iceberg/pull/10766#issuecomment-2251536703 I think im ok with it. I slightly prefer to not have this until 4.0, as it doesnt seem that necessary , but I think it will not hurt. Per https://github.com/apache/spark/commit/3e08

Re: [PR] Add `IcebergAnalysisException` in iceberg-spark module [iceberg]

2024-07-25 Thread via GitHub
szehon-ho commented on code in PR #10766: URL: https://github.com/apache/iceberg/pull/10766#discussion_r1692245109 ## spark/v3.5/spark/src/main/java/org/apache/spark/sql/catalyst/analysis/IcebergAnalysisException.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-25 Thread via GitHub
aokolnychyi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1692242550 ## spark/v3.5/build.gradle: ## @@ -59,6 +59,7 @@ project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") { implementation project(':ice

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-25 Thread via GitHub
aokolnychyi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1692240673 ## api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java: ## @@ -70,4 +70,10 @@ default RewritePositionDeleteFiles rewritePositionDeletes(Table table

[PR] Bump mkdocstrings from 0.25.1 to 0.25.2 [iceberg-python]

2024-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #968: URL: https://github.com/apache/iceberg-python/pull/968 Bumps [mkdocstrings](https://github.com/mkdocstrings/mkdocstrings) from 0.25.1 to 0.25.2. Release notes Sourced from https://github.com/mkdocstrings/mkdocstrings/releases";>mkdoc

[PR] Bump mkdocstrings-python from 1.10.5 to 1.10.7 [iceberg-python]

2024-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #967: URL: https://github.com/apache/iceberg-python/pull/967 Bumps [mkdocstrings-python](https://github.com/mkdocstrings/python) from 1.10.5 to 1.10.7. Release notes Sourced from https://github.com/mkdocstrings/python/releases";>mkdocstrin

Re: [PR] DRAFT: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jbonofre commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251479293 It looks good to me. Thanks ! By the way, it would be also possible to update `.asf.yml` for "force" at least one review. I proposed to use labels (using modules/paths), assign

Re: [PR] Drop support for Java 8 [iceberg]

2024-07-25 Thread via GitHub
findepi commented on PR #10518: URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2251441830 ( rebased to resolve conflicts with now-merged https://github.com/apache/iceberg/pull/10474, no other changes ) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692158506 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,100 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Core: Allow SnapshotProducer to skip uncommitted manifest cleanup after commit [iceberg]

2024-07-25 Thread via GitHub
grantatspothero commented on PR #10523: URL: https://github.com/apache/iceberg/pull/10523#issuecomment-2251418600 > A question: > > I'm not exactly sure how the "table metadata READ" and "manifest list READ" translate into calls to the underlying object store. Does "manifest list REA

Re: [I] flink restore failed with filenotfound [iceberg]

2024-07-25 Thread via GitHub
jad-grepr commented on issue #6066: URL: https://github.com/apache/iceberg/issues/6066#issuecomment-2251389448 Hi! We're running into this issue with Iceberg 1.5.2 and Flink 1.18.1. Seems like it's not yet fixed. We're happy to dedicate resources to fix it if we could get a pointer on resol

Re: [PR] Add `IcebergAnalysisException` in iceberg-spark module [iceberg]

2024-07-25 Thread via GitHub
szehon-ho commented on code in PR #10766: URL: https://github.com/apache/iceberg/pull/10766#discussion_r1692091564 ## spark/v3.5/spark/src/main/java/org/apache/spark/sql/catalyst/analysis/IcebergAnalysisException.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692075370 ## open-api/rest-catalog-open-api.yaml: ## @@ -537,6 +537,113 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/nam

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692069342 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3826,151 @@ components: type: integer description: "List of equality field IDs" +Del

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
amogh-jahagirdar commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692067555 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3826,151 @@ components: type: integer description: "List of equality field IDs"

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1690623146 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3818,176 @@ components: type: integer description: "List of equality field IDs" +Pre

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692062862 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3818,176 @@ components: type: integer description: "List of equality field IDs" +Pre

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692055068 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3818,176 @@ components: type: integer description: "List of equality field IDs" +Pre

Re: [PR] Support building with Java 21 [iceberg]

2024-07-25 Thread via GitHub
findepi commented on PR #10474: URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2251300646 thanks for the merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-07-25 Thread via GitHub
amogh-jahagirdar commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692046113 ## open-api/rest-catalog-open-api.yaml: ## @@ -3647,6 +3826,151 @@ components: type: integer description: "List of equality field IDs"

Re: [PR] Flink: backport PR #10331 and PR #10457 [iceberg]

2024-07-25 Thread via GitHub
stevenzwu commented on PR #10757: URL: https://github.com/apache/iceberg/pull/10757#issuecomment-2251276689 > @stevenzwu: Could you please help me understand why are the changes in flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SortKeySerializer.java are needed?

Re: [PR] Add jbonofre as collaborator on the project [iceberg]

2024-07-25 Thread via GitHub
jbonofre commented on PR #10782: URL: https://github.com/apache/iceberg/pull/10782#issuecomment-2251259063 Thank guys ! Much appreciated ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Support In and notIn operators in ParquetFilters.ConvertFilterToParquet [iceberg]

2024-07-25 Thread via GitHub
sririshindra commented on PR #10341: URL: https://github.com/apache/iceberg/pull/10341#issuecomment-2251238517 @aokolnychyi , @danielcweeks , @rdblue Could you please help in getting this reviewed if possible. Thanks -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add jbonofre as collaborator on the project [iceberg]

2024-07-25 Thread via GitHub
amogh-jahagirdar merged PR #10782: URL: https://github.com/apache/iceberg/pull/10782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Update last-updated-ms for DDL operations [iceberg-python]

2024-07-25 Thread via GitHub
soumya-ghosh commented on PR #956: URL: https://github.com/apache/iceberg-python/pull/956#issuecomment-2251212180 Thanks @kevinjqliu @HonahX for your review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add in-memory catalog implementation [iceberg-rust]

2024-07-25 Thread via GitHub
fqaiser94 commented on code in PR #475: URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691991685 ## crates/catalog/inmemory/src/catalog.rs: ## @@ -0,0 +1,1496 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] Add in-memory catalog implementation [iceberg-rust]

2024-07-25 Thread via GitHub
fqaiser94 commented on code in PR #475: URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691909039 ## crates/catalog/inmemory/src/catalog.rs: ## @@ -0,0 +1,1496 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] Update last-updated-ms for DDL operations [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu commented on PR #956: URL: https://github.com/apache/iceberg-python/pull/956#issuecomment-2251167083 @soumya-ghosh Merged! Thanks for the contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu commented on PR #947: URL: https://github.com/apache/iceberg-python/pull/947#issuecomment-2251166250 @jackye1995 Done, thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

  1   2   3   >