emkornfield commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251545950
> It looks good to me. Thanks ! > > By the way, it would be also possible to update `.asf.yml` for "force" at least one review. I proposed to use labels (using modules/paths), assign reviewers per labels, force at least one approved review per PR. > > We could update `.asf.yml` this way: > > ``` > ... > protected_branches: > main: > required_linear_history: true > required_status_checks: > strict: true > required_pull_request_reviews: > required_approving_review_count: 1 > dismiss_stale_reviews: true > required_conversation_resolution: true > ... > ``` > > Don't get me wrong: I don't propose to update `.asf.yml` in this PR. It's just a proposal I can bring to the team if it makes sense to you. I'm OK either way. A mechanism doesn't hurt here, but I think in terms of merging I think it is sufficient to operate on a model of trust (I think merging accidentally is pretty hard to do and pretty easy to reverse). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
