HonahX commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1632638743
##
pyiceberg/table/__init__.py:
##
@@ -3735,3 +3894,92 @@ def _determine_partitions(spec: PartitionSpec, schema:
Schema, arrow_table: pa.T
table_partitions: L
amogh-jahagirdar commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2157401562
@zhongyujiang I'm really sorry for the delayed review on my part. I think
this is an important improvement!
I will be taking a deeper look at the implementation this wee
chinmay-bhat commented on PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#issuecomment-2157332920
@Fokko @HonahX Thanks for the review!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Fokko merged PR #10466:
URL: https://github.com/apache/iceberg/pull/10466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
ZENOTME commented on issue #398:
URL: https://github.com/apache/iceberg-rust/issues/398#issuecomment-2157297853
cc @liurenjie1024 @sdd @Fokko @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ZENOTME opened a new issue, #398:
URL: https://github.com/apache/iceberg-rust/issues/398
Hi, I find that in some cases our reader interface seems duplicate for me.
E.g.
```
let table_scan = table
.scan()
.with_batch_size(Some(self.batch_size))
Fokko commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632590946
##
pyiceberg/table/snapshots.py:
##
@@ -228,6 +229,15 @@ def __eq__(self, other: Any) -> bool:
)
+@lru_cache
+def _manifests(io: FileIO, manifest_list:
Fokko commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632590946
##
pyiceberg/table/snapshots.py:
##
@@ -228,6 +229,15 @@ def __eq__(self, other: Any) -> bool:
)
+@lru_cache
+def _manifests(io: FileIO, manifest_list:
Fokko commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1632582253
##
pyiceberg/table/__init__.py:
##
@@ -1806,6 +1909,88 @@ def __enter__(self) -> U:
return self # type: ignore
+class ManageSnapshots(UpdateTableMetada
Fokko commented on code in PR #766:
URL: https://github.com/apache/iceberg-python/pull/766#discussion_r1632564486
##
mkdocs/docs/configuration.md:
##
@@ -228,19 +228,19 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
-s3.endpoint: http://localhost:9000
-
shanielh commented on PR #10470:
URL: https://github.com/apache/iceberg/pull/10470#issuecomment-2157189333
> weren't we thinking of fixing this by retrys in the broader level #10433 ?
Haven't seen #10433 since it wasn't connected to the issue :( , note that
this fix only fixes reading
github-actions[bot] commented on issue #198:
URL: https://github.com/apache/iceberg-python/issues/198#issuecomment-2156917748
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity oc
singhpk234 commented on PR #10470:
URL: https://github.com/apache/iceberg/pull/10470#issuecomment-2156798314
weren't we thinking of fixing this by retrys in the broader level
https://github.com/apache/iceberg/pull/10433 ?
--
This is an automated message from the Apache Git Service.
To re
syun64 commented on issue #791:
URL: https://github.com/apache/iceberg-python/issues/791#issuecomment-2156782618
> For Arrow, the `binary` cannot store more than 2GB in a single buffer, not
a single field. See [Arrow
docs](https://arrow.apache.org/docs/format/Columnar.html#variable-size-bin
mrbrahman commented on issue #10450:
URL: https://github.com/apache/iceberg/issues/10450#issuecomment-2156766739
Hi @RussellSpitzer I see you have responded on other SPJ tickets. Any ideas
on this one?
Thanks
--
This is an automated message from the Apache Git Service.
To respond
Fokko commented on PR #10404:
URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2156739145
@manuzhang Yes, I was out the last few days, thanks for pinging me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Fokko merged PR #10404:
URL: https://github.com/apache/iceberg/pull/10404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632371435
##
pyiceberg/table/snapshots.py:
##
@@ -247,12 +248,19 @@ def __str__(self) -> str:
result_str = f"{operation}id={self.snapshot_id}{parent_id}{schema_id}"
Fokko commented on issue #791:
URL: https://github.com/apache/iceberg-python/issues/791#issuecomment-2156736837
For Arrow, the `binary` cannot store more than 2GB in a single buffer, not a
single field. See [Arrow
docs](https://arrow.apache.org/docs/format/Columnar.html#variable-size-binary
Fokko commented on issue #791:
URL: https://github.com/apache/iceberg-python/issues/791#issuecomment-2156729320
This is interesting, why would Polars go with `large_binary` by default? See
https://github.com/apache/iceberg-python/pull/409
--
This is an automated message from the Apache Gi
nastra merged PR #10468:
URL: https://github.com/apache/iceberg/pull/10468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
chinmay-bhat commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632346194
##
pyiceberg/table/snapshots.py:
##
@@ -247,12 +248,19 @@ def __str__(self) -> str:
result_str = f"{operation}id={self.snapshot_id}{parent_id}{schema
manuzhang commented on PR #10404:
URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2156657246
@Fokko Do you plan to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632314152
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632313751
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632312924
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632312231
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bk-mz commented on code in PR #10459:
URL: https://github.com/apache/iceberg/pull/10459#discussion_r1632311125
##
core/src/test/resources/com/example/target/custom-metrics-reporter-1.0-SNAPSHOT.jar:
##
Review Comment:
how would you recommend to test that functionality?
bk-mz commented on code in PR #10459:
URL: https://github.com/apache/iceberg/pull/10459#discussion_r1632311017
##
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##
@@ -443,36 +443,42 @@ public static void configureHadoopConf(Object
maybeConfigurable, Object conf) {
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632310383
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632309640
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632309203
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632308446
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632305518
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/channel/CoordinatorTest.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Fou
mike-luabase commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-2156618883
Here's what I've been trying (sorry for long example, but thought the
context would help)
```python
iowa_sales_df =
pcsv.read_csv("/Users/mritchie712/blackbird/de
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632304257
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundat
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632302742
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632302742
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
mike-luabase commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-2156617018
@Fokko I installed from source, but I'm [hitting this
error](https://github.com/apache/iceberg-python/blob/94e8a9835995e3b61f07f0dfb48d8a22a1e1d1b0/pyiceberg/table/__init__.
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632300134
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##
@@ -80,7 +80,6 @@ public class IcebergSinkConfig extends AbstractCo
syun64 commented on PR #748:
URL: https://github.com/apache/iceberg-python/pull/748#issuecomment-2156615023
Congrats on your first PR @chinmay-bhat !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632299892
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632299563
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##
@@ -45,7 +45,7 @@ private EventTestUtil() {}
new S
syun64 commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1632294680
##
pyiceberg/table/__init__.py:
##
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properti
syun64 commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1632294680
##
pyiceberg/table/__init__.py:
##
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properti
syun64 commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1632294680
##
pyiceberg/table/__init__.py:
##
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properti
syun64 commented on PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2156607104
And let's update the name of this PR as well to reflect its current state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
syun64 commented on PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2156606644
Hi @chinmay-bhat this looks almost ready to merge - I responded to the
[thread
above](https://github.com/apache/iceberg-python/pull/728#discussion_r1632294680)
to continue the discus
syun64 commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1632294680
##
pyiceberg/table/__init__.py:
##
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properti
syun64 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1632276771
##
pyiceberg/table/__init__.py:
##
@@ -434,6 +456,9 @@ def overwrite(
if table_arrow_schema != df.schema:
df = df.cast(table_arrow_schema)
+
dependabot[bot] opened a new pull request, #397:
URL: https://github.com/apache/iceberg-rust/pull/397
Updates the requirements on [arrow-ord](https://github.com/apache/arrow-rs)
to permit the latest version.
Changelog
Sourced from https://github.com/apache/arrow-rs/blob/master/CHAN
dependabot[bot] opened a new pull request, #396:
URL: https://github.com/apache/iceberg-rust/pull/396
Updates the requirements on [parquet](https://github.com/apache/arrow-rs) to
permit the latest version.
Changelog
Sourced from https://github.com/apache/arrow-rs/blob/master/CHANGE
dependabot[bot] opened a new pull request, #395:
URL: https://github.com/apache/iceberg-rust/pull/395
Updates the requirements on
[arrow-arith](https://github.com/apache/arrow-rs) to permit the latest version.
Changelog
Sourced from https://github.com/apache/arrow-rs/blob/master/CH
dependabot[bot] opened a new pull request, #394:
URL: https://github.com/apache/iceberg-rust/pull/394
Updates the requirements on
[arrow-array](https://github.com/apache/arrow-rs) to permit the latest version.
Changelog
Sourced from https://github.com/apache/arrow-rs/blob/master/CH
dependabot[bot] opened a new pull request, #393:
URL: https://github.com/apache/iceberg-rust/pull/393
Updates the requirements on
[arrow-schema](https://github.com/apache/arrow-rs) to permit the latest version.
Changelog
Sourced from https://github.com/apache/arrow-rs/blob/master/C
AlexMercedCoder opened a new pull request, #10469:
URL: https://github.com/apache/iceberg/pull/10469
- Added 10 Dremio Blogs
- Added 3 Other Blogs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Fokko merged PR #801:
URL: https://github.com/apache/iceberg-python/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #802:
URL: https://github.com/apache/iceberg-python/pull/802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-2156424393
Hey everyone, the support for partioned writes are coming along pretty
nicely. We miss some of the transforms, such as the bucket transform. Most of
the stuff is on the main branc
Fokko commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632224368
##
pyiceberg/table/snapshots.py:
##
@@ -247,12 +248,19 @@ def __str__(self) -> str:
result_str = f"{operation}id={self.snapshot_id}{parent_id}{schema_id}"
dependabot[bot] commented on PR #96:
URL: https://github.com/apache/iceberg-go/pull/96#issuecomment-2156393402
Superseded by #99.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dependabot[bot] closed pull request #96: build(deps): bump
github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.82.0
URL: https://github.com/apache/iceberg-go/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dependabot[bot] opened a new pull request, #99:
URL: https://github.com/apache/iceberg-go/pull/99
Bumps
[github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2)
from 1.73.1 to 1.84.1.
Changelog
Sourced from https://github.com/aws/aws-sdk-go-v2/blob/service
dependabot[bot] closed pull request #95: build(deps): bump
github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.54.3
URL: https://github.com/apache/iceberg-go/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dependabot[bot] commented on PR #95:
URL: https://github.com/apache/iceberg-go/pull/95#issuecomment-2156392787
Superseded by #98.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dependabot[bot] opened a new pull request, #98:
URL: https://github.com/apache/iceberg-go/pull/98
Bumps
[github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2)
from 1.48.0 to 1.55.1.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/d872461174d9d665cc
66 matches
Mail list logo
