Fokko commented on code in PR #766:
URL: https://github.com/apache/iceberg-python/pull/766#discussion_r1632564486
##########
mkdocs/docs/configuration.md:
##########
@@ -228,19 +228,19 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
- s3.endpoint: http://localhost:9000
- s3.access-key-id: admin
- s3.secret-access-key: password
+ hive:
+ hive2-compatible: true
+ use-kerberos: true
```
-When using Hive 2.x, make sure to set the compatibility flag:
+<!-- markdown-link-check-disable -->
-```yaml
-catalog:
- default:
-...
- hive.hive2-compatible: true
-```
+| Key | Example | Description |
+| --------------------- | ------- | --------------------------------- |
+| hive.hive2-compatible | true | Using Hive 2.x compatibility mode |
+| hive.use-kerberos | true | Using authentication via Kerberos |
Review Comment:
How about adding authorization to the property? For those that are not
familiar with Kerberos, they know that it is related to auth
```suggestion
| hive.kerberos-authorization | true | Using authentication via
Kerberos |
```
##########
mkdocs/docs/configuration.md:
##########
@@ -228,19 +228,19 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
- s3.endpoint: http://localhost:9000
Review Comment:
How about leaving those properties as well?
##########
mkdocs/docs/configuration.md:
##########
@@ -228,19 +228,19 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
- s3.endpoint: http://localhost:9000
- s3.access-key-id: admin
- s3.secret-access-key: password
+ hive:
+ hive2-compatible: true
+ use-kerberos: true
```
-When using Hive 2.x, make sure to set the compatibility flag:
+<!-- markdown-link-check-disable -->
Review Comment:
I don't see any links, so I think we can remove this
##########
mkdocs/docs/configuration.md:
##########
@@ -228,19 +228,19 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
- s3.endpoint: http://localhost:9000
- s3.access-key-id: admin
- s3.secret-access-key: password
+ hive:
Review Comment:
Have you tested it with this additional layer? I know that it is equivalent
in yaml, but just want to double check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
