bk-mz commented on code in PR #10459:
URL: https://github.com/apache/iceberg/pull/10459#discussion_r1632311017


##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -443,36 +443,42 @@ public static void configureHadoopConf(Object 
maybeConfigurable, Object conf) {
   public static MetricsReporter loadMetricsReporter(Map<String, String> 
properties) {
     String impl = properties.get(CatalogProperties.METRICS_REPORTER_IMPL);
     if (impl == null) {
+      LOG.info(
+          "Custom metrics reporter is set, but the implementation is null. 
Defaulting to LoggingMetricsReporter");

Review Comment:
   removed and all other code suggestions applied



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to