Re: [PR] Described as Hive 4.0.0 [iceberg]

2024-05-12 Thread via GitHub
Fokko commented on PR #10325: URL: https://github.com/apache/iceberg/pull/10325#issuecomment-2106788271 Thanks @911432 for raising this PR, and thanks @SourabhBadhya for the review 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Described as Hive 4.0.0 [iceberg]

2024-05-12 Thread via GitHub
Fokko merged PR #10325: URL: https://github.com/apache/iceberg/pull/10325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[PR] Concurrent table scans [iceberg-rust]

2024-05-12 Thread via GitHub
sdd opened a new pull request, #373: URL: https://github.com/apache/iceberg-rust/pull/373 This is a bit of an experiment to see how things could look if we tried to: - process Manifest Lists and Manifest Files concurrently rather than sequentially - process the stream of file scan

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-12 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597956781 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -203,16 +353,39 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { literals: &FnvHas

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-12 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597952306 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -221,67 +394,213 @@ impl ManifestFilterVisitor<'_> { let pos = reference.accessor().position();

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-12 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597949796 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { reference: &Bou

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-12 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597946439 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { reference: &Bou

[PR] feat: Add equality delete writer [iceberg-rust]

2024-05-12 Thread via GitHub
Dysprosium0626 opened a new pull request, #372: URL: https://github.com/apache/iceberg-rust/pull/372 Close https://github.com/apache/iceberg-rust/issues/341 `EqualityDeleteWriter` refers tohttps://iceberg.apache.org/spec/#equality-delete-files This pr complete the implementation o

Re: [I] Add `table_exists` method to the Catalog [iceberg-python]

2024-05-12 Thread via GitHub
Fokko commented on issue #507: URL: https://github.com/apache/iceberg-python/issues/507#issuecomment-2106639907 Thanks @HonahX Let me close it for now 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Add `table_exists` method to the Catalog [iceberg-python]

2024-05-12 Thread via GitHub
Fokko closed issue #507: Add `table_exists` method to the Catalog URL: https://github.com/apache/iceberg-python/issues/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Remove pylintrc file [iceberg-python]

2024-05-12 Thread via GitHub
Fokko merged PR #724: URL: https://github.com/apache/iceberg-python/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [I] `pylintrc` still needed? [iceberg-python]

2024-05-12 Thread via GitHub
Fokko closed issue #666: `pylintrc` still needed? URL: https://github.com/apache/iceberg-python/issues/666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-12 Thread via GitHub
chinmay-bhat commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2106543381 @syun64 thank you for the review! In regards to testing, I see that the tests are all performed on the classes that are called by the APIs. None of the tests are directly on

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-12 Thread via GitHub
chinmay-bhat commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1597811301 ## pyiceberg/table/__init__.py: ## @@ -340,6 +340,34 @@ def set_properties(self, properties: Properties = EMPTY_DICT, **kwargs: Any) -> updates = pr

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.25.45 to 2.25.50 [iceberg]

2024-05-12 Thread via GitHub
Fokko commented on PR #10323: URL: https://github.com/apache/iceberg/pull/10323#issuecomment-2106534077 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Build: Bump parquet from 1.13.1 to 1.14.0 [iceberg]

2024-05-12 Thread via GitHub
dependabot[bot] commented on PR #10319: URL: https://github.com/apache/iceberg/pull/10319#issuecomment-2106533647 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

Re: [PR] Build: Bump parquet from 1.13.1 to 1.14.0 [iceberg]

2024-05-12 Thread via GitHub
Fokko closed pull request #10319: Build: Bump parquet from 1.13.1 to 1.14.0 URL: https://github.com/apache/iceberg/pull/10319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Build: Bump parquet from 1.13.1 to 1.14.0 [iceberg]

2024-05-12 Thread via GitHub
Fokko commented on PR #10319: URL: https://github.com/apache/iceberg/pull/10319#issuecomment-2106533624 I am closing this one in favor of https://github.com/apache/iceberg/pull/10209. This requires a new version of the shading plugin due to the JDK 17/21 specific files from Jackson. The sha

Re: [PR] Build: Bump org.testcontainers:testcontainers from 1.19.7 to 1.19.8 [iceberg]

2024-05-12 Thread via GitHub
Fokko merged PR #10322: URL: https://github.com/apache/iceberg/pull/10322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] chore(deps): Update opendal requirement from 0.45 to 0.46 [iceberg-rust]

2024-05-12 Thread via GitHub
dependabot[bot] commented on PR #370: URL: https://github.com/apache/iceberg-rust/pull/370#issuecomment-2106528548 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] chore(deps): Update opendal requirement from 0.45 to 0.46 [iceberg-rust]

2024-05-12 Thread via GitHub
Fokko closed pull request #370: chore(deps): Update opendal requirement from 0.45 to 0.46 URL: https://github.com/apache/iceberg-rust/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] AWS: Retain Glue Catalog column comment after updating Iceberg table [iceberg]

2024-05-12 Thread via GitHub
lawofcycles commented on PR #10276: URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2106471422 Hi @geruh would you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Enable exception suppression during namespace creation [iceberg-python]

2024-05-12 Thread via GitHub
syun64 commented on PR #725: URL: https://github.com/apache/iceberg-python/pull/725#issuecomment-2106452174 Hi @ndrluis thank you for working on this PR. What are your thoughts on aligning the implementation with the way [create_table_if_not_exists](https://github.com/apache/iceberg-p

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-12 Thread via GitHub
syun64 commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1597761797 ## pyiceberg/table/__init__.py: ## @@ -340,6 +340,34 @@ def set_properties(self, properties: Properties = EMPTY_DICT, **kwargs: Any) -> updates = properti

Re: [PR] Add bloom filter fpp config [iceberg]

2024-05-12 Thread via GitHub
huaxingao commented on code in PR #10149: URL: https://github.com/apache/iceberg/pull/10149#discussion_r1597722756 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetWriter.java: ## @@ -116,4 +128,27 @@ public void testCorrectness() throws IOExceptio

Re: [PR] refactor: Concurrent scan file planning [iceberg-rust]

2024-05-12 Thread via GitHub
sdd closed pull request #371: refactor: Concurrent scan file planning URL: https://github.com/apache/iceberg-rust/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] chore(deps): Update opendal requirement from 0.45 to 0.46 [iceberg-rust]

2024-05-12 Thread via GitHub
Xuanwo commented on PR #370: URL: https://github.com/apache/iceberg-rust/pull/370#issuecomment-2106321155 Should be fixed by https://github.com/apache/iceberg-rust/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Support creating tags [iceberg-python]

2024-05-12 Thread via GitHub
chinmay-bhat commented on issue #573: URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2106300079 @Fokko I saw this issue has been inactive for over a month, so I created a PR that might close the issue. Please review when possible :) -- This is an automated message f

[PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-12 Thread via GitHub
chinmay-bhat opened a new pull request, #728: URL: https://github.com/apache/iceberg-python/pull/728 Closes #573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] MinIO + Spark + hive metadata + iceberg format [iceberg]

2024-05-12 Thread via GitHub
vinh22032000 commented on issue #10222: URL: https://github.com/apache/iceberg/issues/10222#issuecomment-2106286472 Hi, have you found the solution yet? i have the same problem when using hive 4.0 with minio: pyspark.errors.exceptions.captured.AnalysisException: org.apache.hadoop.hiv

[PR] chore(deps): Update opendal requirement from 0.45 to 0.46 [iceberg-rust]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #370: URL: https://github.com/apache/iceberg-rust/pull/370 Updates the requirements on [opendal](https://github.com/apache/opendal) to permit the latest version. Release notes Sourced from https://github.com/apache/opendal/releases";>opend

[PR] chore(deps): Update datafusion requirement from 37.0.0 to 38.0.0 [iceberg-rust]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #369: URL: https://github.com/apache/iceberg-rust/pull/369 Updates the requirements on [datafusion](https://github.com/apache/datafusion) to permit the latest version. Changelog Sourced from https://github.com/apache/datafusion/blob/main/.

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.80.1 [iceberg-go]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #81: URL: https://github.com/apache/iceberg-go/pull/81 Bumps [github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2) from 1.73.1 to 1.80.1. Commits https://github.com/aws/aws-sdk-go-v2/commit/f95afa96016c325b

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.53.2 [iceberg-go]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #79: URL: https://github.com/apache/iceberg-go/pull/79 Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.48.0 to 1.53.2. Commits https://github.com/aws/aws-sdk-go-v2/commit/e7dfd72430a5095080

[PR] build(deps): bump github.com/pterm/pterm from 0.12.78 to 0.12.79 [iceberg-go]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/iceberg-go/pull/80 Bumps [github.com/pterm/pterm](https://github.com/pterm/pterm) from 0.12.78 to 0.12.79. Release notes Sourced from https://github.com/pterm/pterm/releases";>github.com/pterm/pterm's r

[PR] build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 [iceberg-go]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/iceberg-go/pull/78 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. Release notes Sourced from https://github.com/stretchr/testify/releases";>github.com/stret

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.12 to 1.17.13 [iceberg-go]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #77: URL: https://github.com/apache/iceberg-go/pull/77 Bumps [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) from 1.17.12 to 1.17.13. Commits https://github.com/aws/aws-sdk-go-v2/commit/0805b749042a533