Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

2024-04-22 Thread via GitHub
nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1575736834 ## core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java: ## @@ -48,6 +48,10 @@ protected OverwriteFiles self() { @Override protected String operation(

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

2024-04-22 Thread via GitHub
nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1575735207 ## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ## @@ -101,8 +101,8 @@ public class TestOverwrite extends TestBase { ImmutableMap.of(1,

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575706611 ## core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: ## @@ -140,7 +155,9 @@ public void write(T row) throws IOException { PathOffset previous = inser

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
chenjunjiedada commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575698957 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOE

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575700012 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOException

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575698414 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOException

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575676660 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/RowDataRewriter.java: ## @@ -84,7 +85,8 @@ public RowDataRewriter( format,

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575668667 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOException

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575666452 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOException

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575666321 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOException

[I] Implement the equality delete writer [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME opened a new issue, #341: URL: https://github.com/apache/iceberg-rust/issues/341 After we finish https://github.com/apache/iceberg-rust/pull/275, we can implement the equality delete writer based on this framework. There is a [rust implementation](https://github.com/icelake-i

Re: [I] Writer Design [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME commented on issue #34: URL: https://github.com/apache/iceberg-rust/issues/34#issuecomment-2071293794 We have finished the init writer framework! We can close this issue now and the next step is to implement more writers. I will create the issues and track them separately. -- Thi

Re: [I] Writer Design [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME closed issue #34: Writer Design URL: https://github.com/apache/iceberg-rust/issues/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

Re: [PR] init writer framework [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME commented on PR #135: URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-2071290816 close by https://github.com/apache/iceberg-rust/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] init writer framework [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME closed pull request #135: init writer framework URL: https://github.com/apache/iceberg-rust/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-22 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1575543923 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -112,4 +117,18 @@ Table autoCreateTable(String tabl

Re: [PR] Iceberg/Comet integration POC [iceberg]

2024-04-22 Thread via GitHub
aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1575419871 ## gradle.properties: ## @@ -20,8 +20,8 @@ systemProp.defaultFlinkVersions=1.18 systemProp.knownFlinkVersions=1.16,1.17,1.18 systemProp.defaultHiveVersions=2 sys

Re: [PR] Iceberg/Comet integration POC [iceberg]

2024-04-22 Thread via GitHub
aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1575416837 ## api/src/main/java/org/apache/iceberg/ReaderType.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] Iceberg/Comet integration POC [iceberg]

2024-04-22 Thread via GitHub
aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1575528604 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -196,6 +201,33 @@ private Duration toDuration(String time) { } } +

Re: [PR] Iceberg/Comet integration POC [iceberg]

2024-04-22 Thread via GitHub
aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1575528604 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -196,6 +201,33 @@ private Duration toDuration(String time) { } } +

Re: [I] does iceberg can run on k8s? [iceberg]

2024-04-22 Thread via GitHub
JunseoChoJJ commented on issue #10196: URL: https://github.com/apache/iceberg/issues/10196#issuecomment-2071196674 @nastra thank you can I ask you one more After they etl in spark using iceberg, they put data in to storage like s3, Gcs, minio. Can I put this data into our storage as well us

Re: [I] Create a docker based demo environment for user testing and community onboarding [iceberg]

2024-04-22 Thread via GitHub
github-actions[bot] commented on issue #2676: URL: https://github.com/apache/iceberg/issues/2676#issuecomment-2071156037 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] hive create table on existing iceberg table faild [iceberg]

2024-04-22 Thread via GitHub
github-actions[bot] commented on issue #2673: URL: https://github.com/apache/iceberg/issues/2673#issuecomment-2071156004 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] An error occurred when I started running Iceberg [iceberg]

2024-04-22 Thread via GitHub
github-actions[bot] commented on issue #2669: URL: https://github.com/apache/iceberg/issues/2669#issuecomment-2071155980 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1575469747 ## format/spec.md: ## @@ -128,12 +128,12 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tabl

[PR] Core: pushdown data_file.content when filter manifests in entries table [iceberg]

2024-04-22 Thread via GitHub
dramaticlly opened a new pull request, #10203: URL: https://github.com/apache/iceberg/pull/10203 Skip either data or delete manifest when reading entries table by filter on its `data_file.content` with ManifestContentEvaluator in entries metadata table. Can you take a look ? @szehon-h

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-22 Thread via GitHub
jzhuge commented on PR #8672: URL: https://github.com/apache/iceberg/pull/8672#issuecomment-2071094487 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Build: Bump deptry from 0.14.0 to 0.16.1 [iceberg-python]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #649: URL: https://github.com/apache/iceberg-python/pull/649 Bumps [deptry](https://github.com/fpgmaas/deptry) from 0.14.0 to 0.16.1. Release notes Sourced from https://github.com/fpgmaas/deptry/releases";>deptry's releases. 0.16.1

[PR] Build: Bump rich from 13.7.0 to 13.7.1 [iceberg-python]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #648: URL: https://github.com/apache/iceberg-python/pull/648 Bumps [rich](https://github.com/Textualize/rich) from 13.7.0 to 13.7.1. Release notes Sourced from https://github.com/Textualize/rich/releases";>rich's releases. v13.7.1

[PR] Build: Bump mkdocs-material from 9.5.10 to 9.5.18 [iceberg-python]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #646: URL: https://github.com/apache/iceberg-python/pull/646 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.10 to 9.5.18. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk

[PR] Build: Bump python-snappy from 0.6.1 to 0.7.1 [iceberg-python]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #647: URL: https://github.com/apache/iceberg-python/pull/647 Bumps [python-snappy](https://github.com/intake/python-snappy) from 0.6.1 to 0.7.1. Commits https://github.com/intake/python-snappy/commit/c6d2a7d9471feca2ecdd3d597255716936b

[PR] Build: Bump sqlalchemy from 2.0.27 to 2.0.29 [iceberg-python]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #645: URL: https://github.com/apache/iceberg-python/pull/645 Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 2.0.27 to 2.0.29. Release notes Sourced from https://github.com/sqlalchemy/sqlalchemy/releases";>sqlalchemy's r

Re: [PR] Flink: FlinkFileIO implementation [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10151: URL: https://github.com/apache/iceberg/pull/10151#discussion_r1575403714 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkFileIO.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on PR #10200: URL: https://github.com/apache/iceberg/pull/10200#issuecomment-2070951618 @chenjunjiedada you might be interested. This is to leverage the targeted position delete file that @aokolnychyi implemented from PR #9384 -- This is an automated message from the

Re: [PR] Flink: Move ParquetReader to LogicalTypeAnnotationVisitor [iceberg]

2024-04-22 Thread via GitHub
Fokko commented on PR #9719: URL: https://github.com/apache/iceberg/pull/9719#issuecomment-2070940298 > Does this test both the ns, and the ms timestamps? No, not yet. I want to do that in a separate PR, but this change needs to be done before that. In Parquet, there is no `OriginalTy

Re: [PR] Flink: Move ParquetReader to LogicalTypeAnnotationVisitor [iceberg]

2024-04-22 Thread via GitHub
Fokko commented on code in PR #9719: URL: https://github.com/apache/iceberg/pull/9719#discussion_r1575347885 ## gradle.properties: ## @@ -16,7 +16,7 @@ jmhOutputPath=build/reports/jmh/human-readable-output.txt jmhJsonOutputPath=build/reports/jmh/results.json jmhIncludeRegex=.

Re: [PR] Flink: Move ParquetReader to LogicalTypeAnnotationVisitor [iceberg]

2024-04-22 Thread via GitHub
pvary commented on PR #9719: URL: https://github.com/apache/iceberg/pull/9719#issuecomment-2070919190 > @pvary There are already quite a few tests: https://github.com/apache/iceberg/blob/main/flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java > >

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-04-22 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1575310347 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2978,63 @@ components: additionalProperties: type: string +PreplanTableRequest: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-04-22 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1575310347 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2978,63 @@ components: additionalProperties: type: string +PreplanTableRequest: +

Re: [PR] Flink: Move ParquetReader to LogicalTypeAnnotationVisitor [iceberg]

2024-04-22 Thread via GitHub
pvary commented on code in PR #9719: URL: https://github.com/apache/iceberg/pull/9719#discussion_r1575327250 ## gradle.properties: ## @@ -16,7 +16,7 @@ jmhOutputPath=build/reports/jmh/human-readable-output.txt jmhJsonOutputPath=build/reports/jmh/results.json jmhIncludeRegex=.

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-04-22 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1575310347 ## open-api/rest-catalog-open-api.yaml: ## @@ -2838,6 +2978,63 @@ components: additionalProperties: type: string +PreplanTableRequest: +

Re: [PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-04-22 Thread via GitHub
geruh commented on PR #10199: URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2070875152 Awesome, thanks for contributing this @aajisaka! Manually did this change work? For adding some tests, if the unit test logic in this module is difficult. I'd suggest leveraging this modu

Re: [PR] Flink: Move ParquetReader to LogicalTypeAnnotationVisitor [iceberg]

2024-04-22 Thread via GitHub
Fokko commented on PR #9719: URL: https://github.com/apache/iceberg/pull/9719#issuecomment-2070731771 @pvary There are already quite a few tests: https://github.com/apache/iceberg/blob/main/flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java This

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575167955 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOExcept

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575160742 ## core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: ## @@ -140,7 +155,9 @@ public void write(T row) throws IOException { PathOffset previous = i

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575145666 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOExcept

Re: [PR] Remove hard-coded release version [iceberg-python]

2024-04-22 Thread via GitHub
HonahX merged PR #643: URL: https://github.com/apache/iceberg-python/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

[PR] OpenAPI: Add AppendDataFile models to openapi spec for fine grained metadata commits [iceberg]

2024-04-22 Thread via GitHub
geruh opened a new pull request, #10202: URL: https://github.com/apache/iceberg/pull/10202 Now that we have landed the models for content files in the REST spec, we can return to making the changes to enable appends through fine grained metadata commits on Iceberg tables. Currently

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575094495 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/RowDataRewriter.java: ## @@ -84,7 +85,8 @@ public RowDataRewriter( format,

Re: [PR] Add Pagination To List Apis [iceberg]

2024-04-22 Thread via GitHub
rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571188458 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2329,6 +2332,119 @@ public void multipleDiffsAgainstMultipleTablesLastFails() { assertT

Re: [PR] Remove hard-coded release version [iceberg-python]

2024-04-22 Thread via GitHub
danielcweeks commented on PR #643: URL: https://github.com/apache/iceberg-python/pull/643#issuecomment-2070252667 Nice catch @HonahX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575089122 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOExcept

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575081217 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOExcept

Re: [PR] Flink: Apply DeleteGranularity for writes [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1575081217 ## data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java: ## @@ -409,6 +421,55 @@ public void testUpsertDataWithFullRowSchema() throws IOExcept

Re: [PR] Hive: turn off the stats gathering when iceberg.hive.keep.stats is false [iceberg]

2024-04-22 Thread via GitHub
stargrey102 commented on PR #10148: URL: https://github.com/apache/iceberg/pull/10148#issuecomment-2070212856 Hi @pvary thank you for the review, typo and format have been fixed. Do you think if it can be merged? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] rewrite_data_files procedure fails with Premature end of Content-Length when using S3 client [iceberg]

2024-04-22 Thread via GitHub
megri commented on issue #9679: URL: https://github.com/apache/iceberg/issues/9679#issuecomment-2069863018 I am experiencing the same issues, using the same setup as paulpaul1076. Thanks to this discussion I also tried changing from S3FileIO to the default and so far it seems to be working

Re: [I] Implement `ManifestEvaluator` to prune mainfest files. [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 commented on issue #253: URL: https://github.com/apache/iceberg-rust/issues/253#issuecomment-2069752408 Close by #322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Implement `ManifestEvaluator` to prune mainfest files. [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 closed issue #253: Implement `ManifestEvaluator` to prune mainfest files. URL: https://github.com/apache/iceberg-rust/issues/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-04-22 Thread via GitHub
hsiang-c commented on PR #10201: URL: https://github.com/apache/iceberg/pull/10201#issuecomment-2069698512 FYI @ggershinsky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: init iceberg writer [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 merged PR #275: URL: https://github.com/apache/iceberg-rust/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] AWS: Make sure Signer + User Agent config are both applied [iceberg]

2024-04-22 Thread via GitHub
amogh-jahagirdar merged PR #10198: URL: https://github.com/apache/iceberg/pull/10198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] Update Roadmap / Close old Issues [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 commented on issue #330: URL: https://github.com/apache/iceberg-rust/issues/330#issuecomment-2069475302 Github will automatically close issues when you write close `Close #issuenum ` in issue body, I will go through the issues to close them. -- This is an automated message f

Re: [I] Update Roadmap / Close old Issues [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 closed issue #330: Update Roadmap / Close old Issues URL: https://github.com/apache/iceberg-rust/issues/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

2024-04-22 Thread via GitHub
liurenjie1024 merged PR #322: URL: https://github.com/apache/iceberg-rust/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-22 Thread via GitHub
marvinlanhenke commented on PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2069378623 > Thanks! Sorry for replying late. I think this is a good start for the integration work. And I have completed #277. Maybe we can convert this PR to ready for review now. @marvi

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-22 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1574731993 ## crates/integrations/datafusion/src/catalog.rs: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [I] Structured streaming writes to partitioned table fails when spark.sql.extensions is set to IcebergSparkSessionExtensions [iceberg]

2024-04-22 Thread via GitHub
UtkarshSharma2612 commented on issue #7226: URL: https://github.com/apache/iceberg/issues/7226#issuecomment-2069280084 I am writing using structured spark streaming to iceberg, my spark version is 3.4.2 and iceberg version is 2. I am facing this issue also and changing `.option()` to `.toTa

[PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

2024-04-22 Thread via GitHub
hsiang-c opened a new pull request, #10201: URL: https://github.com/apache/iceberg/pull/10201 ### Note to reviewers - One of our customers would like to read PME-encrypted tables in JVM application. - Therefore, switching to `EncryptingFileIO` as https://github.com/apache/iceberg/pu

Re: [I] does iceberg can run on k8s? [iceberg]

2024-04-22 Thread via GitHub
nastra commented on issue #10196: URL: https://github.com/apache/iceberg/issues/10196#issuecomment-2068886431 @JunseoChoJJ yes Iceberg can run on k8s. There are no special installation docs required for k8s. Iceberg is integrated through your engine of choice (Flink, Spark, Trino, ..), so a

Re: [PR] GCP: Add Iceberg Catalog for GCP BigLake Metastore [iceberg]

2024-04-22 Thread via GitHub
nastra commented on PR #7412: URL: https://github.com/apache/iceberg/pull/7412#issuecomment-2068859607 @coufon sorry for the delay here, this fell off the radar unfortunately. Could you rebase the PR please? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] GCP: Add Iceberg Catalog for GCP BigLake Metastore [iceberg]

2024-04-22 Thread via GitHub
linchun3 commented on PR #7412: URL: https://github.com/apache/iceberg/pull/7412#issuecomment-2068741737 +1 would love to see this move forward :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-04-22 Thread via GitHub
aajisaka opened a new pull request, #10199: URL: https://github.com/apache/iceberg/pull/10199 ## Problem In AWS Glue Catalog, user can set arbitrary description to the table and its columns via Web UI or even from Amazon Athena. However, the descriptions will be removed after upgradi

Re: [PR] Core: Lazily compute & cache hashCode in CharSequenceWrapper [iceberg]

2024-04-22 Thread via GitHub
nastra merged PR #10023: URL: https://github.com/apache/iceberg/pull/10023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[PR] AWS: Make sure Signer + User Agent config are both applied [iceberg]

2024-04-22 Thread via GitHub
nastra opened a new pull request, #10198: URL: https://github.com/apache/iceberg/pull/10198 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m