aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1575528604
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ########## @@ -196,6 +201,33 @@ private Duration toDuration(String time) { } } + class ReadTypeConfParser extends ConfParser<ReadTypeConfParser, ReaderType> { Review Comment: Maybe, a dedicated enum would be a better option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org