nastra closed issue #10084: Inconsistent initial field ids with REST catalog
URL: https://github.com/apache/iceberg/issues/10084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nastra commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2036229721
@AwasthiSomesh you might want to go through the link that I posted (and also
through the Glue docs on how to connect to Iceberg). The settings you need
could depend on your local AW
AwasthiSomesh commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2036225160
@lxs360 were you able resolve this issue ? I'm also facing the same issue
using same spark configuration?
I see you already reported this issue long back
-https://gith
AwasthiSomesh commented on issue #4739:
URL: https://github.com/apache/iceberg/issues/4739#issuecomment-2036212994
@lxs360 were you able resolve this issue ? I'm also facing the same issue
using same spark configuration?
--
This is an automated message from the Apache Git Service.
To resp
nastra commented on issue #10084:
URL: https://github.com/apache/iceberg/issues/10084#issuecomment-2036212500
> ```
> spark.sql("CREATE TABLE rest.test.table1(id bigint, data
string)").show(false)
> ```
>
> And you can see the request body sent to the createTable endpoint will
HonahX closed issue #483: Support CreateTableTransaction
URL: https://github.com/apache/iceberg-python/issues/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
HonahX merged PR #498:
URL: https://github.com/apache/iceberg-python/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#issuecomment-2036194320
Thanks @Fokko @syun64 for detailed reviewing! Since this PR
changes/refactors lots of code, I'll merge this first and leave other works
(such as supporting createTableTrans in Hive an
AwasthiSomesh commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2036193452
@nastra Thanks a lot for your reply.
I am facing credentials load issue from spark .. could you please help how
to add access-key and secret key with region on spark
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1550918541
##
pyiceberg/table/__init__.py:
##
@@ -760,7 +852,10 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
for update in updates
ksmatharoo commented on issue #1617:
URL: https://github.com/apache/iceberg/issues/1617#issuecomment-2036181086
@jotarada We encountered a similar issue when we switched S3 vendors,
necessitating the copying of all data to another bucket, resulting in
unreadable iceberg tables. Currently, w
ksmatharoo commented on issue #3142:
URL: https://github.com/apache/iceberg/issues/3142#issuecomment-2036179649
@atifiu @meicanhong We encountered a similar issue when we switched S3
vendors, necessitating the copying of all data to another bucket, resulting in
unreadable iceberg tables. Cu
nastra commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2036175205
I see you have
```
.config("spark.sql.catalog.AwsDataCatalog","org.apache.iceberg.spark.SparkSessionCatalog")
.config("spark.sql.catalog.AwsDataCatalog",
"org.apache.icebe
marvinlanhenke commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1550859891
##
crates/iceberg/src/expr/visitors/bound_predicate_evaluator.rs:
##
@@ -0,0 +1,339 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
marvinlanhenke commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1550844497
##
crates/iceberg/src/expr/visitors/bound_predicate_evaluator.rs:
##
@@ -0,0 +1,339 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
amogh-jahagirdar commented on code in PR #10079:
URL: https://github.com/apache/iceberg/pull/10079#discussion_r1550841639
##
format/spec.md:
##
@@ -314,7 +314,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
|---|--
aokolnychyi commented on PR #9437:
URL: https://github.com/apache/iceberg/pull/9437#issuecomment-2036115472
I cloned this change and played with it locally. Here are my thoughts.
1. We should focus on the local implementation for now. I think it is going
to perform OK for most use cas
amogh-jahagirdar commented on code in PR #10079:
URL: https://github.com/apache/iceberg/pull/10079#discussion_r1550831622
##
format/spec.md:
##
@@ -314,7 +314,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
|---|--
tomtongue commented on issue #9080:
URL: https://github.com/apache/iceberg/issues/9080#issuecomment-2036003100
@nastra If no one is assigned with this project, could you assign this with
me? I'll work on this.
--
This is an automated message from the Apache Git Service.
To respond to the
hgschmie opened a new issue, #10085:
URL: https://github.com/apache/iceberg/issues/10085
### Apache Iceberg version
1.5.0 (latest release)
### Query engine
Flink
### Please describe the bug 🐞
We have a test setup where multiple AWS profiles exist in the usua
zhongyujiang commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2035906920
> any reason why you stopped pursuing it?
There was relatively little feedback from the community after openning this
PR, so I did not proceed with it further. Since more peo
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1550695864
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2035897279
> I just want to add a few high-level comments here:
>
> 1. It looks like `pageSize` is currently required, but I believe the
default should be that if it is not set, no pagination
github-actions[bot] commented on issue #2440:
URL: https://github.com/apache/iceberg/issues/2440#issuecomment-2035836502
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2439:
URL: https://github.com/apache/iceberg/issues/2439#issuecomment-2035836481
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2435:
URL: https://github.com/apache/iceberg/issues/2435#issuecomment-2035836465
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2424:
URL: https://github.com/apache/iceberg/issues/2424#issuecomment-2035836434
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2425:
URL: https://github.com/apache/iceberg/issues/2425#issuecomment-2035836450
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
amogh-jahagirdar commented on code in PR #10052:
URL: https://github.com/apache/iceberg/pull/10052#discussion_r1550644916
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -121,6 +128,92 @@ public void testHeadFailure() throws
JsonProcessingException {
RussellSpitzer commented on issue #10084:
URL: https://github.com/apache/iceberg/issues/10084#issuecomment-2035737989
The core lib defined this behavior a while back. Any table that goes through
the create table logic has its fields reordered starting a 1 regardless of the
schemas field ids
syun64 commented on code in PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#discussion_r1550573900
##
tests/integration/test_writes.py:
##
@@ -778,3 +778,31 @@ def test_inspect_snapshots(
continue
assert left == right, f"Difference
mrcnc opened a new issue, #10084:
URL: https://github.com/apache/iceberg/issues/10084
### Query engine
Using Spark 3.4.0 with Iceberg 1.4.3
### Question
To reproduce this behavior you can start a spark shell configured with 2
catalogs
```
SPARK_VERSION=3.4
I
viirya commented on PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2035635200
I've addressed some of above reviews. I will resolve other reviews soon.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1550524484
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
moryachok opened a new issue, #578:
URL: https://github.com/apache/iceberg-python/issues/578
### Question
After examining your documentation, I couldn't locate the methods to list a
table's partitions or its data files. Could you please provide relevant
examples or consider adding th
Fokko commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1550332689
##
pyiceberg/typedef.py:
##
@@ -199,3 +199,7 @@ def __repr__(self) -> str:
def record_fields(self) -> List[str]:
"""Return values of all the fields of
Fokko merged PR #576:
URL: https://github.com/apache/iceberg-python/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #577:
URL: https://github.com/apache/iceberg-python/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko closed issue #550: Custom header should not overwrite default header in
RESTCatalog
URL: https://github.com/apache/iceberg-python/issues/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1550312388
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1550310964
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
sdd commented on PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2035371003
Hi @liurenjie1024 and @marvinlanhenke. I've updated this PR to align with
the direction suggested above - thanks a lot for all the feedback!
This PR is clearly far too big to easily
Fokko commented on PR #316:
URL: https://github.com/apache/iceberg-rust/pull/316#issuecomment-2035331577
Merging this to fix the CI, thanks @marvinlanhenke 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Fokko closed issue #315: CI-Build: Breaks due to `motore` update
URL: https://github.com/apache/iceberg-rust/issues/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Fokko merged PR #316:
URL: https://github.com/apache/iceberg-rust/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
thorfour closed issue #60: GCS support?
URL: https://github.com/apache/iceberg-go/issues/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
Pilipets commented on issue #8527:
URL: https://github.com/apache/iceberg/issues/8527#issuecomment-2035285224
Is there any examples for Iceberg defaults with V3? The description makes
sense, but not sure what's the format or how to set initial-default from the
given link.
--
This is an a
marvinlanhenke opened a new pull request, #316:
URL: https://github.com/apache/iceberg-rust/pull/316
closes #315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
cccs-jc commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2035231045
I'm interested in getting that PR into the upstream Iceberg. @zhongyujiang
any reason why you stopped pursuing it? Are you using it in production?
--
This is an automated message from t
jqin61 commented on code in PR #571:
URL: https://github.com/apache/iceberg-python/pull/571#discussion_r1550202992
##
tests/integration/test_writes.py:
##
@@ -778,3 +778,31 @@ def test_inspect_snapshots(
continue
assert left == right, f"Difference
flyrain commented on PR #577:
URL: https://github.com/apache/iceberg-python/pull/577#issuecomment-2035208510
@Fokko, do you wanna take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kevinjqliu commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2035144573
thank you! should we close this in favor of #570?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kevinjqliu commented on issue #570:
URL: https://github.com/apache/iceberg-python/issues/570#issuecomment-2035130535
I think it makes sense to have both a "catalog level" configuration and a
"file level" configuration. A catalog might have a different set of permissions
from when reading sp
whynick1 commented on PR #577:
URL: https://github.com/apache/iceberg-python/pull/577#issuecomment-2035081299
@flyrain @liurenjie1024 Can you take a look please. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
whynick1 commented on code in PR #577:
URL: https://github.com/apache/iceberg-python/pull/577#discussion_r1550080729
##
tests/catalog/test_rest.py:
##
@@ -277,36 +277,55 @@ def test_properties_sets_headers(requests_mock: Mocker)
-> None:
)
catalog = RestCatalog(
-
whynick1 commented on code in PR #577:
URL: https://github.com/apache/iceberg-python/pull/577#discussion_r1550080729
##
tests/catalog/test_rest.py:
##
@@ -277,36 +277,55 @@ def test_properties_sets_headers(requests_mock: Mocker)
-> None:
)
catalog = RestCatalog(
-
AwasthiSomesh commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2035029132
@nastra Even I see we are getting error for region unable to load.
Error:-
Exception in thread "main"
software.amazon.awssdk.core.exception.SdkClientException: Una
jqin61 commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1548568425
##
pyiceberg/table/__init__.py:
##
@@ -2726,6 +2731,112 @@ def _commit(self) -> UpdatesAndRequirements:
)
+class DeleteFiles(_MergingSnapshotProducer):
aokolnychyi commented on PR #9437:
URL: https://github.com/apache/iceberg/pull/9437#issuecomment-203504
Will take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
AwasthiSomesh commented on issue #10078:
URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2034985982
@nastra Thanks for your reply
After adding this we see the same error.
Could you please check is there any mistake from my end
.config("spark.sql.catalog.Aw
liurenjie1024 commented on issue #315:
URL: https://github.com/apache/iceberg-rust/issues/315#issuecomment-2034932066
I'm in favor of updating rustc since we want to use latest `volo-thrift`,
the only cons is that it requires users to upgrade rustc to 1.77.0+.
> Running cargo update m
zeroshade commented on PR #66:
URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-2034881770
That's my fault for not responding here, it's been a busy month. My
apologies.
I would absolutely be willing to approve a cleaned up PR.
--
This is an automated message from the
thorfour commented on PR #66:
URL: https://github.com/apache/iceberg-go/pull/66#issuecomment-2034863026
Seems like this repo is relatively inactive. So I'm going to close this for
now, and continue in our fork. Thanks!
--
This is an automated message from the Apache Git Service.
To respon
thorfour closed pull request #66: objstore: Replace IO interface with
objstore.Bucket
URL: https://github.com/apache/iceberg-go/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Fokko commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1549860927
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
self.co
nastra merged PR #10067:
URL: https://github.com/apache/iceberg/pull/10067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
marvinlanhenke commented on issue #315:
URL: https://github.com/apache/iceberg-rust/issues/315#issuecomment-2034703376
cc @liurenjie1024 @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
liurenjie1024 merged PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
marvinlanhenke commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2034723238
@liurenjie1024 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asuresh8 opened a new issue, #10083:
URL: https://github.com/apache/iceberg/issues/10083
### Feature Request / Improvement
Iceberg supports skip indexes natively, but these skip indexes are limited
in scope. Users should be able to create additional indices that can be applied
at que
AlexMercedCoder commented on code in PR #10067:
URL: https://github.com/apache/iceberg/pull/10067#discussion_r1549766534
##
site/docs/blogs.md:
##
@@ -77,26 +119,31 @@ Here is a list of company blogs that talk about Iceberg.
The blogs are ordered f
**Authors**: [Ayush Saxena
marvinlanhenke opened a new pull request, #314:
URL: https://github.com/apache/iceberg-rust/pull/314
### Which issue does this PR close?
Closes #249 (Task 3/3)
### Rationale for this change
Add support for Glue Catalog, to reach feature parity with other
implementations.
nastra merged PR #10069:
URL: https://github.com/apache/iceberg/pull/10069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2034605250
> @nastra yes, I'm gonna made changes you proposed. In majority changes I
switched Junit4 to Junit5 not AssertJ because it was said to switch to Junit5.
Anyway, thank you for your comments
igoradulian commented on PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2034574140
@nastra yes, I'm gonna made changes you proposed. In majority changes I
switched Junit4 to Junit5 not AssertJ because it was said to switch to Junit5.
Anyway, thank you for your comme
nastra commented on PR #9945:
URL: https://github.com/apache/iceberg/pull/9945#issuecomment-2034532286
@bk-mz I don't think the test actually reproduces the underlying issue. See
my comment in https://github.com/apache/iceberg/pull/9945#discussion_r1526415663
--
This is an automated messa
nastra closed pull request #10073: Build: add gradle wrapper validation action
URL: https://github.com/apache/iceberg/pull/10073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
MehulBatra commented on PR #566:
URL: https://github.com/apache/iceberg-python/pull/566#issuecomment-2034449315
> Thanks for working on this @MehulBatra 🙌
Always great to work on Iceberg and learn from you and the team!
--
This is an automated message from the Apache Git Service.
To
nastra commented on code in PR #10067:
URL: https://github.com/apache/iceberg/pull/10067#discussion_r1549628699
##
site/docs/blogs.md:
##
@@ -77,26 +119,31 @@ Here is a list of company blogs that talk about Iceberg.
The blogs are ordered f
**Authors**: [Ayush Saxena](https:/
Fokko merged PR #566:
URL: https://github.com/apache/iceberg-python/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
nk1506 commented on PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#issuecomment-2034389989
@szehon-ho / @nastra , Please let me know if there are any comments left .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1549581440
##
mkdocs/docs/api.md:
##
@@ -165,6 +165,25 @@ catalog.create_table(
)
```
+To create a table with some subsequent changes in a transaction:
Review Comment:
Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1549588018
##
pyiceberg/table/__init__.py:
##
@@ -760,7 +852,10 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
for update in updates:
ajantha-bhat commented on issue #10003:
URL: https://github.com/apache/iceberg/issues/10003#issuecomment-2034277214
Namespace has to be created explicitly in Nessie as described in
https://projectnessie.org/blog/namespace-enforcement/
--
This is an automated message from the Apache Git Se
nastra commented on issue #10003:
URL: https://github.com/apache/iceberg/issues/10003#issuecomment-2034239933
@matepek fundamentally that issue is the same as I described in
https://github.com/apache/iceberg/issues/10003#issuecomment-2007780751.
`SparkSessionCatalog` doesn't create a namesp
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549453971
##
data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java:
##
@@ -122,7 +123,7 @@ public void testSchemaEvolution() throws Exception {
dec
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549450840
##
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##
@@ -108,11 +112,8 @@ public void writeTestDataFile() throws IOException {
records.add(record.
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549452602
##
data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java:
##
@@ -19,12 +19,12 @@
package org.apache.iceberg.data;
import static org.apache.iceberg.types.
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549452056
##
data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java:
##
@@ -38,7 +38,8 @@ public class TestGenericReaderDeletes extends DeleteReadTests
{
@
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549451494
##
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##
@@ -85,33 +84,25 @@ public void createTableAndData() throws IOException {
recor
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549445167
##
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##
@@ -108,11 +112,8 @@ public void writeTestDataFile() throws IOException {
records.add(record.
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549444931
##
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##
@@ -18,6 +18,7 @@
*/
package org.apache.iceberg.data;
+
Review Comment:
unnecessary newli
nastra commented on issue #9079:
URL: https://github.com/apache/iceberg/issues/9079#issuecomment-2034192040
fixed by #9381 #9598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
nastra closed issue #9085: iceberg-core: Switch tests to JUnit5 + AssertJ-style
assertions
URL: https://github.com/apache/iceberg/issues/9085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
nastra closed issue #9079: Create JUnit5-version of FlinkCatalogTestBase
URL: https://github.com/apache/iceberg/issues/9079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
nastra merged PR #10080:
URL: https://github.com/apache/iceberg/pull/10080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
lurnagao-dahua commented on code in PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#discussion_r1549380381
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##
@@ -397,6 +397,30 @@ public void testLockExceptionUnknownSuccessCommit() throw
tomtongue commented on PR #10080:
URL: https://github.com/apache/iceberg/pull/10080#issuecomment-2034071501
> the changes you have so far LGTM, is this PR still WIP or ready?
Thanks for the review. This PR is ready, and all the classes are already
migrated. Remove "WIP".
--
This is
1 - 100 of 120 matches
Mail list logo
