rahil-c commented on PR #9782: URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2035897279
> I just want to add a few high-level comments here: > > 1. It looks like `pageSize` is currently required, but I believe the default should be that if it is not set, no pagination should be requested and all results are returned. This is going to be the typical behavior for any REST catalog that does not support paging. > 2. If a REST server has a specific page limit, it should return that as part of the config route properties as an override. Implementations may have different limits and we should not require users to configure the client to correspond to the limitations of the server. > > As a follow up to #2, it seems there may be a chase were some servers require pagination, so they will probably need to return a 400 BadRequest if a client is asking for all values in a request and the server requires they support pagination. @danielcweeks @nastra @rdblue @jackye1995 Im curious for `2.` if this page limit is to be returned by the rest server, should this be apart of the capabilities pr? I think from the pr https://github.com/apache/iceberg/pull/9940 we did not want to have pagination listed there it seems but just wanted to bring this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
