sdd commented on PR #241: URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2035371003
Hi @liurenjie1024 and @marvinlanhenke. I've updated this PR to align with the direction suggested above - thanks a lot for all the feedback! This PR is clearly far too big to easily digest now though. I'll rebase it and resubmit it in pieces as separate PRs: * Accessors * BoundPredicateVisitor * InclusiveProjection * ManifestEvaluator itself * Misc changes such as adding AlwaysTrue / AlwaysFalse and any new getters * Changes to `scan.rs` that bring it all together Unless you have any other suggestions. I'll happily close any of the raised PRs if they don't match the direction we agree to go with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
