sachet commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1548998658
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more con
pvary commented on PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2033649191
@lurnagao-dahua: If you check
https://github.com/apache/iceberg/blob/3caa3a28d07a2d08b9a0e4196634126f1e016d6a/hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java,
yo
HonahX commented on issue #570:
URL: https://github.com/apache/iceberg-python/issues/570#issuecomment-2033588669
@geruh, thanks for highlighting this issue. The confusion largely stems from
the naming convention used when the `profile_name`, `region_name`,
`aws_access_key_id`, etc., were in
danielcweeks commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1548945175
##
core/src/main/java/org/apache/iceberg/rest/PaginatedList.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
enkidulan commented on issue #573:
URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2033571970
For the reference, I was able to make a tag only by using some private
properties of the transaction object:
```py
from pyiceberg.table import SetSnapshotRefUpdate, u
enkidulan opened a new issue, #573:
URL: https://github.com/apache/iceberg-python/issues/573
### Feature Request / Improvement
Historical tags in iceberg docs -
https://iceberg.apache.org/docs/1.5.0/branching/#historical-tags
Not sure if it was intentional behavior, but pyicebe
liurenjie1024 commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1548900850
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+
viirya commented on code in PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#discussion_r1548890936
##
crates/iceberg/src/reader.rs:
##
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
liurenjie1024 commented on PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#issuecomment-2033470850
cc @viirya Would you also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
liurenjie1024 commented on code in PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#discussion_r1548868232
##
crates/iceberg/src/arrow/from.rs:
##
Review Comment:
How about just name it as `schema.rs`, and we can put all schema related
codes here?
#
Co0olCat commented on issue #572:
URL: https://github.com/apache/iceberg-python/issues/572#issuecomment-2033459923
It looks like an issue of pyarrow. scan() returns correct data and type.
pyarrow.project_table() does the conversion...
--
This is an automated message from the Apache Git
Co0olCat closed issue #572: int64() is converted to float for nullable field
when None is provided + nan returned when None is expected
URL: https://github.com/apache/iceberg-python/issues/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Co0olCat opened a new issue, #572:
URL: https://github.com/apache/iceberg-python/issues/572
### Apache Iceberg version
0.6.0 (latest release)
### Please describe the bug 🐞
For reproduction using
https://github.com/apache/iceberg-python/blob/main/tests/catalog/test_glue.p
tomtongue opened a new pull request, #10080:
URL: https://github.com/apache/iceberg/pull/10080
Migrate the following test classes to delete `TableTestBase` for
https://github.com/apache/iceberg/issues/9085.
This PR is for the migration of `TableTestBase` related classes in
https://g
lurnagao-dahua commented on PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2033424821
Thank you for your response!
In my case flink streaming write to iceberg
1.Hive metastore has been full GC continuously so it will throw
SocketTimeoutException: Read timed
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1548817290
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
ajantha-bhat commented on code in PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#discussion_r1548815679
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1444,7 +1444,7 @@ components:
schema:
type: string
required: true
- description: An opti
syun64 opened a new pull request, #571:
URL: https://github.com/apache/iceberg-python/pull/571
As a followup from @HonahX 's suggestion on
https://github.com/apache/iceberg-python/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1548813765
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1548809949
##
crates/iceberg/src/arrow.rs:
##
@@ -20,24 +20,38 @@
use async_stream::try_stream;
use futures::stream::StreamExt;
use parquet::arrow::{ParquetRecordBatchStreamB
viirya commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1548810072
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+fn get_
ZENOTME commented on PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#issuecomment-2033373684
cc @liurenjie1024 @Xuanwo @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ZENOTME opened a new pull request, #313:
URL: https://github.com/apache/iceberg-rust/pull/313
This PR separates out the parquet reader from the arrow module. And make the
arrow module a dir so that we can separate the `from_arow` and `to_arrow`.
--
This is an automated message from the A
liurenjie1024 commented on PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2033371130
> > which is somehow motivated by @viirya 's
[pr](https://github.com/apache/iceberg-rust/pull/295/files#diff-a59622727cd67153abdf02031475bf8a1b1921738df4ca9903a685ff6970b7aaR472),
liurenjie1024 merged PR #310:
URL: https://github.com/apache/iceberg-rust/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
syun64 commented on PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#issuecomment-2033344103
> Shall we move "append", "overwrite", and "add_files" to `Transaction`
class? This change would enable us to seamlessly chain these operations with
other table updates in a single co
github-actions[bot] commented on issue #2414:
URL: https://github.com/apache/iceberg/issues/2414#issuecomment-2033310864
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #2409:
URL: https://github.com/apache/iceberg/issues/2409#issuecomment-2033310842
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #2211: how to fix
org.apache.spark.shuffle.FetchFailedException:
URL: https://github.com/apache/iceberg/issues/2211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on issue #2211:
URL: https://github.com/apache/iceberg/issues/2211#issuecomment-2033310616
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2209: Need help inserting data into hadoop
table with flink sql in java
URL: https://github.com/apache/iceberg/issues/2209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on issue #2209:
URL: https://github.com/apache/iceberg/issues/2209#issuecomment-2033310589
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #2198:
URL: https://github.com/apache/iceberg/issues/2198#issuecomment-2033310562
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2198: Hive: got error while joining iceberg
table and hive table
URL: https://github.com/apache/iceberg/issues/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on issue #2192:
URL: https://github.com/apache/iceberg/issues/2192#issuecomment-2033310543
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #2192: Cannot write incompatible dataset to
table with schema error for list types
URL: https://github.com/apache/iceberg/issues/2192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1548708375
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/comet/CometIcebergColumnReader.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache So
AlexMercedCoder commented on code in PR #10067:
URL: https://github.com/apache/iceberg/pull/10067#discussion_r1548619662
##
site/docs/blogs.md:
##
@@ -23,6 +23,37 @@ title: "Blogs"
Here is a list of company blogs that talk about Iceberg. The blogs are ordered
from most recent
AlexMercedCoder commented on code in PR #10067:
URL: https://github.com/apache/iceberg/pull/10067#discussion_r1548618808
##
site/docs/blogs.md:
##
@@ -23,6 +23,37 @@ title: "Blogs"
Here is a list of company blogs that talk about Iceberg. The blogs are ordered
from most recent
RussellSpitzer commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1548617271
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/comet/CometIcebergColumnReader.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apac
geruh opened a new issue, #570:
URL: https://github.com/apache/iceberg-python/issues/570
### Apache Iceberg version
main (development)
### Please describe the bug 🐞
When initializing the GlueCatalog with a specific AWS profile, everything
works as it should with catalog
rahil-c commented on PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#issuecomment-2033006567
@nastra @rdblue @danielcweeks @jackye1995 @amogh-jahagirdar
When looking again at the `capabalities` pr:
https://github.com/apache/iceberg/pull/9940, are we sure we want to add
sc
findinpath commented on issue #9404:
URL: https://github.com/apache/iceberg/issues/9404#issuecomment-2032964716
@sfc-gh-rortloff i went through the Snowflake documenation
https://docs.snowflake.com/en/sql-reference/sql/create-iceberg-table and don't
see any reference related to partitioning
geruh commented on issue #515:
URL: https://github.com/apache/iceberg-python/issues/515#issuecomment-2032913100
No Problem!!
This could potentially be a bug if we assume that the catalog and FileIO
(S3) share the same aws profile configs. On one side, having a single profile
configu
jqin61 commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1548140319
##
pyiceberg/table/__init__.py:
##
@@ -2526,25 +2537,44 @@ def _dataframe_to_data_files(
"""
from pyiceberg.io.pyarrow import bin_pack_arrow_table, write_
jqin61 commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1548140319
##
pyiceberg/table/__init__.py:
##
@@ -2526,25 +2537,44 @@ def _dataframe_to_data_files(
"""
from pyiceberg.io.pyarrow import bin_pack_arrow_table, write_
jqin61 commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1548140319
##
pyiceberg/table/__init__.py:
##
@@ -2526,25 +2537,44 @@ def _dataframe_to_data_files(
"""
from pyiceberg.io.pyarrow import bin_pack_arrow_table, write_
zeroshade commented on code in PR #68:
URL: https://github.com/apache/iceberg-go/pull/68#discussion_r1548127844
##
cmd/iceberg/main.go:
##
@@ -34,16 +34,21 @@ import (
const usage = `iceberg.
Usage:
- iceberg list [options] [PARENT]
- iceberg describe [options] [namespace
AwasthiSomesh opened a new issue, #10078:
URL: https://github.com/apache/iceberg/issues/10078
Hi Team ,
We are doing below code to access iceberg table from glue catalog and data
storage as S3
var spark = SparkSession.builder().master("local[*]")
.config("spark.sql.def
jqin61 commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1548068306
##
pyiceberg/typedef.py:
##
@@ -199,3 +199,7 @@ def __repr__(self) -> str:
def record_fields(self) -> List[str]:
"""Return values of all the fields of
Fokko opened a new pull request, #569:
URL: https://github.com/apache/iceberg-python/pull/569
This is done through the Iceberg metadata, resulting in efficient deletes if
the data is partitioned correctly
--
This is an automated message from the Apache Git Service.
To respond to the messa
marvinlanhenke commented on PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2032233828
> which is somehow motivated by @viirya 's
[pr](https://github.com/apache/iceberg-rust/pull/295/files#diff-a59622727cd67153abdf02031475bf8a1b1921738df4ca9903a685ff6970b7aaR472),
snazy commented on PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#issuecomment-2032202321
> > I've got strong concerns about using `enum` here - special handling here
and there, I think, that complicates things for adopters of any OpenAPI spec.
>
> @snazy we use `enum` in
lurnagao-dahua commented on PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2032193393
> @lurnagao-dahua please check styles.
>
> > The reason is that in some cases, the e.getMessage() return null and it
will throw NullPointerException, then skip checkCommitS
lurnagao-dahua commented on PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2032181736
> @lurnagao-dahua请检查样式。
>
> >
原因是在某些情况下,e.getMessage()返回null,会抛出NullPointerException,然后跳过checkCommitStatus,可能是删除metadataLocation,实际上元数据提交成功。
>
> 是否可以为这种情况添加 UT?
lurnagao-dahua closed pull request #10069: Hive: Fix metadata file not found
URL: https://github.com/apache/iceberg/pull/10069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nastra commented on PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#issuecomment-2032092212
> I've got strong concerns about using `enum` here - special handling here
and there, I think, that complicates things for adopters of any OpenAPI spec.
@snazy we use `enum` in t
jbonofre commented on code in PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#discussion_r1547920214
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1444,7 +1444,7 @@ components:
schema:
type: string
required: true
- description: An optional
ajantha-bhat commented on code in PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#discussion_r1547852220
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1444,7 +1444,7 @@ components:
schema:
type: string
required: true
- description: An opti
Fokko commented on code in PR #555:
URL: https://github.com/apache/iceberg-python/pull/555#discussion_r1547810906
##
pyiceberg/manifest.py:
##
@@ -289,10 +286,7 @@ def
partition_field_to_data_file_partition_field(partition_field_type: IcebergTy
@partition_field_to_data_fil
liurenjie1024 commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547819858
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a giv
liurenjie1024 commented on PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-2031946776
> @liurenjie1024 @ZENOTME @sdd @Xuanwo I'd really appreciate your thoughts
on this:
>
> I took a closer look at the work @sdd has already done - and I think in
order to pr
marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547785953
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a gi
marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547681855
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a gi
liurenjie1024 commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547676828
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a giv
marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547667177
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a gi
supsupsap commented on PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#issuecomment-2031741342
@abmo-x do you plan to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
liurenjie1024 commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547649993
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a giv
marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547653811
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a gi
nastra merged PR #10063:
URL: https://github.com/apache/iceberg/pull/10063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
tomtongue commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547650695
##
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java:
##
@@ -20,43 +20,42 @@
import java.io.File;
import java.io.IOException;
+import java.
nastra commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547646211
##
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java:
##
@@ -20,43 +20,42 @@
import java.io.File;
import java.io.IOException;
+import java.nio
marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547639860
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a gi
tomtongue commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547639555
##
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java:
##
@@ -20,43 +20,42 @@
import java.io.File;
import java.io.IOException;
+import java.
nastra commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547636721
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -73,44 +77,39 @@
import org.apache.iceberg.util.ThreadPools;
i
nastra commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547634234
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestDeltaTaskWriter.java:
##
@@ -65,31 +68,28 @@
import org.apache.iceberg.util.StructLikeSet;
impor
nastra commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547631706
##
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java:
##
@@ -20,43 +20,42 @@
import java.io.File;
import java.io.IOException;
+import java.nio
nastra commented on code in PR #10063:
URL: https://github.com/apache/iceberg/pull/10063#discussion_r1547632925
##
data/src/test/java/org/apache/iceberg/io/TestRollingFileWriters.java:
##
@@ -20,60 +20,60 @@
import java.io.File;
import java.io.IOException;
+import java.nio.f
marvinlanhenke commented on PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2031700958
> Hi, @marvinlanhenke Thanks for pr, it looks great! I have some small
suggestion to restructure the code to make it easier for review. Really
greatful for these tests!
T
liurenjie1024 commented on code in PR #295:
URL: https://github.com/apache/iceberg-rust/pull/295#discussion_r1547582654
##
crates/iceberg/src/arrow.rs:
##
@@ -113,6 +143,405 @@ impl ArrowReader {
// TODO: full implementation
ProjectionMask::all()
}
+
+
manuzhang commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547578684
##
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##
@@ -171,6 +176,10 @@ public static List listPartition(
}
}
+ public static bool
liurenjie1024 commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547488931
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,300 @@ impl Transform {
_ => self == other,
}
}
+
+/// Projects a giv
nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1547543252
##
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java:
##
@@ -84,16 +86,16 @@ private static void assertEquals(Type type, Object
expected, Object actual) {
nastra commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547529529
##
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##
@@ -171,6 +176,10 @@ public static List listPartition(
}
}
+ public static boolean
liurenjie1024 commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1547526634
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
Fokko commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1547503192
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
self.co
liurenjie1024 commented on PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#issuecomment-2031513654
> Hi, @Fokko Thanks for this fix. It also reminds me that should we append
the warehouse parameter to `getConfig` call?
Seems we already have that.
--
This is an automa
manuzhang commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547447584
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrateEmpt
manuzhang commented on issue #10060:
URL: https://github.com/apache/iceberg/issues/10060#issuecomment-2031439818
I also see errors when checking maven repo.
```
ERROR: 21 dead links found!
[✖]
https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runti
ajantha-bhat commented on code in PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#discussion_r1547408417
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1444,7 +1444,7 @@ components:
schema:
type: string
required: true
- description: An opti
nastra commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547402202
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrateEmptyTa
nastra commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1547402202
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -232,4 +232,25 @@ public void testMigrateEmptyTa
Fokko commented on code in PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#discussion_r1547395200
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1444,7 +1444,7 @@ components:
schema:
type: string
required: true
- description: An optional pr
ajantha-bhat commented on PR #9870:
URL: https://github.com/apache/iceberg/pull/9870#issuecomment-2031310056
cc: @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547300740
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547305188
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547304325
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547301639
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547301269
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547300740
##
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##
@@ -133,6 +136,59 @@ public void testDynamicHttpRequestInterceptorLoading() {
assertThat(((T
1 - 100 of 115 matches
Mail list logo