liurenjie1024 commented on code in PR #313:
URL: https://github.com/apache/iceberg-rust/pull/313#discussion_r1548868232


##########
crates/iceberg/src/arrow/from.rs:
##########


Review Comment:
   How about just name it as `schema.rs`, and we can put all schema related 
codes here?



##########
crates/iceberg/src/reader.rs:
##########


Review Comment:
   Move this to `arrow` module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to