nastra commented on code in PR #9176:
URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464446258
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##
@@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCantPushDown(
nastra commented on code in PR #9176:
URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464437182
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##
@@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCantPushDown(
nastra merged PR #9526:
URL: https://github.com/apache/iceberg/pull/9526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra merged PR #9548:
URL: https://github.com/apache/iceberg/pull/9548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
mgmarino commented on PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1907487756
> Overall LGTM! Thank you very much @mgmarino! Just adding one final request
to make `IcebergSchemaToGlueType` internal by adding `_`. Sorry I missed that
early
Sure, np!
HonahX closed issue #285: Add install extra for sqlite
URL: https://github.com/apache/iceberg-python/issues/285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
HonahX commented on issue #290:
URL: https://github.com/apache/iceberg-python/issues/290#issuecomment-1907475405
@kevinjqliu Thanks for sharing these options. I think (3) is enough here
since this is just in test. There are only few places which require checking
equality of both fields and
HonahX commented on code in PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464346417
##
pyiceberg/catalog/glue.py:
##
@@ -84,17 +110,97 @@ def _construct_parameters(
return new_parameters
+GLUE_PRIMITIVE_TYPES = {
+BooleanType: "boolean
pvary commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464351088
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous {
HonahX commented on code in PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464342275
##
tests/catalog/integration_test_glue.py:
##
@@ -279,6 +379,20 @@ def test_commit_table_update_schema(
assert test_catalog._parse_metadata_version(table.metad
HonahX commented on PR #298:
URL: https://github.com/apache/iceberg-python/pull/298#issuecomment-1907409790
OOPS. Seems there is a conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
advancedxy commented on PR #8579:
URL: https://github.com/apache/iceberg/pull/8579#issuecomment-1907243141
@szehon-ho @aokolnychyi the `bucketV2` part is removed from this PR. Let me
know if you have any more comments.
--
This is an automated message from the Apache Git Service.
To respon
stevenzwu commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464178171
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous
mas-chen commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464155134
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous
jakelong95 commented on issue #9518:
URL: https://github.com/apache/iceberg/issues/9518#issuecomment-1907148175
The issue is reproducible on Iceberg 1.4.2 and Spark 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
wolfeidau commented on code in PR #51:
URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1464148047
##
catalog/glue.go:
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE fil
wolfeidau commented on code in PR #51:
URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1464148047
##
catalog/glue.go:
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE fil
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464146096
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##
@@ -139,24 +139,9 @@ public void readFromMultipleViews() throws
NoSu
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145827
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache S
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145346
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache S
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464144880
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apac
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464142918
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache S
github-actions[bot] commented on issue #672:
URL: https://github.com/apache/iceberg/issues/672#issuecomment-1907128437
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #661:
URL: https://github.com/apache/iceberg/issues/661#issuecomment-1907128408
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #660:
URL: https://github.com/apache/iceberg/issues/660#issuecomment-1907128385
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #647:
URL: https://github.com/apache/iceberg/issues/647#issuecomment-1907128362
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #644:
URL: https://github.com/apache/iceberg/issues/644#issuecomment-1907128329
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #621:
URL: https://github.com/apache/iceberg/issues/621#issuecomment-1907128297
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #586:
URL: https://github.com/apache/iceberg/issues/586#issuecomment-1907128245
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
github-actions[bot] commented on issue #595:
URL: https://github.com/apache/iceberg/issues/595#issuecomment-1907128274
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs. T
singhpk234 commented on code in PR #9530:
URL: https://github.com/apache/iceberg/pull/9530#discussion_r1464132457
##
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##
@@ -59,7 +60,7 @@ private IcebergToGlueConverter() {}
private static final Patter
singhpk234 commented on issue #9518:
URL: https://github.com/apache/iceberg/issues/9518#issuecomment-1907096291
> Apologies, I edited out a quick test I had done that I actually ran on a
cluster that is on EMR 6.14 so it's expected that my test would succeed instead
of hit the reported erro
stevenzwu commented on code in PR #9547:
URL: https://github.com/apache/iceberg/pull/9547#discussion_r1464036002
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##
@@ -195,7 +192,10 @@ void monitorAndForwardSplits() {
// Ref
stevenzwu commented on code in PR #9547:
URL: https://github.com/apache/iceberg/pull/9547#discussion_r1464034995
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##
@@ -195,7 +192,10 @@ void monitorAndForwardSplits() {
// Ref
amogh-jahagirdar commented on code in PR #9176:
URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464032789
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##
@@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCan
Fokko commented on PR #297:
URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906969525
Thanks @kevinjqliu for picking this up 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Fokko merged PR #297:
URL: https://github.com/apache/iceberg-python/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
kevinjqliu commented on PR #297:
URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906912995
@Fokko thanks, I just ran `poetry lock --no-update`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Fokko commented on PR #297:
URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906902491
@kevinjqliu There is no upper bound constraint on Ray, and therefore it is
bumped to the latest version, which is not compatible for some reason. I've
created https://github.com/apache
syun64 commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906879564
> @Fokko @jqin61 I am also interested in this to move forward as we also
deal with lot of write involves partitions. Happy to collaborate on to this.
For write_dataset() we might
jqin61 commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906856252
> @jqin61 just wondering if we can use this directly
https://arrow.apache.org/docs/python/generated/pyarrow.dataset.partitioning.html
Thank you Ashish! I overlooked it, as
zeroshade commented on code in PR #51:
URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1463940580
##
catalog/glue.go:
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE fil
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463848914
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache S
Fokko commented on issue #293:
URL: https://github.com/apache/iceberg-python/issues/293#issuecomment-1906706092
@kevinjqliu Alright, that's fair, I just wanted to make sure that we
considered the option before making the `InMemory` one public 👍
--
This is an automated message from the Ap
rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463815754
##
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala:
##
@@ -59,6 +62,10 @@ case class ResolveViews(spark: SparkSessio
kevinjqliu commented on PR #297:
URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906669155
@Fokko np. I had to rebase and regenerate the lock file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
rdblue commented on issue #9433:
URL: https://github.com/apache/iceberg/issues/9433#issuecomment-1906663747
I think cleaning up metadata files is a catalog concern, not something that
should be exposed to users through a PURGE flag. A user is not prepared to make
a good choice about whether
rdblue commented on PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#issuecomment-1906654805
@amogh-jahagirdar, I'm not sure I agree with this change. It seems to me
that this is the Parquet default regardless of whether the default write format
is Avro or ORC. It's a format-speci
syun64 commented on issue #278:
URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-1906647358
That makes sense @Fokko .
Just to make sure we are on the same page, does the following approach align
with your thoughts?
We are proposing to update the create_tabl
Fokko commented on PR #297:
URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906625437
@kevinjqliu Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on issue #278:
URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-1906620668
Alright, I went to the source and talked with @danielcweeks and @rdblue. It
looks like we made things more complicated than actually needed.
So when reading and writing Parq
kevinjqliu commented on issue #290:
URL: https://github.com/apache/iceberg-python/issues/290#issuecomment-1906606223
Thanks for the explanation @HonahX
The equality check (`==`) for `Schema` here is overloaded. Sometimes it's
used to check whether two tables have the same structure,
Fokko merged PR #297:
URL: https://github.com/apache/iceberg-docs/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
jbonofre commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906568528
@ajantha-bhat correct, corner case but possible 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ajantha-bhat commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906559757
> I'm reworking a bit the SQL statement to have views and tables in the same
JDBC table, especially to address name atomically between table and view.
When we create a view, we che
jbonofre commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906555047
@ajantha-bhat the potential issue is about name/check between table and
view, it's separated today. My concern is not about namespace but more
concurrency on name between table and view.
jbonofre commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906552439
I'm reworking a bit the SQL statement to have views and tables in the same
JDBC table, especially to address name atomically between table and view.
When we create a view, we check if
ajantha-bhat commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906542388
> In order to avoid any potential concurrency issue, I'm working on a new
approach where both tables and views are store in the same JDBC Table, with a
column indicating if it's a ta
jbonofre commented on PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906520489
In order to avoid any potential concurrency issue, I'm working on a new
approach where both tables and views are store in the same JDBC Table, with a
column indicating if it's a table or
rdblue commented on PR #9323:
URL: https://github.com/apache/iceberg/pull/9323#issuecomment-1906444781
@jasonf20, explicitly setting the sequence number isn't safe. Sequence
numbers are assigned when the client attempts to commit and must be updated if
the client has to retry. You could mak
jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463559622
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -303,7 +287,294 @@ public static Properties
filterAndRemovePrefix(Map properties, S
return res
nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463558073
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -303,7 +287,294 @@ public static Properties
filterAndRemovePrefix(Map properties, S
return resul
nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463554981
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -303,7 +287,294 @@ public static Properties
filterAndRemovePrefix(Map properties, S
return resul
jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463527520
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463497746
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463495264
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463483616
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
asheeshgarg commented on issue #208:
URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906088623
@jqin61 just wondering if we can use this directly
https://arrow.apache.org/docs/python/generated/pyarrow.dataset.partitioning.html
--
This is an automated mess
Fokko commented on PR #283:
URL: https://github.com/apache/iceberg-python/pull/283#issuecomment-1906044198
@HonahX I was thinking of adding this to the `Dockerfile` through an `ENV`
step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Fokko merged PR #295:
URL: https://github.com/apache/iceberg-python/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko opened a new pull request, #296:
URL: https://github.com/apache/iceberg-python/pull/296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
nicor88 commented on PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1905753459
@HonahX @mgmarino all good on my side, all worked with a new table and with
the last commit 💯
great work @mgmarino !
--
This is an automated message from the Apache Git Service
JanKaul closed issue #75: Adopt `Catalog` API to include references to the
`TableMetadata` and the `metadata_location` in the `TableCommit` payload for
the `update_table` method
URL: https://github.com/apache/iceberg-rust/issues/75
--
This is an automated message from the Apache Git Service.
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462719672
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
tmnd1991 commented on PR #9192:
URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1905614023
any chance to have this reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
nastra commented on code in PR #9524:
URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462880626
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java:
##
@@ -58,9 +61,11 @@
public class TestIcebergSourceContinuous {
nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462869217
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -303,7 +287,294 @@ public static Properties
filterAndRemovePrefix(Map properties, S
return resul
nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462866365
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462861172
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apa
79 matches
Mail list logo