Re: [PR] API, Spark: Fix aggregation pushdown on struct fields [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9176: URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464446258 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java: ## @@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCantPushDown(

Re: [PR] API, Spark: Fix aggregation pushdown on struct fields [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9176: URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464437182 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java: ## @@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCantPushDown(

Re: [PR] Build: Don't run CI's on unrelated changes [iceberg]

2024-01-23 Thread via GitHub
nastra merged PR #9526: URL: https://github.com/apache/iceberg/pull/9526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark 3.4, 3.5: Enable drop table with purge in tests [iceberg]

2024-01-23 Thread via GitHub
nastra merged PR #9548: URL: https://github.com/apache/iceberg/pull/9548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Set Glue Table Information when creating/updating tables [iceberg-python]

2024-01-23 Thread via GitHub
mgmarino commented on PR #288: URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1907487756 > Overall LGTM! Thank you very much @mgmarino! Just adding one final request to make `IcebergSchemaToGlueType` internal by adding `_`. Sorry I missed that early Sure, np!

Re: [I] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
HonahX closed issue #285: Add install extra for sqlite URL: https://github.com/apache/iceberg-python/issues/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] `schema_id` not incremented during schema evolution [iceberg-python]

2024-01-23 Thread via GitHub
HonahX commented on issue #290: URL: https://github.com/apache/iceberg-python/issues/290#issuecomment-1907475405 @kevinjqliu Thanks for sharing these options. I think (3) is enough here since this is just in test. There are only few places which require checking equality of both fields and

Re: [PR] Set Glue Table Information when creating/updating tables [iceberg-python]

2024-01-23 Thread via GitHub
HonahX commented on code in PR #288: URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464346417 ## pyiceberg/catalog/glue.py: ## @@ -84,17 +110,97 @@ def _construct_parameters( return new_parameters +GLUE_PRIMITIVE_TYPES = { +BooleanType: "boolean

Re: [PR] Flink: Implement enumerator metrics for pending splits, pending recor… [iceberg]

2024-01-23 Thread via GitHub
pvary commented on code in PR #9524: URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464351088 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java: ## @@ -58,9 +61,11 @@ public class TestIcebergSourceContinuous {

Re: [PR] Set Glue Table Information when creating/updating tables [iceberg-python]

2024-01-23 Thread via GitHub
HonahX commented on code in PR #288: URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464342275 ## tests/catalog/integration_test_glue.py: ## @@ -279,6 +379,20 @@ def test_commit_table_update_schema( assert test_catalog._parse_metadata_version(table.metad

Re: [PR] Lock Ray on <2.8.0 [iceberg-python]

2024-01-23 Thread via GitHub
HonahX commented on PR #298: URL: https://github.com/apache/iceberg-python/pull/298#issuecomment-1907409790 OOPS. Seems there is a conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Spec: add multi-arg transform support [iceberg]

2024-01-23 Thread via GitHub
advancedxy commented on PR #8579: URL: https://github.com/apache/iceberg/pull/8579#issuecomment-1907243141 @szehon-ho @aokolnychyi the `bucketV2` part is removed from this PR. Let me know if you have any more comments. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Flink: Implement enumerator metrics for pending splits, pending recor… [iceberg]

2024-01-23 Thread via GitHub
stevenzwu commented on code in PR #9524: URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464178171 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java: ## @@ -58,9 +61,11 @@ public class TestIcebergSourceContinuous

Re: [PR] Flink: Implement enumerator metrics for pending splits, pending recor… [iceberg]

2024-01-23 Thread via GitHub
mas-chen commented on code in PR #9524: URL: https://github.com/apache/iceberg/pull/9524#discussion_r1464155134 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java: ## @@ -58,9 +61,11 @@ public class TestIcebergSourceContinuous

Re: [I] Query optimization fails after upgrading to 1.4.0+ with nullif in predicate [iceberg]

2024-01-23 Thread via GitHub
jakelong95 commented on issue #9518: URL: https://github.com/apache/iceberg/issues/9518#issuecomment-1907148175 The issue is reproducible on Iceberg 1.4.2 and Spark 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] feat: add support for catalogs with glue implementation to start [iceberg-go]

2024-01-23 Thread via GitHub
wolfeidau commented on code in PR #51: URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1464148047 ## catalog/glue.go: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

Re: [PR] feat: add support for catalogs with glue implementation to start [iceberg-go]

2024-01-23 Thread via GitHub
wolfeidau commented on code in PR #51: URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1464148047 ## catalog/glue.go: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464146096 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -139,24 +139,9 @@ public void readFromMultipleViews() throws NoSu

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145827 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145346 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464144880 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464142918 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [I] Add namespace support in Iceberg Catalog [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #672: URL: https://github.com/apache/iceberg/issues/672#issuecomment-1907128437 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Use uncompressed page size to set initial size for Arrow data buffers [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #661: URL: https://github.com/apache/iceberg/issues/661#issuecomment-1907128408 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Fix Filter and Projection unit tests on vectorized-read branch [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #660: URL: https://github.com/apache/iceberg/issues/660#issuecomment-1907128385 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Prefetch parquet data pages [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #647: URL: https://github.com/apache/iceberg/issues/647#issuecomment-1907128362 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Views on top of Iceberg tables [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #644: URL: https://github.com/apache/iceberg/issues/644#issuecomment-1907128329 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Broadcast Join Failure [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #621: URL: https://github.com/apache/iceberg/issues/621#issuecomment-1907128297 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Fix Parquet's fallback field id assignment [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #586: URL: https://github.com/apache/iceberg/issues/586#issuecomment-1907128245 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [I] Don't use internal Spark classes to migrate existing tables to Iceberg [iceberg]

2024-01-23 Thread via GitHub
github-actions[bot] commented on issue #595: URL: https://github.com/apache/iceberg/issues/595#issuecomment-1907128274 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. T

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-23 Thread via GitHub
singhpk234 commented on code in PR #9530: URL: https://github.com/apache/iceberg/pull/9530#discussion_r1464132457 ## aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java: ## @@ -59,7 +60,7 @@ private IcebergToGlueConverter() {} private static final Patter

Re: [I] Query optimization fails after upgrading to 1.4.0+ with nullif in predicate [iceberg]

2024-01-23 Thread via GitHub
singhpk234 commented on issue #9518: URL: https://github.com/apache/iceberg/issues/9518#issuecomment-1907096291 > Apologies, I edited out a quick test I had done that I actually ran on a cluster that is on EMR 6.14 so it's expected that my test would succeed instead of hit the reported erro

Re: [PR] Flink: Adds the ability to read from a branch on the Flink Iceberg Source [iceberg]

2024-01-23 Thread via GitHub
stevenzwu commented on code in PR #9547: URL: https://github.com/apache/iceberg/pull/9547#discussion_r1464036002 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java: ## @@ -195,7 +192,10 @@ void monitorAndForwardSplits() { // Ref

Re: [PR] Flink: Adds the ability to read from a branch on the Flink Iceberg Source [iceberg]

2024-01-23 Thread via GitHub
stevenzwu commented on code in PR #9547: URL: https://github.com/apache/iceberg/pull/9547#discussion_r1464034995 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java: ## @@ -195,7 +192,10 @@ void monitorAndForwardSplits() { // Ref

Re: [PR] API, Spark: Fix aggregation pushdown on struct fields [iceberg]

2024-01-23 Thread via GitHub
amogh-jahagirdar commented on code in PR #9176: URL: https://github.com/apache/iceberg/pull/9176#discussion_r1464032789 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java: ## @@ -249,6 +250,78 @@ public void testAggregateNotPushDownIfOneCan

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on PR #297: URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906969525 Thanks @kevinjqliu for picking this up 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
Fokko merged PR #297: URL: https://github.com/apache/iceberg-python/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
kevinjqliu commented on PR #297: URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906912995 @Fokko thanks, I just ran `poetry lock --no-update` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on PR #297: URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906902491 @kevinjqliu There is no upper bound constraint on Ray, and therefore it is bumped to the latest version, which is not compatible for some reason. I've created https://github.com/apache

Re: [I] Support partitioned writes [iceberg-python]

2024-01-23 Thread via GitHub
syun64 commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906879564 > @Fokko @jqin61 I am also interested in this to move forward as we also deal with lot of write involves partitions. Happy to collaborate on to this. For write_dataset() we might

Re: [I] Support partitioned writes [iceberg-python]

2024-01-23 Thread via GitHub
jqin61 commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906856252 > @jqin61 just wondering if we can use this directly https://arrow.apache.org/docs/python/generated/pyarrow.dataset.partitioning.html Thank you Ashish! I overlooked it, as

Re: [PR] feat: add support for catalogs with glue implementation to start [iceberg-go]

2024-01-23 Thread via GitHub
zeroshade commented on code in PR #51: URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1463940580 ## catalog/glue.go: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fil

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463848914 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [I] InMemory Catalog [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on issue #293: URL: https://github.com/apache/iceberg-python/issues/293#issuecomment-1906706092 @kevinjqliu Alright, that's fair, I just wanted to make sure that we considered the option before making the `InMemory` one public 👍 -- This is an automated message from the Ap

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463815754 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +62,10 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
kevinjqliu commented on PR #297: URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906669155 @Fokko np. I had to rebase and regenerate the lock file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] Purge support for Iceberg view [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on issue #9433: URL: https://github.com/apache/iceberg/issues/9433#issuecomment-1906663747 I think cleaning up metadata files is a catalog concern, not something that should be exposed to users through a PURGE flag. A user is not prepared to make a good choice about whether

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-1906654805 @amogh-jahagirdar, I'm not sure I agree with this change. It seems to me that this is the Parquet default regardless of whether the default write format is Avro or ORC. It's a format-speci

Re: [I] Create Iceberg Table from pyarrow Schema with no IDs [iceberg-python]

2024-01-23 Thread via GitHub
syun64 commented on issue #278: URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-1906647358 That makes sense @Fokko . Just to make sure we are on the same page, does the following approach align with your thoughts? We are proposing to update the create_tabl

Re: [PR] Add install extra for sqlite [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on PR #297: URL: https://github.com/apache/iceberg-python/pull/297#issuecomment-1906625437 @kevinjqliu Thanks for working on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Create Iceberg Table from pyarrow Schema with no IDs [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on issue #278: URL: https://github.com/apache/iceberg-python/issues/278#issuecomment-1906620668 Alright, I went to the source and talked with @danielcweeks and @rdblue. It looks like we made things more complicated than actually needed. So when reading and writing Parq

Re: [I] `schema_id` not incremented during schema evolution [iceberg-python]

2024-01-23 Thread via GitHub
kevinjqliu commented on issue #290: URL: https://github.com/apache/iceberg-python/issues/290#issuecomment-1906606223 Thanks for the explanation @HonahX The equality check (`==`) for `Schema` here is overloaded. Sometimes it's used to check whether two tables have the same structure,

Re: [PR] Adding Snowflake's public documentation [iceberg-docs]

2024-01-23 Thread via GitHub
Fokko merged PR #297: URL: https://github.com/apache/iceberg-docs/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906568528 @ajantha-bhat correct, corner case but possible 😸 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
ajantha-bhat commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906559757 > I'm reworking a bit the SQL statement to have views and tables in the same JDBC table, especially to address name atomically between table and view. When we create a view, we che

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906555047 @ajantha-bhat the potential issue is about name/check between table and view, it's separated today. My concern is not about namespace but more concurrency on name between table and view.

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906552439 I'm reworking a bit the SQL statement to have views and tables in the same JDBC table, especially to address name atomically between table and view. When we create a view, we check if

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
ajantha-bhat commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906542388 > In order to avoid any potential concurrency issue, I'm working on a new approach where both tables and views are store in the same JDBC Table, with a column indicating if it's a ta

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1906520489 In order to avoid any potential concurrency issue, I'm working on a new approach where both tables and views are store in the same JDBC Table, with a column indicating if it's a table or

Re: [PR] API: New API For sequential / streaming updates [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on PR #9323: URL: https://github.com/apache/iceberg/pull/9323#issuecomment-1906444781 @jasonf20, explicitly setting the sequence number isn't safe. Sequence numbers are assigned when the client attempts to commit and must be updated if the client has to retry. You could mak

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463559622 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -303,7 +287,294 @@ public static Properties filterAndRemovePrefix(Map properties, S return res

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463558073 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -303,7 +287,294 @@ public static Properties filterAndRemovePrefix(Map properties, S return resul

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463554981 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -303,7 +287,294 @@ public static Properties filterAndRemovePrefix(Map properties, S return resul

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463527520 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463497746 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463495264 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1463483616 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [I] Support partitioned writes [iceberg-python]

2024-01-23 Thread via GitHub
asheeshgarg commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1906088623 @jqin61 just wondering if we can use this directly https://arrow.apache.org/docs/python/generated/pyarrow.dataset.partitioning.html -- This is an automated mess

Re: [PR] Build: Bump pyspark from 3.4.2 to 3.5.0 [iceberg-python]

2024-01-23 Thread via GitHub
Fokko commented on PR #283: URL: https://github.com/apache/iceberg-python/pull/283#issuecomment-1906044198 @HonahX I was thinking of adding this to the `Dockerfile` through an `ENV` step -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Build: Bump pyarrow from 14.0.2 to 15.0.0 [iceberg-python]

2024-01-23 Thread via GitHub
Fokko merged PR #295: URL: https://github.com/apache/iceberg-python/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

[PR] Add UnionByName functionality [iceberg-python]

2024-01-23 Thread via GitHub
Fokko opened a new pull request, #296: URL: https://github.com/apache/iceberg-python/pull/296 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Set Glue Table Information when creating/updating tables [iceberg-python]

2024-01-23 Thread via GitHub
nicor88 commented on PR #288: URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1905753459 @HonahX @mgmarino all good on my side, all worked with a new table and with the last commit 💯 great work @mgmarino ! -- This is an automated message from the Apache Git Service

Re: [I] Adopt `Catalog` API to include references to the `TableMetadata` and the `metadata_location` in the `TableCommit` payload for the `update_table` method [iceberg-rust]

2024-01-23 Thread via GitHub
JanKaul closed issue #75: Adopt `Catalog` API to include references to the `TableMetadata` and the `metadata_location` in the `TableCommit` payload for the `update_table` method URL: https://github.com/apache/iceberg-rust/issues/75 -- This is an automated message from the Apache Git Service.

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-23 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462719672 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apache req

Re: [PR] Spark: IN clause on system function is not pushed down [iceberg]

2024-01-23 Thread via GitHub
tmnd1991 commented on PR #9192: URL: https://github.com/apache/iceberg/pull/9192#issuecomment-1905614023 any chance to have this reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Flink: Implement enumerator metrics for pending splits, pending recor… [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9524: URL: https://github.com/apache/iceberg/pull/9524#discussion_r1462880626 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java: ## @@ -58,9 +61,11 @@ public class TestIcebergSourceContinuous {

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462869217 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java: ## @@ -303,7 +287,294 @@ public static Properties filterAndRemovePrefix(Map properties, S return resul

Re: [PR] Core: Add view support for JDBC catalog [iceberg]

2024-01-23 Thread via GitHub
nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462866365 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcViewOperations.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-23 Thread via GitHub
liurenjie1024 commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462861172 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apa