nastra commented on issue #7507:
URL: https://github.com/apache/iceberg/issues/7507#issuecomment-1815887798
@stevenzwu does this still apply? If so, then we should re-open and add the
`not-stale` tag so that the issue doesn't get automatically closed
--
This is an automated message from t
jackye1995 opened a new issue, #7528:
URL: https://github.com/apache/iceberg/issues/7528
### Feature Request / Improvement
Currently we just use exponential backoff. In practice when there are many
concurrent writes, the conflict rate is still high even with jitter. There are
some ot
jackwang2 commented on issue #9092:
URL: https://github.com/apache/iceberg/issues/9092#issuecomment-1815885984
> INSERT INTO hive_prod.lena.idsp_tpats_reattribute (
>event_id,
>event_type,
>timestamp,
>is_test,
>is_demand_third_party,
nastra commented on issue #9018:
URL: https://github.com/apache/iceberg/issues/9018#issuecomment-1815871497
According to
```
com.vungle.lena.idsp.aggregation_report.SparkMain$.saveReport(SparkMain.scala:233)
at
com.vungle.lena.idsp.aggregation_report.SparkMain$.doForEachPeriod(Spark
JuiceFV commented on issue #9097:
URL: https://github.com/apache/iceberg/issues/9097#issuecomment-1815870262
> @JuiceFV this isn't really an Iceberg issue, but rather an issue that you
need to provide the correct jar for postgres that contains the [JDBC
driver](https://jdbc.postgresql.org/)
nastra commented on issue #9092:
URL: https://github.com/apache/iceberg/issues/9092#issuecomment-1815870209
According to
```
at
com.vungle.lena.BoilerplateSparkMain.appendToIcebergTable(Boilerplate.scala:1818)
at
com.vungle.lena.BoilerplateSparkMain.appendToIcebergTable$(Boiler
chenwyi2 opened a new issue, #9100:
URL: https://github.com/apache/iceberg/issues/9100
### Feature Request / Improvement
Recently i find that we use overwrite mode to create file for flink or
spark, for example:
` switch (format) {
case AVRO:
return Avro.w
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396782299
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396766806
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396766098
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestColumnStatsWatermarkExtractor.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Soft
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396764048
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailoverWithWatermarkExtractor.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apac
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396759830
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/WatermarkExtractorRecordEmitter.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Softwar
mapleFU commented on issue #9099:
URL: https://github.com/apache/iceberg/issues/9099#issuecomment-1815818276
Also, in ORC parquet, I found
```
column id = [iceberg.id](http://iceberg.id/)
```
Seems they're all equal to field id?
--
This is an automated message from the
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396756527
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergWatermarkExtractor.java:
##
@@ -18,19 +18,11 @@
*/
package org.apache.iceberg.flink.so
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396755774
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396751097
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/ColumnStatsWatermarkExtractor.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396746159
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -429,6 +444,30 @@ public Builder setAll(Map properties) {
return this;
stevenzwu commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1396577355
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/WatermarkExtractorRecordEmitter.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Sof
liurenjie1024 commented on issue #98:
URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1815764353
> I'd like to have a try
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
my-vegetable-has-exploded commented on issue #98:
URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1815745708
I'd like to have a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
abmo-x commented on issue #1617:
URL: https://github.com/apache/iceberg/issues/1617#issuecomment-1815701202
@jotarada yes, relative path should help with this use case
However, you don't really need relative paths if you use the same paths in
alluxio. you can just configure the s3 end
stevenzwu commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1394630754
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/WatermarkExtractorRecordEmitter.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Sof
fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1396541554
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -768,7 +769,7 @@ pub struct SnapshotLog {
/// Id of the snapshot.
pub snapshot_id: i64,
/// Last u
fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1396541293
##
crates/iceberg/src/spec/timestamp_millis.rs:
##
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
huaxingao commented on PR #9010:
URL: https://github.com/apache/iceberg/pull/9010#issuecomment-1815554325
Thanks @aokolnychyi @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
aokolnychyi commented on PR #9010:
URL: https://github.com/apache/iceberg/pull/9010#issuecomment-1815532458
Thanks, @huaxingao! Thanks for reviewing, @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
aokolnychyi merged PR #9010:
URL: https://github.com/apache/iceberg/pull/9010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
github-actions[bot] commented on issue #7507:
URL: https://github.com/apache/iceberg/issues/7507#issuecomment-1815527761
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #7507: API: StructProjection returns a null
Projection object when the nested struct is null
URL: https://github.com/apache/iceberg/issues/7507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on issue #7528:
URL: https://github.com/apache/iceberg/issues/7528#issuecomment-1815527738
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #7528: Improve retry algorithm for Tasks
URL: https://github.com/apache/iceberg/issues/7528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aokolnychyi commented on PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#issuecomment-1815502707
Thanks, @singhpk234 @RussellSpitzer @flyrain!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
aokolnychyi merged PR #9047:
URL: https://github.com/apache/iceberg/pull/9047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396432577
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396432577
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
dependabot[bot] opened a new pull request, #154:
URL: https://github.com/apache/iceberg-python/pull/154
Bumps [mypy-boto3-glue](https://github.com/youtype/mypy_boto3_builder) from
1.29.0 to 1.29.2.
Commits
See full diff in https://github.com/youtype/mypy_boto3_builder/commits";
dependabot[bot] opened a new pull request, #153:
URL: https://github.com/apache/iceberg-python/pull/153
Bumps [moto](https://github.com/getmoto/moto) from 4.2.8 to 4.2.9.
Changelog
Sourced from https://github.com/getmoto/moto/blob/master/CHANGELOG.md";>moto's
changelog.
4.2.
amogh-jahagirdar commented on issue #7635:
URL: https://github.com/apache/iceberg/issues/7635#issuecomment-1815363187
OK after some debugging and writing some local tests, what I'm seeing is the
following:
1.) In certain cases, when there's branches the DELETE in Spark gets
executed
RussellSpitzer commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396328736
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
RussellSpitzer commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396325583
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
FranMorilloAWS commented on issue #9089:
URL: https://github.com/apache/iceberg/issues/9089#issuecomment-1815253567
I can see Start to flush snashot state to state backend, but i dont see
Committing log
--
This is an automated message from the Apache Git Service.
To respond to the message
FranMorilloAWS commented on issue #9089:
URL: https://github.com/apache/iceberg/issues/9089#issuecomment-1815252840
I can see that checkpoints are happening successfully without hiccup every
minute. I can see data files arriving but not commit is being triggered to the
tables. Nor sure if b
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1396283697
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
pvary commented on issue #9089:
URL: https://github.com/apache/iceberg/issues/9089#issuecomment-1815237417
If you see no `Start to flush snapshot state to state backend, table: {},
checkpointId: {}` in the logs, then I am pretty sure that the issue is with the
checkpointing. Somehow Flink d
aokolnychyi commented on PR #9020:
URL: https://github.com/apache/iceberg/pull/9020#issuecomment-1815223487
@amogh-jahagirdar @nastra @Fokko @flyrain @RussellSpitzer, could you also
check this one whenever you have a minute? It would be nice to wrap up V2 table
maintenance.
--
This is a
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396260261
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aokolnychyi commented on code in PR #9020:
URL: https://github.com/apache/iceberg/pull/9020#discussion_r1396255189
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -159,34 +169,49 @@ public RewriteManifests.Result execute
aokolnychyi commented on code in PR #9020:
URL: https://github.com/apache/iceberg/pull/9020#discussion_r1396255446
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -264,14 +293,15 @@ private U withReusableDS(Dataset ds,
aokolnychyi commented on code in PR #9020:
URL: https://github.com/apache/iceberg/pull/9020#discussion_r1396246503
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##
@@ -649,6 +659,243 @@ public void
testRewriteLargeManifestsE
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396153376
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396151524
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aokolnychyi commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396151524
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
syun64 commented on PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1814980948
Took your suggestions @nastra . I've added the supporting documentation to
the OpenAPI spec in this [PR](https://github.com/apache/iceberg/pull/8998) to
follow up on the discussion on the
RussellSpitzer commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396132411
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
RussellSpitzer commented on code in PR #9047:
URL: https://github.com/apache/iceberg/pull/9047#discussion_r1396130069
##
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1396122380
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on PR #9069:
URL: https://github.com/apache/iceberg/pull/9069#issuecomment-1814915569
Thanks @aokolnychyi for the fix and @nk1506 and @anuragmantri for the reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
RussellSpitzer merged PR #9069:
URL: https://github.com/apache/iceberg/pull/9069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
RussellSpitzer commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1396038401
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -130,7 +130,7 @@ public void initialize(String name, Map
properties) {
void
RussellSpitzer commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1396038401
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -130,7 +130,7 @@ public void initialize(String name, Map
properties) {
void
RussellSpitzer commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1396038401
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -130,7 +130,7 @@ public void initialize(String name, Map
properties) {
void
RussellSpitzer commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1396038401
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -130,7 +130,7 @@ public void initialize(String name, Map
properties) {
void
aokolnychyi commented on PR #8970:
URL: https://github.com/apache/iceberg/pull/8970#issuecomment-1814809415
Thank you, @singhpk234 @pvary!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
aokolnychyi merged PR #8970:
URL: https://github.com/apache/iceberg/pull/8970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
syun64 commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1395969409
##
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##
@@ -186,8 +186,21 @@ private static void throwFailure(
throw new RESTException("Unhandled error: %
RussellSpitzer commented on issue #8343:
URL: https://github.com/apache/iceberg/issues/8343#issuecomment-1814755871
Quick Guess on what might be going wrong, My assumption would be the session
being used is not actually loaded with the extensions. I've seen this happen in
a few different in
pvary commented on PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#issuecomment-1814715417
I have one question left, which is somewhat related to the new usage of the
`HiveOperationsBase`
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1395930004
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #9061:
URL: https://github.com/apache/iceberg/pull/9061#discussion_r1395925805
##
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##
@@ -18,13 +18,15 @@
*/
package org.apache.iceberg.gcp;
+import com.google.api.client.util.Precond
nastra merged PR #9068:
URL: https://github.com/apache/iceberg/pull/9068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
FranMorilloAWS commented on issue #9089:
URL: https://github.com/apache/iceberg/issues/9089#issuecomment-1814705868
I can see in the logs there are no logs indicating that a commit happened.
As well as not seeing the metadata .json file created The only log i see is
Start to flush snaps
nastra merged PR #9096:
URL: https://github.com/apache/iceberg/pull/9096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
pvary commented on issue #9089:
URL: https://github.com/apache/iceberg/issues/9089#issuecomment-1814690691
> however there are no commits happening to the tables
How did you verify this?
Which of the following logs could you see in the logs when the commit does
not happen:
pvary commented on issue #9094:
URL: https://github.com/apache/iceberg/issues/9094#issuecomment-1814679794
I would guess that you are using Hive 3.1.x, and using Tez execution engine.
Either use Hive 4.0.0 (with the embedded Iceberg), or use Hive 3.1.x with MR
for write, and Tez for r
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395896201
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395895654
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/WatermarkExtractorRecordEmitter.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Softwar
tomtongue commented on code in PR #9096:
URL: https://github.com/apache/iceberg/pull/9096#discussion_r1395894839
##
docs/configuration.md:
##
@@ -47,51 +47,51 @@ Iceberg tables support table properties to configure table
behavior, like the de
### Write properties
-| Proper
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395894584
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/WatermarkExtractorRecordEmitter.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Softwar
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395894184
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/TimestampBasedWatermarkExtractor.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Softwa
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395891709
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/TimestampBasedWatermarkExtractor.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Softwa
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395890875
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/split/SplitComparators.java:
##
@@ -56,4 +57,20 @@ public static SerializableComparator
fileSequenceNu
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395890308
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergWatermarkExtractor.java:
##
@@ -18,19 +18,11 @@
*/
package org.apache.iceberg.flink.so
bryanck commented on PR #9068:
URL: https://github.com/apache/iceberg/pull/9068#issuecomment-1814655988
This seems fine, though the credentials can be set via env vars and also via
the connection string. The properties are mostly useful if you want to set
properties via a REST catalog respo
bryanck commented on PR #9061:
URL: https://github.com/apache/iceberg/pull/9061#issuecomment-1814645914
This looks good to me, as long as the format checks are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
nastra commented on code in PR #9096:
URL: https://github.com/apache/iceberg/pull/9096#discussion_r1395851427
##
docs/configuration.md:
##
@@ -47,51 +47,51 @@ Iceberg tables support table properties to configure table
behavior, like the de
### Write properties
-| Property
JuiceFV opened a new issue, #9097:
URL: https://github.com/apache/iceberg/issues/9097
### Query engine
Flink 1.16
### Question
I'm trying sink data from PostgreSQL table to iceberg using Flink.
I'm currently using Flink 1.16.2 (PyFlink) as it mentioned
[here](http
zinking commented on PR #8872:
URL: https://github.com/apache/iceberg/pull/8872#issuecomment-1814306949
> Thank you, @zinking! Would you be interested to cherry-pick this change to
other Spark versions?
sure, I will follow up.
--
This is an automated message from the Apache Git Ser
nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1395572709
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier original
tomtongue opened a new pull request, #9096:
URL: https://github.com/apache/iceberg/pull/9096
The parquet default compression codec is still `gzip` in the doc.
I tested the Iceberg 1.4.1 with Spark, and it's `zstd` from my check:
```
# DESCRIBE EXTENDED TABLE
...
|Provid
przemekd commented on PR #9029:
URL: https://github.com/apache/iceberg/pull/9029#issuecomment-1814274741
@aokolnychyi Sure. So, the problem is shortly described in the linked issue:
https://github.com/apache/iceberg/issues/9025
I am not directly creating `SerializableTable` instance in m
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395543097
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache Softw
github-raphael-douyere commented on issue #8953:
URL: https://github.com/apache/iceberg/issues/8953#issuecomment-1814229365
After looking a bit more, we think this
https://github.com/apache/iceberg/pull/5214 introduced the bug.
--
This is an automated message from the Apache Git Service.
ronkorving commented on PR #8261:
URL: https://github.com/apache/iceberg/pull/8261#issuecomment-1814194491
Just wanted to say thank you for this, @bryanck. This really helped me out
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395498235
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Softw
daoxunwu-vungle commented on PR #9017:
URL: https://github.com/apache/iceberg/pull/9017#issuecomment-1814151302
Hello, will this fix be propogated to 1.3.x and 1.4.x releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395457601
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395453030
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395450708
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -97,6 +98,11 @@ protected List generateRecords(int numRecords, lo
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395444790
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/TimestampBasedWatermarkExtractor.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Softwa
liurenjie1024 commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1395348328
##
crates/catalog/rest/testdata/create_table_response.json:
##
@@ -0,0 +1,53 @@
+{
Review Comment:
Yes, I'll add such integration tests later pr. It takes so
1 - 100 of 111 matches
Mail list logo
