syun64 commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1395969409
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -186,8 +186,21 @@ private static void throwFailure(
throw new RESTException("Unhandled error: %s", errorResponse);
}
- private URI buildUri(String path, Map<String, String> params) {
+ private String buildBaseUri(String path) {
+ // if full path is provided, use the input path as baseUri
+ if (path.startsWith("https://";)) {
Review Comment:
I thought it would be unsafe for an auth server endpoint to be http - but
I'm fine to leave that judgment to the users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
