[GitHub] [iceberg] stevenzwu commented on pull request #6377: Flink: add util class to generate test data with extensive coverage d…

2022-12-10 Thread GitBox
stevenzwu commented on PR #6377: URL: https://github.com/apache/iceberg/pull/6377#issuecomment-1345457933 @hililiwei @chenjunjiedada don't want to use random data. The purpose of this util class is to generate Flink `RowData`, Iceberg `GenericRecord`, and Avro `GenericRecord` (internal code

[GitHub] [iceberg] dungdm93 commented on pull request #6254: Python: implement `to_pandas`

2022-12-10 Thread GitBox
dungdm93 commented on PR #6254: URL: https://github.com/apache/iceberg/pull/6254#issuecomment-1345456299 @rdblue, @Fokko rebased and conflicts are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [iceberg] chenjunjiedada commented on pull request #6377: Flink: add util class to generate test data with extensive coverage d…

2022-12-10 Thread GitBox
chenjunjiedada commented on PR #6377: URL: https://github.com/apache/iceberg/pull/6377#issuecomment-1345455704 In flink-1.13 test source, we have `RandomRowData` class that should work. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [iceberg] dependabot[bot] opened a new pull request, #6403: Build: Bump duckdb from 0.6.0 to 0.6.1 in /python

2022-12-10 Thread GitBox
dependabot[bot] opened a new pull request, #6403: URL: https://github.com/apache/iceberg/pull/6403 Bumps [duckdb](https://github.com/duckdb/duckdb) from 0.6.0 to 0.6.1. Release notes Sourced from https://github.com/duckdb/duckdb/releases";>duckdb's releases. 0.6.1 Bugfix Rele

[GitHub] [iceberg] github-actions[bot] commented on issue #5023: Failed to delete data from iceberg data table

2022-12-10 Thread GitBox
github-actions[bot] commented on issue #5023: URL: https://github.com/apache/iceberg/issues/5023#issuecomment-1345414919 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

[GitHub] [iceberg] flyrain commented on a diff in pull request #6350: Query changelog table with a timestamp range

2022-12-10 Thread GitBox
flyrain commented on code in PR #6350: URL: https://github.com/apache/iceberg/pull/6350#discussion_r1045128513 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java: ## @@ -308,6 +339,17 @@ public Scan buildChangelogScan() { return new Spar

[GitHub] [iceberg] stevenzwu commented on pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16

2022-12-10 Thread GitBox
stevenzwu commented on PR #6394: URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1345355840 @hililiwei this looks mostly good. can we reconcile the differences across all 3 versions regarding the `maxPlanningSnapshotCount` diff? one seems to be the ordering of variable

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16

2022-12-10 Thread GitBox
stevenzwu commented on code in PR #6394: URL: https://github.com/apache/iceberg/pull/6394#discussion_r1045118974 ## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java: ## @@ -84,7 +84,7 @@ public IcebergTableSource( TableSchema schema,

[GitHub] [iceberg] hililiwei opened a new pull request, #6402: Flink: Add UT for NaN

2022-12-10 Thread GitBox
hililiwei opened a new pull request, #6402: URL: https://github.com/apache/iceberg/pull/6402 cc @stevenzwu, I am not sure whether this PR is feasible, please help to review it. Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6350: Query changelog table with a timestamp range

2022-12-10 Thread GitBox
hililiwei commented on code in PR #6350: URL: https://github.com/apache/iceberg/pull/6350#discussion_r1045099019 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java: ## @@ -308,6 +339,17 @@ public Scan buildChangelogScan() { return new Sp

[GitHub] [iceberg] hililiwei opened a new pull request, #6401: Flink: Change to oldestAncestorAfter

2022-12-10 Thread GitBox
hililiwei opened a new pull request, #6401: URL: https://github.com/apache/iceberg/pull/6401 address https://github.com/apache/iceberg/pull/6350#discussion_r1044901322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [iceberg] Fokko commented on issue #6397: Python Instructions currently do not work for testing

2022-12-10 Thread GitBox
Fokko commented on issue #6397: URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1345256690 @RussellSpitzer Thanks for opening this issue. There are two things going on: ``` ImportError while loading conftest '/Users/russellspitzer/Temp/pypypy/iceberg/python/tests/co

[GitHub] [iceberg-docs] quantsegu commented on pull request #186: Request for adding IOMETE as a vendor

2022-12-10 Thread GitBox
quantsegu commented on PR #186: URL: https://github.com/apache/iceberg-docs/pull/186#issuecomment-1345251017 Request for approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [iceberg] rubenvdg commented on issue #6397: Python Instructions currently do not work for testing

2022-12-10 Thread GitBox
rubenvdg commented on issue #6397: URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1345240557 I was trying to set up the development environment this week and was running into similar issues. When running `make tests` I get: ``` FAILED tests/avro/test_reader.py::tes

[GitHub] [iceberg] hililiwei commented on pull request #6377: Flink: add util class to generate test data with extensive coverage d…

2022-12-10 Thread GitBox
hililiwei commented on PR #6377: URL: https://github.com/apache/iceberg/pull/6377#issuecomment-1345189569 Could we have a class that generates random data according to the schema passed in by user? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [iceberg] hililiwei commented on pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16

2022-12-10 Thread GitBox
hililiwei commented on PR #6394: URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1345178692 diff btw 1.14 and 1.16 flink/source/ ``` $ git diff --no-index flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ flink/v1.16/flink/src/main/java/org/apache/iceberg