Fokko commented on issue #6397:
URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1345256690
@RussellSpitzer Thanks for opening this issue. There are two things going on:
```
ImportError while loading conftest
'/Users/russellspitzer/Temp/pypypy/iceberg/python/tests/conftest.py'.
tests/conftest.py:40: in <module>
import aiobotocore.awsrequest
E ModuleNotFoundError: No module named 'aiobotocore'
```
Was a bug in 0.2.0 found by @danielcweeks. PyArrow was imported on the file
level, while it should have been inlined. So if you didn't have PyArrow
installed, this would cause an issue. We did publish the RC because you need
PyArrow (currently), if you want to read data. This has been fixed in:
https://github.com/apache/iceberg/pull/6362
Running `poetry run pytest` will run all the tests, without looking at the
pytest markers. The tests marked with s3 require a minio container to be
running. This is part of the Makefile `make run test-s3`:
https://github.com/apache/iceberg/blob/master/python/Makefile#L34-L39
@rubenvdg The failing tests are interesting. Do you have more information?
Which Python version are you using?
This week I did an overhaul of the documentation, and moved everything to
the docs `python/mkdocs`, that is published to https://py.iceberg.apache.org/
> Also, for me it's a bit unclear how the following sections connect:
>
https://github.com/apache/iceberg/blob/master/python/README.md#getting-started
> https://github.com/apache/iceberg/blob/master/python/README.md#development
> https://github.com/apache/iceberg/blob/master/python/CONTRIBUTING.md
It seems that I didn't do a very good job on cleaning up the old files. I
wanted to remove the `CONTRIBUTING.md`, since it has been ported to the docs:
https://py.iceberg.apache.org/contributing/. I think the docs are a good place
to centralize everything you need to install pyiceberg, setup your development
environment, and everything around releases. I noticed that a lot of people
don't find their way to the `CONTRIBUTING.md` and then it doesn't really add
value :)
I would suggest:
- Removing `CONTRIBUTING.md`
- Clean up the `README.md` and point to the docs page
- Add a section on the pytest markers.
Hope this helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
