hililiwei commented on PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1345178692
diff btw 1.14 and 1.16 flink/source/
```
$ git diff --no-index
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/
diff --git
a/flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java
b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java
index 1be312961..610657e8d 100644
---
a/flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java
+++
b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java
@@ -31,6 +31,7 @@ import
org.apache.flink.streaming.api.datastream.DataStreamSource;
import
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
import org.apache.flink.table.api.TableSchema;
import org.apache.flink.table.connector.ChangelogMode;
+import org.apache.flink.table.connector.ProviderContext;
import org.apache.flink.table.connector.source.DataStreamScanProvider;
import org.apache.flink.table.connector.source.DynamicTableSource;
import org.apache.flink.table.connector.source.ScanTableSource;
@@ -200,7 +201,8 @@ public class IcebergTableSource
public ScanRuntimeProvider getScanRuntimeProvider(ScanContext
runtimeProviderContext) {
return new DataStreamScanProvider() {
@Override
- public DataStream<RowData>
produceDataStream(StreamExecutionEnvironment execEnv) {
+ public DataStream<RowData> produceDataStream(
+ ProviderContext providerContext, StreamExecutionEnvironment
execEnv) {
if
(readableConfig.get(FlinkConfigOptions.TABLE_EXEC_ICEBERG_USE_FLIP27_SOURCE)) {
return createFLIP27Stream(execEnv);
} else {
diff --git
a/flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
index bbadd56cd..02c4943fe 100644
---
a/flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
+++
b/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
@@ -52,7 +52,6 @@ public class ScanContext implements Serializable {
private final Long splitOpenFileCost;
private final boolean isStreaming;
private final Duration monitorInterval;
- private final int maxPlanningSnapshotCount;
private final String nameMapping;
private final Schema schema;
@@ -60,6 +59,7 @@ public class ScanContext implements Serializable {
private final long limit;
private final boolean includeColumnStats;
private final Integer planParallelism;
+ private final int maxPlanningSnapshotCount;
private ScanContext(
boolean caseSensitive,
@@ -94,7 +94,6 @@ public class ScanContext implements Serializable {
this.splitOpenFileCost = splitOpenFileCost;
this.isStreaming = isStreaming;
this.monitorInterval = monitorInterval;
- this.maxPlanningSnapshotCount = maxPlanningSnapshotCount;
this.nameMapping = nameMapping;
this.schema = schema;
@@ -103,6 +102,7 @@ public class ScanContext implements Serializable {
this.includeColumnStats = includeColumnStats;
this.exposeLocality = exposeLocality;
this.planParallelism = planParallelism;
+ this.maxPlanningSnapshotCount = maxPlanningSnapshotCount;
validate();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
